gecko-dev/netwerk/url-classifier
Dimi Lee 0f6d4af47e Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku
ShouldEnableClassifier checks two things:
1. If AddOn can load the channel
2. If the classified channel is top-level.

For the first point, we added the check in Bug 1308640, and I think the
idea is only for tracking protection to not block channels when
extensions have permission on the channels' domain.
For annotation features, we should always annotate a channel regardless of whether
it is controlled by extensions (also for ETP).

And since we use first-party classification flag in channels, so we
should also annotate channel no matter it is top-level, first-party or
third-party.

So this patch removes calling ShouldEnableClassifier in annotation
features and also rename ShouldEnableClassifier to
ShouldEnableProtectionForChannel to make the idea more clear.

Differential Revision: https://phabricator.services.mozilla.com/D82504
2020-07-08 12:26:53 +00:00
..
AsyncUrlChannelClassifier.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
AsyncUrlChannelClassifier.h
ChannelClassifierService.cpp Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku 2020-05-28 09:51:15 +00:00
ChannelClassifierService.h Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku 2020-05-28 09:51:15 +00:00
UrlClassifierCommon.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierCommon.h Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierExceptionListService.jsm Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureBase.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureBase.h Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureCryptominingAnnotation.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureCryptominingAnnotation.h
UrlClassifierFeatureCryptominingProtection.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureCryptominingProtection.h
UrlClassifierFeatureCustomTables.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureCustomTables.h Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureFactory.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureFactory.h Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureFingerprintingAnnotation.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureFingerprintingAnnotation.h
UrlClassifierFeatureFingerprintingProtection.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureFingerprintingProtection.h
UrlClassifierFeatureFlash.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureFlash.h
UrlClassifierFeatureLoginReputation.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeatureLoginReputation.h
UrlClassifierFeaturePhishingProtection.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
UrlClassifierFeaturePhishingProtection.h
UrlClassifierFeatureResult.cpp
UrlClassifierFeatureResult.h
UrlClassifierFeatureSocialTrackingAnnotation.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureSocialTrackingAnnotation.h
UrlClassifierFeatureSocialTrackingProtection.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureSocialTrackingProtection.h
UrlClassifierFeatureTrackingAnnotation.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureTrackingAnnotation.h
UrlClassifierFeatureTrackingProtection.cpp Bug 1437626 - P5. Only call ShouldEnableClassifier for protection features. r=baku 2020-07-08 12:26:53 +00:00
UrlClassifierFeatureTrackingProtection.h
components.conf Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
moz.build Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
nsChannelClassifier.cpp Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
nsChannelClassifier.h Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
nsIChannelClassifierService.idl Bug 1639718 - P1. Add ChannelClassifierService to support notifying/unblocking channel. r=baku 2020-05-28 09:51:15 +00:00
nsIURIClassifier.idl Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
nsIUrlClassifierExceptionListService.idl Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00
nsIUrlClassifierFeature.idl Bug 1650950 - Rename blacklist, whitelist, and skiplist in the anti-tracking and url-classifier code, r=dimi 2020-07-07 16:17:11 +00:00