gecko-dev/editor/libeditor
Masayuki Nakano 1165b53e10 Bug 1436295 - HTMLEditRules::WillInsertBreak() should cancel resetting EditorDOMPoint when HTMLEditRules::ReturnInParagraph() splits DOM node around the point r=m_kato
This patch only fixes warning, not changing actual behavior of editor.

HTMLEditRules::ReturnInParagraph() splits paragraph *around* given point.
Therefore, from point of view of caller, offset of setting point may be
invalid after HTMLEditRules::ReturnInParagraph() handled the edit action.
In this case, invalidating stored child of the point may cause warning
since offset may be larger than length of its container.

So, if HTMLEditRules::ReturnInParagraph() handles the edit action,
the caller, HTMLEditRules::WillInsertBreak(), should cancel invalidating
the stored child for avoiding unnecessary warning.

MozReview-Commit-ID: DKJlr0Awwlo

--HG--
extra : rebase_source : 8fbefff3b46e55daf8db6342f00de904315d7fcc
2018-02-07 19:04:52 +09:00
..
crashtests Bug 1402526 - Add crashtest. r=me a=test-only 2018-01-15 14:27:45 +09:00
tests Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 2018-02-06 09:36:57 -08:00
CSSEditUtils.cpp Bug 1435149 - Part 1. Change some methods to static or const method in CSSEditUtils. r=masayuki 2018-02-06 12:57:37 +09:00
CSSEditUtils.h Bug 1435149 - Part 1. Change some methods to static or const method in CSSEditUtils. r=masayuki 2018-02-06 12:57:37 +09:00
ChangeAttributeTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
ChangeAttributeTransaction.h Bug 1425412 - part 9: Create factory methods of ChangeAttributeTransaction and remove EditorBase::CreateTxnForSetAttribute() and EditorBase::CreateTxnForRemoveAttribute() r=m_kato 2017-12-18 17:07:52 +09:00
ChangeStyleTransaction.cpp Bug 1428610 part 7. Make the nsICSSDeclaration length API nicer. r=emilio 2018-01-30 14:48:27 -05:00
ChangeStyleTransaction.h Bug 1425412 - part 11: Create factory methods for ChangeStyleTransaction and remove CSSEditUtils::CreateCSSPropertyTxn() r=m_kato 2017-12-18 17:46:57 +09:00
CompositionTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
CompositionTransaction.h Bug 1425412 - part 4: Create CompositionTransaction::Create() and remove EditorBase::CreateTxnForComposition() r=m_kato 2017-12-15 18:26:37 +09:00
CreateElementTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
CreateElementTransaction.h Bug 1425412 - part 3: Create CreateElementTransaction::Create() and remove EditorBase::CreateTxnForCreateElement() r=m_kato 2017-12-15 17:54:10 +09:00
DeleteNodeTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
DeleteNodeTransaction.h Bug 1425412 - part 6: Create DeleteNodeTransaction::MaybeCreate() and remove EditorBaseTransaction::CreateTxnForDeleteNode() r=m_kato 2017-12-15 21:24:33 +09:00
DeleteRangeTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
DeleteRangeTransaction.h Bug 1425412 - part 12: Create factory methods for DeleteRangeTransaction, EditAggregateTransaction and PlaceholderTransaction for consistency with the other transaction classes r=m_kato 2017-12-18 18:08:43 +09:00
DeleteTextTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
DeleteTextTransaction.h Bug 1425412 - part 5: Create some factory methods of DeleteTextTransaction and remove EditorBase::CreateTxnForDeleteText() and EditorBase::CreateTxnForDeleteCharacter() r=m_kato 2017-12-15 20:43:26 +09:00
EditAction.h Bug 1430021 - part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase r=m_kato 2018-01-12 19:01:04 +09:00
EditActionListener.h
EditAggregateTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
EditAggregateTransaction.h Bug 1425412 - part 12: Create factory methods for DeleteRangeTransaction, EditAggregateTransaction and PlaceholderTransaction for consistency with the other transaction classes r=m_kato 2017-12-18 18:08:43 +09:00
EditTransactionBase.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
EditTransactionBase.h Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
EditorBase.cpp Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-02-08 12:13:08 +02:00
EditorBase.h Backed out changeset 86581d5ccbbb (bug 1436272) for failing /builds/worker/workspace/build/src/editor/libeditor/EditorBase.cpp a=backout on a CLOSED TREE 2018-02-08 04:54:47 +02:00
EditorCommands.cpp Bug 1319340 - part8: EditorCommands should use TextEditor instead of nsIEditor, nsIPlaintextEditor and nsIEditorMailSupport r=m_kato 2017-08-04 20:41:20 +09:00
EditorCommands.h Bug 748308 - Support insertParagraph and insertLineBreak per spec/Blink/WebKit; r=masayuki 2016-08-23 14:13:17 +03:00
EditorController.cpp Bug 748308 - Support insertParagraph and insertLineBreak per spec/Blink/WebKit; r=masayuki 2016-08-23 14:13:17 +03:00
EditorController.h Bug 1260651 part.33 Rename nsEditorController to mozilla::EditorController (and their files too) r=mccr8 2016-07-08 14:26:02 +09:00
EditorDOMPoint.h Bug 1436295 - HTMLEditRules::WillInsertBreak() should cancel resetting EditorDOMPoint when HTMLEditRules::ReturnInParagraph() splits DOM node around the point r=m_kato 2018-02-07 19:04:52 +09:00
EditorEventListener.cpp Bug 1432186 part 16. Remove nsIDOMNode's ownerDocument attribute. r=mccr8 2018-01-29 23:10:52 -05:00
EditorEventListener.h Bug 1344149 EditorEventListener shouldn't handle odd focus/blur events which may be created in chrome script r=smaug 2017-03-08 15:24:55 +09:00
EditorUtils.cpp Bug 1432186 part 15. Remove nsIDOMNode::HasChildNodes. r=mccr8 2018-01-29 23:10:51 -05:00
EditorUtils.h Bug 1432186 part 15. Remove nsIDOMNode::HasChildNodes. r=mccr8 2018-01-29 23:10:51 -05:00
EditorUtils.js Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 2018-02-06 09:36:57 -08:00
EditorUtils.manifest Bug 1259517 - Make dropping images in editors work in e10s. r=baku 2016-06-21 15:17:37 -07:00
HTMLAbsPositionEditor.cpp Bug 1435149 - Part 2. Use scope resolution operator for CSSEditUtils's caller. r=masayuki 2018-02-02 18:42:25 +09:00
HTMLAnonymousNodeEditor.cpp Bug 1435149 - Part 2. Use scope resolution operator for CSSEditUtils's caller. r=masayuki 2018-02-02 18:42:25 +09:00
HTMLEditRules.cpp Bug 1436295 - HTMLEditRules::WillInsertBreak() should cancel resetting EditorDOMPoint when HTMLEditRules::ReturnInParagraph() splits DOM node around the point r=m_kato 2018-02-07 19:04:52 +09:00
HTMLEditRules.h Bug 1432186 part 17. Remove nsIDOMNode's parentNode attribute. r=mccr8 2018-01-29 23:10:52 -05:00
HTMLEditUtils.cpp Bug 1432944 part 6. Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable. r=m_kato 2018-01-29 23:27:59 -05:00
HTMLEditUtils.h Bug 1432944 part 6. Remove the nsIDOMNode overloads of HTMLEditUtils::IsNamedAnchor and HTMLEditUtils::IsTable. r=m_kato 2018-01-29 23:27:59 -05:00
HTMLEditor.cpp Backed out changeset 86581d5ccbbb (bug 1436272) for failing /builds/worker/workspace/build/src/editor/libeditor/EditorBase.cpp a=backout on a CLOSED TREE 2018-02-08 04:54:47 +02:00
HTMLEditor.h Backed out changeset 86581d5ccbbb (bug 1436272) for failing /builds/worker/workspace/build/src/editor/libeditor/EditorBase.cpp a=backout on a CLOSED TREE 2018-02-08 04:54:47 +02:00
HTMLEditorDataTransfer.cpp Bug 1434789 - Part 1: Remove unnecessary nsSubstringTuple.h includes. r=froydnj 2018-01-31 16:47:43 -08:00
HTMLEditorEventListener.cpp Bug 1425547 - Remove unused methods from nsIHTMLInlineTableEditor. r=masayuki 2018-01-19 16:41:41 +09:00
HTMLEditorEventListener.h Bug 1387317 - part2: EditorEventListener should stop using interface methods as far as possible r=m_kato 2017-08-08 11:25:36 +09:00
HTMLEditorObjectResizer.cpp Bug 1435149 - Part 2. Use scope resolution operator for CSSEditUtils's caller. r=masayuki 2018-02-02 18:42:25 +09:00
HTMLEditorObjectResizerUtils.h Bug 1433345 - part 4: Make EditorBase derived from nsISelectionListener and notify its owning classes of selection change r=m_kato 2018-01-26 17:25:45 +09:00
HTMLInlineTableEditor.cpp Bug 1432977 part 3. Remove nsIDOMHTMLElement's offsetWidth/Height attributes. r=mccr8 2018-01-29 23:40:11 -05:00
HTMLStyleEditor.cpp Bug 1435149 - Part 2. Use scope resolution operator for CSSEditUtils's caller. r=masayuki 2018-02-02 18:42:25 +09:00
HTMLTableEditor.cpp Bug 1432186 part 17. Remove nsIDOMNode's parentNode attribute. r=mccr8 2018-01-29 23:10:52 -05:00
HTMLURIRefObject.cpp Bug 1432186 part 2. Clean up the string handling in HTMLURIRefObject::GetNextURI. r=mccr8 2018-01-29 23:10:50 -05:00
HTMLURIRefObject.h Bug 1432186 part 2. Clean up the string handling in HTMLURIRefObject::GetNextURI. r=mccr8 2018-01-29 23:10:50 -05:00
InsertNodeTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
InsertNodeTransaction.h Bug 1425412 - part 2: Create InsertNodeTransaction::Create() and remove EditorBase::CreateTxnForInsertNode() r=m_kato 2017-12-15 17:34:52 +09:00
InsertTextTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
InsertTextTransaction.h Bug 1425412 - part 1: Create InsertTextTransaction::Create() and remove EditorBase::CreateTxnForInsertText() r=m_kato 2017-12-15 17:26:52 +09:00
InternetCiter.cpp Bug 1424898 - patch 2 - De-virtualize nsIWordBreaker and rename to mozilla::intl::WordBreaker. r=m_kato 2017-12-13 22:17:38 -06:00
InternetCiter.h Bug 1260651 part.36 Rename nsInternetCiter to mozilla::InternetCiter (and their files too) r=mccr8 2016-07-07 18:00:19 +09:00
JoinNodeTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
JoinNodeTransaction.h Bug 1425412 - part 8: Create JoinNodeTransaction::MaybeCreate() and remove EditorBase::CreateTxnForJoinNode() r=m_kato 2017-12-15 21:53:08 +09:00
ManualNAC.h Bug 1386110 - Use a smart pointer to reliably de-register NAC regardless of how it goes away. r=masayuki 2017-08-03 20:26:11 -07:00
PlaceholderTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
PlaceholderTransaction.h Bug 1425412 - part 12: Create factory methods for DeleteRangeTransaction, EditAggregateTransaction and PlaceholderTransaction for consistency with the other transaction classes r=m_kato 2017-12-18 18:08:43 +09:00
SelectionState.cpp Bug 1430997 - Rename nsINode::IndexOf to nsINode::ComputeIndexOf, r=catalinb 2018-01-23 14:30:18 +01:00
SelectionState.h Bug 1425091 - Part 3. SelAdjCreateNode and SelAdjInsertNode should check whether valid point. r=masayuki 2017-12-15 10:49:53 -06:00
SplitNodeTransaction.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
SplitNodeTransaction.h Bug 1425412 - part 7: Create SplitNodeTransaction::Create() and remove EditorBase::CreateTxnForSplitNode() r=m_kato 2017-12-15 21:37:23 +09:00
StyleSheetTransactions.cpp Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki 2018-01-14 16:01:41 +01:00
StyleSheetTransactions.h Bug 1425412 - part 10: Create factory methods for AddStyleSheetTransaction and RemoveStyleSheetTransaction, and remove EditorBase::CreateTxnForAddStyleSheet() and EditorBase::CreateTxnForRemoveStyleSheet() r=m_kato 2017-12-18 17:29:32 +09:00
TextEditRules.cpp Bug 1434819 part 7. Remove the SHOW_* constants from nsIDOMNodeFilter. r=qdot 2018-02-01 14:26:12 -05:00
TextEditRules.h Bug 1430021 - part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase r=m_kato 2018-01-12 19:01:04 +09:00
TextEditRulesBidi.cpp Bug 1311240 Fix odd "{" and "}" of control statements in editor for conforming to our coding rules r=smaug 2016-10-24 11:27:45 +09:00
TextEditUtils.cpp Bug 1432944 part 11. Remove nsIDOMElement::GetAttribute. r=mccr8 2018-01-29 23:28:00 -05:00
TextEditUtils.h Bug 1408125 - part 4: Redesign HTMLEditor::InsertNodeAtPoint() with EditorRawDOMPoint r=m_kato 2017-11-28 22:28:07 +09:00
TextEditor.cpp Backed out changeset 86581d5ccbbb (bug 1436272) for failing /builds/worker/workspace/build/src/editor/libeditor/EditorBase.cpp a=backout on a CLOSED TREE 2018-02-08 04:54:47 +02:00
TextEditor.h Backed out changeset 86581d5ccbbb (bug 1436272) for failing /builds/worker/workspace/build/src/editor/libeditor/EditorBase.cpp a=backout on a CLOSED TREE 2018-02-08 04:54:47 +02:00
TextEditorDataTransfer.cpp Bug 1432186 part 16. Remove nsIDOMNode's ownerDocument attribute. r=mccr8 2018-01-29 23:10:52 -05:00
TextEditorTest.cpp Bug 1434318 part 7. Remove nsIDOMDocument::GetElementsBy* methods. r=mystor 2018-01-31 15:18:10 -05:00
TextEditorTest.h
TypeInState.cpp Bug 1433345 - part 4: Make EditorBase derived from nsISelectionListener and notify its owning classes of selection change r=m_kato 2018-01-26 17:25:45 +09:00
TypeInState.h Bug 1433345 - part 4: Make EditorBase derived from nsISelectionListener and notify its owning classes of selection change r=m_kato 2018-01-26 17:25:45 +09:00
WSRunObject.cpp Bug 1430997 - Rename nsINode::IndexOf to nsINode::ComputeIndexOf, r=catalinb 2018-01-23 14:30:18 +01:00
WSRunObject.h Bug 1425997 - Don't try to remove whitespaces in WSRunObject::ConvertToNBSP() when the text node is changed by mutation observer r=m_kato 2017-12-21 19:27:31 +09:00
moz.build Bug 1430021 - part 1: Move |RefPtr<TextEditRules> mRules| from TextEditor to EditorBase r=m_kato 2018-01-12 19:01:04 +09:00
nsIAbsorbingTransaction.h Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro. 2017-10-03 09:05:19 +11:00