gecko-dev/widget/cocoa
Masayuki Nakano 944a1927bb Bug 1342865 When Control key is pressed and InsertText() isn't called on macOS, its KeyboardEvent.key value should be characters which are inputted by the key without Control key state r=m_kato
Because of conforming to UI Events KeyboardEvent key Values, when some modifier keys cause not inputting character, the KeyboardEvent.key value should be computed with removing all modifier state except glyph modifier keys.

When Control key is pressed, Cocoa fires odd key events typically.  For example, characters isn't computed with same logic of UI Events KeyboardEvent key Values especially when Option key is pressed (see adding testcases for the detail).

Therefore, this patch makes TISInputSourceWrapper::InitKeyEvent() ignore both characters and charactersIgnoringModifiers at computing KeyboardEvent.key value when Control key is pressed and InsertText() isn't called.

On the other hand, this patch does NOT touch the path to compute KeyboardEvent.key when Command key is pressed.  It should be changed in different bug because Command key behavior isn't so simple.

MozReview-Commit-ID: dMHgUEOnQw

--HG--
extra : rebase_source : 7a67c98d2bf6ca38c7e6ae9dcbad01020d9cea31
2017-03-01 10:58:55 +09:00
..
crashtests Bug 1300017 - Skip crashtest 373122-1.html except on osx, for intermittent leaks; r=jmaher 2017-02-28 08:13:11 -07:00
cursors
resources/MainMenu.nib
ComplexTextInputPanel.h
ComplexTextInputPanel.mm Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
CustomCocoaEvents.h
GfxInfo.h Bug 1263249 - Bubble up unique failureId in GetFeatureStatus. r=mconley,milan 2016-04-13 17:12:47 -04:00
GfxInfo.mm Bug 1284341: Add utility functions to recognize OS X 10.12. r=mstange 2016-07-04 17:25:25 -04:00
NativeKeyBindings.h
NativeKeyBindings.mm Bug 1060419 - make log_print use Printf.h, r=froydnj 2016-12-15 20:16:31 -07:00
OSXNotificationCenter.h Bug 1233086, Part 3 - Use unified image loading for OS X alerts. r=mstange 2016-06-10 18:59:25 -07:00
OSXNotificationCenter.mm Bug 862395 - Part 1: Add requireInteraction property to web notifications. r=baku 2016-10-12 17:27:40 -07:00
RectTextureImage.h Bug 1281686 - Part 3: Using MacIOSurface for RectTextureImage. r=mstange 2016-06-29 11:24:44 +08:00
RectTextureImage.mm Bug 1332798 - Add null check after CreateIOSurface. r=mstange 2017-01-26 17:07:07 +08:00
SwipeTracker.h Bug 1256562 part.2 All event dispatchers under widget/cocoa should initialize WidgetEventTime::mTimeStamp with nsCocoaUtils::GetEventTimeStamp() r=mstange,smaug 2016-12-20 20:58:04 +09:00
SwipeTracker.mm Bug 1328832 - And the other one. 2017-01-06 15:30:31 +08:00
TextInputHandler.h Bug 1342865 When Control key is pressed and InsertText() isn't called on macOS, its KeyboardEvent.key value should be characters which are inputted by the key without Control key state r=m_kato 2017-03-01 10:58:55 +09:00
TextInputHandler.mm Bug 1342865 When Control key is pressed and InsertText() isn't called on macOS, its KeyboardEvent.key value should be characters which are inputted by the key without Control key state r=m_kato 2017-03-01 10:58:55 +09:00
VibrancyManager.h Bug 1192053 - Implement NS_THEME_MAC_SOURCE_LIST_SELECTION and NS_THEME_MAC_ACTIVE_SOURCE_LIST_SELECTION. r=mstange. 2016-10-14 22:45:29 +02:00
VibrancyManager.mm Bug 1310808 - Make use of the new 10.12 constant NSVisualEffectMaterialSelection. r=mstange. 2016-10-17 22:45:02 +02:00
ViewRegion.h Bug 1070710 - Add mozilla::ViewRegion which assembles a LayoutDeviceIntRegion as NSViews. r=spohl 2016-07-16 17:07:45 -04:00
ViewRegion.mm Bug 1070710 - Add mozilla::ViewRegion which assembles a LayoutDeviceIntRegion as NSViews. r=spohl 2016-07-16 17:07:45 -04:00
WidgetTraceEvent.mm
moz.build Bug 1338925: Enable warnings-as-errors in widget/cocoa/. r=mstange 2017-02-14 10:28:49 +13:00
mozView.h
nsAppShell.h
nsAppShell.mm Bug 1313903 - Fix -Wmismatched-parameter-types warning in widget/cocoa/nsAppShell.mm. r=spohl 2016-11-02 21:18:36 -07:00
nsBidiKeyboard.h
nsBidiKeyboard.mm
nsChangeObserver.h
nsChildView.h Bug 1338925: Declare viewDidChangeBackingProperties on NSView. r=mstange 2017-02-14 10:28:28 +13:00
nsChildView.mm Merge m-c to graphics 2017-02-02 13:38:51 -05:00
nsClipboard.h Bug 1261299 - Implement nsIClipboard methods in nsClipboard.mm with methods specific for osx. (EmptyClipboard, SetData) methods modified from nsBaseClipboard to also set the current selection cache. r=jimm 2016-08-11 16:43:32 -04:00
nsClipboard.mm Bug 1325906: Start using proper constant for PNG pasteboard type. r=mstange 2016-12-29 14:05:11 -05:00
nsCocoaDebugUtils.h
nsCocoaDebugUtils.mm
nsCocoaFeatures.h Bug 1331683 - Don't attempt to use any Core Text and Core Graphics variation-font APIs on pre-Sierra systems. r=jrmuizel,lsalzman 2017-02-09 21:37:24 +00:00
nsCocoaFeatures.mm Bug 1331683 - Don't attempt to use any Core Text and Core Graphics variation-font APIs on pre-Sierra systems. r=jrmuizel,lsalzman 2017-02-09 21:37:24 +00:00
nsCocoaUtils.h Bug 1256562 part.1 Implement nsCocoaUtils::GetEventTimeStamp() to convert from timeStamp of NSEvent to TimeStamp r=birtles,mstange 2016-12-26 12:23:37 +09:00
nsCocoaUtils.mm Bug 1323912 - Part 2. Pass opacity down to imgIContainer::Draw. r=mstange 2017-01-03 13:53:22 +08:00
nsCocoaWindow.h Bug 1325234 (part 10) - Final nsIWidget deCOMtamination clean-ups. r=mstange. 2016-12-21 15:58:09 +11:00
nsCocoaWindow.mm Bug 1338870 - Don't call [super respondsToSelector:] because it doesn't do what you might think. r=spohl 2017-02-17 13:21:21 -05:00
nsColorPicker.h Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug 2016-01-30 09:05:36 -08:00
nsColorPicker.mm Bug 1293593: Fix crash due to an Objective-C exception when calling getRed:green:blue:alpha on an NSColor instance with an incompatible NSColorSpace. r=mstange 2016-08-19 23:17:58 -04:00
nsCursorManager.h
nsCursorManager.mm
nsDeviceContextSpecX.h Bug 1309272, part 8 - Implement printing via Skia PDF for macOS (behind pref print.print_via_pdf_encoder=skia-pdf). r=lsalzman 2016-11-29 07:55:19 +00:00
nsDeviceContextSpecX.mm Bug 1338925: Move debug-only variables to ifdef DEBUG. r=mstange 2017-02-14 10:25:30 +13:00
nsDragService.h Bug 1309596,implementation of UpdateDragImage on mac, r=mstange 2016-12-23 18:09:44 -05:00
nsDragService.mm Bug 1329997: Ensure that we don't initiate drag sessions if the system has already sent a mouseUp event. This prevents getting stuck in drag sessions. r=mstange 2017-02-15 18:46:02 -05:00
nsFilePicker.h
nsFilePicker.mm Bug 1321321 - Ensure that we always save files with the given extension / Work-around NSSavePanel limitations when saving files with multiple extensions. r=mstange. 2017-02-25 00:34:46 +01:00
nsIdleServiceX.h
nsIdleServiceX.mm
nsLookAndFeel.h Bug 1280119 - Remove obsolete scrollbar constants in nsLookAndFeel.h. r=mstange. 2016-06-14 23:02:58 +02:00
nsLookAndFeel.mm Bug 531078 - Use MacOS system color for selected text background in inactive windows. r=mstange. 2016-11-15 20:38:22 +01:00
nsMacCursor.h
nsMacCursor.mm
nsMacDockSupport.h
nsMacDockSupport.mm Bug 1262110 - Null out nsIMacDockSupport.dockMenu on shutdown. r=smaug. 2016-04-05 16:46:43 +02:00
nsMacWebAppUtils.h
nsMacWebAppUtils.mm
nsMenuBarX.h Backout 2823fca4f547 (bug 429824) for causing bug 1334140 in e10s. r=backout 2017-01-26 16:14:19 -05:00
nsMenuBarX.mm Backout 2823fca4f547 (bug 429824) for causing bug 1334140 in e10s. r=backout 2017-01-26 16:14:19 -05:00
nsMenuBaseX.h
nsMenuGroupOwnerX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuGroupOwnerX.mm
nsMenuItemIconX.h Bug 1319908 - Load the menu icons for the bookmarks menu with the correct content type and principal on OSX; r=baku 2017-01-20 10:55:23 -05:00
nsMenuItemIconX.mm Bug 1319908 - Load the menu icons for the bookmarks menu with the correct content type and principal on OSX; r=baku 2017-01-20 10:55:23 -05:00
nsMenuItemX.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsMenuItemX.mm Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuUtilsX.h
nsMenuUtilsX.mm Bug 1248981 - Fix spelling error in nsMenuUtilsX.mm, a=tomcat 2016-02-17 15:57:01 +01:00
nsMenuX.h Bug 1265386: Fix white-space errors in widget/, r=nfroyd 2016-07-22 10:56:13 +02:00
nsMenuX.mm Bug 1292527: Make OSX application menu localizable at runtime. r=mstange 2016-11-29 21:22:13 -05:00
nsNativeThemeCocoa.h Bug 1192053 - Implement NS_THEME_MAC_SOURCE_LIST_SELECTION and NS_THEME_MAC_ACTIVE_SOURCE_LIST_SELECTION. r=mstange. 2016-10-14 22:45:29 +02:00
nsNativeThemeCocoa.mm Bug 1192053 - Implement NS_THEME_MAC_SOURCE_LIST_SELECTION and NS_THEME_MAC_ACTIVE_SOURCE_LIST_SELECTION. r=mstange. 2016-10-14 22:45:29 +02:00
nsNativeThemeColors.h Bug 1279017 - Remove code specific to 10.6-10.8 in widget/cocoa. r=mstange. 2016-06-10 23:30:25 +02:00
nsPIWidgetCocoa.idl Bug 1294553 - Don't pretend that nsCocoaWindow is an interface in nsPIWidgetCocoa.idl, r=mstange 2016-08-11 17:56:10 -04:00
nsPrintDialogX.h Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj. 2016-08-08 10:54:47 +10:00
nsPrintDialogX.mm Bug 1331236 - Make nsPrintingPromptServiceX.mm cpp file instead of Objective-C++. r=mstange 2017-01-15 16:47:36 +09:00
nsPrintOptionsX.h Bug 1303051 - Printing Issue: Page Setup not being respected since upgrade to 48.01 on Mac; r=mconley 2016-11-09 17:37:40 -08:00
nsPrintOptionsX.mm Bug 675709 - Export the constants for paper orientation. r=haik 2017-02-06 11:02:50 +09:00
nsPrintSettingsX.h Bug 675709 - Export the constants for paper orientation. r=haik 2017-02-06 11:02:50 +09:00
nsPrintSettingsX.mm Bug 675709 - Export the constants for paper orientation. r=haik 2017-02-06 11:02:50 +09:00
nsSandboxViolationSink.h
nsSandboxViolationSink.mm Bug 1302163 - Change code to use SprintfLiteral instead of snprintf. r=ehsan 2016-10-04 17:57:51 +02:00
nsScreenCocoa.h Bug 1240085 - Revert to CSS-pixel units for screenX, screenY, moveTo() APIs, and adjust the origin for secondary displays with differing resolution to avoid overlapping coordinate spaces. r=emk 2016-02-05 16:29:33 +00:00
nsScreenCocoa.mm Bug 1281686 - Part 1: Fix OSX Compile failure due to unified build. r=mstange 2016-06-29 11:24:43 +08:00
nsScreenManagerCocoa.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsScreenManagerCocoa.mm Bug 1239007 - Replace nsIntRect by strongly-typed rects in a couple of nsCocoaUtils functions. r=mstange 2016-01-13 07:32:55 +00:00
nsSound.h
nsSound.mm
nsStandaloneNativeMenu.h
nsStandaloneNativeMenu.mm
nsSystemStatusBarCocoa.h Bug 1265953, part 1 - Convert most of the cocoa widget code from nsAutoPtr to UniquePtr. r=mstange 2016-04-19 11:28:12 +01:00
nsSystemStatusBarCocoa.mm
nsToolkit.h Bug 1282251 - Remove nsCocoaFeatures::OnLionOrLater(), OnMountainLionOrLater() and OnMavericksOrLater(). r=spohl. 2016-07-11 21:19:36 +02:00
nsToolkit.mm
nsWidgetFactory.mm Initialize nsAppShell in the GPU process. (bug 1294350 part 5, r=nfroyd) 2016-08-22 22:57:36 -07:00
nsWindowMap.h
nsWindowMap.mm