gecko-dev/widget/cocoa
Markus Stange 4ab5fa9be0 Bug 1699582 - Detach nsMenu(Item)X from their parent and group owner at the right time, since they can now outlive them. r=harry
This is somewhat annoying.

I think the alternative would be:

 - Use WeakPtr<...> for m(Menu)Parent and mMenuGroupOwner, so that these pointers
   "null themselves out" when the pointed-to object goes away, and
 - removing the requirement in the menu group owner to have all listeners
   unregistered when the menu group owner is destroyed.

I'm planning to look at this more in the future, but for now, I think this patch
is the right way to go.

Differential Revision: https://phabricator.services.mozilla.com/D109022
2021-03-22 19:55:45 +00:00
..
crashtests
cursors
docs Bug 1684672 - Update mentions of macOS SDK v10.11 to v10.12. r=glandium DONTBUILD 2021-01-21 12:47:01 +00:00
resources/MainMenu.nib
CFTypeRefPtr.h
CustomCocoaEvents.h Bug 1683723 - Replace deprecated Cocoa enum constants with their modern replacements. r=spohl 2021-01-05 21:17:11 +00:00
DesktopBackgroundImage.h
DesktopBackgroundImage.mm
GfxInfo.h Bug 1680512 - Prefer EGL for glxtest detection and fallback to GLX if unavailable. r=rmader 2021-01-25 19:41:04 +00:00
GfxInfo.mm Bug 1686946 - Ship Software WebRender to OSX early beta/nightly users without (full) WebRender. r=jrmuizel 2021-02-11 17:53:40 +00:00
MOZIconHelper.h Bug 1691861 - Remove IconLoaderHelperCocoa. r=mconley 2021-02-12 00:32:06 +00:00
MOZIconHelper.mm Bug 1691861 - Move image region handling out of IconLoader. r=mconley 2021-02-12 00:32:06 +00:00
MacThemeGeometryType.h Bug 1697338 - Remove unused -moz-default-appearance values -moz-mac-vibrancy-light/dark, and the system colors of the same name. r=emilio 2021-03-17 16:50:08 +00:00
MediaHardwareKeysEventSourceMac.h
MediaHardwareKeysEventSourceMac.mm Bug 1692661 - Replace deprecated enum constant NSSystemDefined with NSEventTypeSystemDefined in MediaHardwareKeysEventSourceMac.mm r=mstange 2021-02-13 18:11:57 +00:00
MediaHardwareKeysEventSourceMacMediaCenter.h Bug 1671626 - part2 : set metadata on nowPlayingInfo. r=spohl 2020-12-21 18:09:16 +00:00
MediaHardwareKeysEventSourceMacMediaCenter.mm Bug 1671626 - part1 : remove `MediaPlayerWrapper`. r=spohl 2020-12-21 18:10:30 +00:00
MediaKeysEventSourceFactory.cpp
NativeKeyBindings.h Bug 1634281 - Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin 2021-03-10 10:47:47 +00:00
NativeKeyBindings.mm Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika 2021-02-26 09:11:46 +00:00
NativeMenuSupport.h Bug 1691213 - DeCOMtaminate nsINativeMenuService and rename it to mozilla::widget::NativeMenuSupport. r=spohl 2021-02-11 19:43:58 +00:00
NativeMenuSupport.mm Bug 1694853 - Stop giving the nsMenuBarX a reference to the widget. r=harry 2021-03-04 01:24:58 +00:00
OSXNotificationCenter.h Bug 1697343 - Remove code that was needed to support building with pre-10.12 SDKs. r=mac-reviewers,bradwerth 2021-03-11 02:46:23 +00:00
OSXNotificationCenter.mm Bug 1697343 - Remove code that was needed to support building with pre-10.12 SDKs. r=mac-reviewers,bradwerth 2021-03-11 02:46:23 +00:00
ScreenHelperCocoa.h
ScreenHelperCocoa.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
SwipeTracker.h
SwipeTracker.mm Bug 1694002 - Tweak swipe threshold values to require more "deliberate" swiping. r=spohl 2021-02-21 00:41:32 +00:00
TextInputHandler.h Bug 1697343 - Remove code that was needed to support building with pre-10.12 SDKs. r=mac-reviewers,bradwerth 2021-03-11 02:46:23 +00:00
TextInputHandler.mm Bug 1692379 - Reverse the range inclusion check, to avoid Objective C exceptions from -[NSString substringWithRange:]. r=masayuki 2021-03-05 21:17:16 +00:00
VibrancyManager.h Bug 1697338 - Rename VibrancyType::LIGHT/DARK to TITLEBAR_LIGHT/DARK. r=mac-reviewers,bradwerth 2021-03-17 16:50:09 +00:00
VibrancyManager.mm Bug 1697338 - Make context menus and tooltips adapt to the system appearance, if widget.macos.respect-system-appearance is set to true. r=mac-reviewers,bradwerth 2021-03-17 16:50:10 +00:00
ViewRegion.h
ViewRegion.mm
WidgetTraceEvent.mm Bug 1683723 - Replace deprecated Cocoa enum constants with their modern replacements. r=spohl 2021-01-05 21:17:11 +00:00
components.conf Bug 1686616 - register all Services.py services with components.conf. r=kmag,necko-reviewers,valentin 2021-02-18 13:26:28 +00:00
moz.build Bug 1691861 - Remove IconLoaderHelperCocoa. r=mconley 2021-02-12 00:32:06 +00:00
mozView.h
nsAppShell.h Bug 1627443 - Use a CFRunLoopObserver to notify the profiler of native event loop idleness. r=gerald 2021-01-28 03:06:01 +00:00
nsAppShell.mm Bug 1697343 - Remove code that was needed to support building with pre-10.12 SDKs. r=mac-reviewers,bradwerth 2021-03-11 02:46:23 +00:00
nsBidiKeyboard.h
nsBidiKeyboard.mm
nsChangeObserver.h Bug 1698662 - Improve comments on nsChangeObserver. r=harry 2021-03-18 02:30:37 +00:00
nsChildView.h Bug 1696802. Add test. r=botond,mstange 2021-03-12 02:10:43 +00:00
nsChildView.mm Bug 1698668 - Check the consistency of the native menu structure at the beginning of ActivateNativeMenuItemAt, both for the native menu bar and for standalone native menus. r=harry 2021-03-18 15:37:38 +00:00
nsClipboard.h Bug 1689992: part 1) When copying an image, add the image data before other data to the transferable and macOS's pasteboard. r=masayuki 2021-02-19 09:04:35 +00:00
nsClipboard.mm Bug 1689992: part 1) When copying an image, add the image data before other data to the transferable and macOS's pasteboard. r=masayuki 2021-02-19 09:04:35 +00:00
nsCocoaFeatures.h
nsCocoaFeatures.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
nsCocoaUtils.h Bug 1697964 - Remove nsCocoaUtils::GetScrollingDeltas and HasPreciseScrollingDeltas. r=mac-reviewers,tnikkel 2021-03-12 01:46:24 +00:00
nsCocoaUtils.mm Bug 1697964 - Remove nsCocoaUtils::GetScrollingDeltas and HasPreciseScrollingDeltas. r=mac-reviewers,tnikkel 2021-03-12 01:46:24 +00:00
nsCocoaWindow.h Bug 1699506 - Part 1 - Add a NSTitlebarAccessoryViewController to ToolbarWindow to track when the titlebar is shown in fullscreen. r=mac-reviewers,mstange 2021-03-18 20:20:39 +00:00
nsCocoaWindow.mm Bug 1700178 - Trigger a main thread repaint immediately when the revealAmount changed, to reduce stuttering during the animation. r=mac-reviewers,bradwerth 2021-03-22 19:32:31 +00:00
nsColorPicker.h
nsColorPicker.mm
nsCursorManager.h
nsCursorManager.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
nsDeviceContextSpecX.h
nsDeviceContextSpecX.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
nsDragService.h
nsDragService.mm Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik 2021-02-16 22:55:21 +00:00
nsFilePicker.h
nsFilePicker.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
nsLookAndFeel.h Bug 1697338 - Update font-smoothing background colors, and make them respect dark mode. r=emilio 2021-03-17 16:50:10 +00:00
nsLookAndFeel.mm Bug 1697338 - Update font-smoothing background colors, and make them respect dark mode. r=emilio 2021-03-17 16:50:10 +00:00
nsMacCursor.h
nsMacCursor.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
nsMacDockSupport.h
nsMacDockSupport.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
nsMacFinderProgress.h
nsMacFinderProgress.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
nsMacSharingService.h
nsMacSharingService.mm Bug 1698704 - Return early if the created NSURL is nil. r=mac-reviewers,bradwerth 2021-03-16 17:56:35 +00:00
nsMacWebAppUtils.h
nsMacWebAppUtils.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
nsMenuBarX.h Bug 1699582 - Make nsMenuX reference-counted. r=harry 2021-03-22 19:55:44 +00:00
nsMenuBarX.mm Bug 1699582 - Detach nsMenu(Item)X from their parent and group owner at the right time, since they can now outlive them. r=harry 2021-03-22 19:55:45 +00:00
nsMenuBaseX.h Bug 1698662 - Remove nsMenuObjectX::GetNativeData and replace it with NativeNSMenu on the various subclasses. r=harry 2021-03-18 02:30:39 +00:00
nsMenuGroupOwnerX.h Bug 1698662 - Rename arguments in nsMenuGroupOwnerX. r=harry 2021-03-18 02:30:38 +00:00
nsMenuGroupOwnerX.mm Bug 1698662 - Rename arguments in nsMenuGroupOwnerX. r=harry 2021-03-18 02:30:38 +00:00
nsMenuItemIconX.h Bug 1698662 - Remove misleading comment. r=harry 2021-03-18 02:30:37 +00:00
nsMenuItemIconX.mm Bug 1698662 - Move part of SetupIcon into a new method StartIconLoad. r=harry 2021-03-18 02:30:37 +00:00
nsMenuItemX.h Bug 1699582 - Detach nsMenu(Item)X from their parent and group owner at the right time, since they can now outlive them. r=harry 2021-03-22 19:55:45 +00:00
nsMenuItemX.mm Bug 1699582 - Detach nsMenu(Item)X from their parent and group owner at the right time, since they can now outlive them. r=harry 2021-03-22 19:55:45 +00:00
nsMenuUtilsX.h Bug 1699582 - Change nsMenuUtilsX::CalculateNativeInsertionPoint's aChild parameter to be an nsMenuX, because it is only called for that type. r=harry 2021-03-22 19:55:43 +00:00
nsMenuUtilsX.mm Bug 1699582 - Make GetItemAt and GetVisibleItemAt return MenuChild. r=harry 2021-03-22 19:55:45 +00:00
nsMenuX.h Bug 1699582 - Detach nsMenu(Item)X from their parent and group owner at the right time, since they can now outlive them. r=harry 2021-03-22 19:55:45 +00:00
nsMenuX.mm Bug 1699582 - Detach nsMenu(Item)X from their parent and group owner at the right time, since they can now outlive them. r=harry 2021-03-22 19:55:45 +00:00
nsNativeBasicThemeCocoa.cpp Bug 1697467 - Push the high contrast code from nsNativeBasicThemeWin to nsNativeBasicTheme. r=mstange 2021-03-12 14:44:13 +00:00
nsNativeBasicThemeCocoa.h Bug 1519636 - Reformat recent changes to the Google coding style r=andi 2021-03-15 08:45:29 +00:00
nsNativeThemeCocoa.h Bug 1699937 - Don't draw focus outlines for box-shadow in the non-native theme. r=mstange 2021-03-20 23:08:11 +00:00
nsNativeThemeCocoa.mm Bug 1699937 - Don't draw focus outlines for box-shadow in the non-native theme. r=mstange 2021-03-20 23:08:11 +00:00
nsNativeThemeColors.h
nsPIWidgetCocoa.idl
nsPrintDialogX.h
nsPrintDialogX.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
nsPrintSettingsServiceX.h Bug 1681344 - Eliminate reading/writing of a PMPageFormat to prefs on macOS. r=jwatt 2021-01-11 17:50:02 +00:00
nsPrintSettingsServiceX.mm Bug 1692845 - Restore read from global print settings for a few settings, including print_bgcolor and print_bgimages. r=bobowen 2021-02-23 10:52:53 +00:00
nsPrintSettingsX.h Bug 1681344 - Eliminate reading/writing of a PMPageFormat to prefs on macOS. r=jwatt 2021-01-11 17:50:02 +00:00
nsPrintSettingsX.mm Bug 1692316 - Part 1: Update Platform Duplex Print Terminology r=dholbert 2021-02-17 23:57:26 +00:00
nsSandboxViolationSink.h
nsSandboxViolationSink.mm Bug 1691168 - Remove nsCocoaDebugUtils. r=spohl 2021-02-09 21:17:18 +00:00
nsSound.h
nsSound.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
nsStandaloneNativeMenu.h Bug 1699582 - Make nsMenuX reference-counted. r=harry 2021-03-22 19:55:44 +00:00
nsStandaloneNativeMenu.mm Bug 1699582 - Detach nsMenu(Item)X from their parent and group owner at the right time, since they can now outlive them. r=harry 2021-03-22 19:55:45 +00:00
nsSystemStatusBarCocoa.h
nsSystemStatusBarCocoa.mm Bug 1694853 - Replace getter and setter calls with property gets and sets. r=harry 2021-03-04 01:24:55 +00:00
nsToolkit.h
nsToolkit.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00
nsTouchBar.h
nsTouchBar.mm Bug 1685221 - Remove C++ static initializers for touch bar identifiers. r=spohl 2021-01-07 21:47:53 +00:00
nsTouchBarInput.h Bug 1685221 - Remove C++ static initializers for touch bar identifiers. r=spohl 2021-01-07 21:47:53 +00:00
nsTouchBarInput.mm Bug 1685221 - Remove C++ static initializers for touch bar identifiers. r=spohl 2021-01-07 21:47:53 +00:00
nsTouchBarInputIcon.h Bug 1691861 - Move image region handling out of IconLoader. r=mconley 2021-02-12 00:32:06 +00:00
nsTouchBarInputIcon.mm Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik 2021-02-16 22:55:20 +00:00
nsTouchBarNativeAPIDefines.h Bug 1697343 - Remove code that was needed to support building with pre-10.12 SDKs. r=mac-reviewers,bradwerth 2021-03-11 02:46:23 +00:00
nsTouchBarUpdater.h
nsTouchBarUpdater.mm
nsUserIdleServiceX.h
nsUserIdleServiceX.mm Bug 1692391 - Remove the word ABORT from the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_RETURN macros, because these macros don't abort. r=haik,necko-reviewers 2021-02-16 22:55:20 +00:00
nsWidgetFactory.mm Bug 1686616 - register all Services.py services with components.conf. r=kmag,necko-reviewers,valentin 2021-02-18 13:26:28 +00:00
nsWindowMap.h
nsWindowMap.mm Bug 1692391 - Rename NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK macros, replacing ABORT with IGNORE. These macros just log the exception and move on, without aborting. r=haik 2021-02-16 22:55:21 +00:00