mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
gecko-dev/layout/base
История
Robert O'Callahan 39217b370a Bug 1048752. Part 22: Factor out SelectionLanguageChange call to run early in nsCaret::GetPaintGeometry. r=tn 
This code is somewhat tricky. nsCaret::ComputeCaretRects was checking to see
if we have a bidi keyboard, and if so, what direction it's set to.
If the direction changed from the last direction seen for *this caret*,
we fired a SelectionLanguageChange notification on the caret's current
Selection. This looked bogus because the caret can be switched between
selections so it would seem some selections won't get a notification when
they should, but that's how it was. Also, when the SelectionLanguageChange
notification fired we then didn't draw the caret in that iteration, which
seems even more bogus.

This patch fixes all that by moving the logic to fire SelectionLanguageChange
out to GetPaintGeometry and firing the notification every single time without
trying to detect whether the state has changed or not. I carefully examined
the implementation of SelectionLanguageChange and I'm pretty sure it's
idempotent so this should be correct. That doesn't look like an
expensive function, and runs at most once per window paint, so I'm not
worried about perf. Because we now fire SelectionLanguageChange before
reading selection or frame state, it should be fine to carry on after
calling SelectionLanguageChange and drawing the caret based on whatever
changes SelectionLanguageChange has performed.

This also lets us remove mKeyboardRTL, which as noted above seems inherently
bogus.

--HG--
extra : rebase_source : 3ddfd10f6f30033e090e72b4bb43f2695218752e
 		2014-08-06 17:19:28 +12:00
..
crashtests Bug 1043163. Avoid negative widths and heights due to overflow. r=mats 2014-08-06 17:19:23 +12:00
tests Backed out 4 changesets (bug 1032878) for probably introducing a leak, creating a CLOSED TREE 2014-08-11 14:27:57 -07:00
ActiveLayerTracker.cpp Bug 1025709 part 7 - Move HasAnimationOfProperty from ElementAnimations/ElementTransitions to base class; r=heycam 2014-06-20 12:39:25 +09:00
ActiveLayerTracker.h Bug 1009478 - Make LayerActivity properties survive across reframes of an element. r=roc 2014-05-13 19:30:11 +02:00
CaretAssociationHint.h Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn 2014-08-06 17:19:27 +12:00
DisplayItemClip.cpp Bug 1041894 - Make FindOpaqueBackgroundColorFor check the DisplayItemClip of items before selecting them. r=roc 2014-07-23 18:12:08 +12:00
DisplayItemClip.h Bug 1041894 - Make FindOpaqueBackgroundColorFor check the DisplayItemClip of items before selecting them. r=roc 2014-07-23 18:12:08 +12:00
DisplayListClipState.cpp Bug 1042423 - Part 2: Add DisplayItemClip constructor for rect + rounded rect. r=roc 2014-07-23 17:21:06 +12:00
DisplayListClipState.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
FrameLayerBuilder.cpp Bug 1019693 - Always use tiled thebes layers when we're a descendant of a layer with a critical display port so that the low-resolution drawing area is handled correctly. r=tn 2014-08-08 09:12:01 +12:00
FrameLayerBuilder.h Bug 1048752. Part 10: Remove FrameLayerBuilder.h from nsDisplayList.h. r=tn 2014-08-06 17:19:25 +12:00
FramePropertyTable.cpp Bug 1046281 - Use the simpler version of nsTHashtable memory reporters. r=njn 2014-08-05 13:27:41 -07:00
FramePropertyTable.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
GeometryUtils.cpp Bug 1009036 - Watch out for frame destruction caused by EnsureFrameForTextNode. r=roc 2014-05-12 20:25:22 +00:00
GeometryUtils.h Bug 1026535 - Fix mismatched class/struct tags. r=ehsan 2014-06-18 17:57:51 -07:00
LayerState.h Bug 1048752. Part 10: Remove FrameLayerBuilder.h from nsDisplayList.h. r=tn 2014-08-06 17:19:25 +12:00
MaskLayerImageCache.cpp Bug 1037691 - Fix instances where refcounted classes expose a public destructor. r=ehsan,bent,mayhemer,jrmuizel 2014-07-15 11:37:45 -04:00
MaskLayerImageCache.h Bug 1037691 - Fix instances where refcounted classes expose a public destructor. r=ehsan,bent,mayhemer,jrmuizel 2014-07-15 11:37:45 -04:00
PaintTracker.cpp
…
PaintTracker.h
…
PositionedEventTargeting.cpp Bug 1046101 part.18 Rename NS_TOUCH_EVENT to eTouchEventClass r=smaug 2014-08-04 14:28:53 +09:00
PositionedEventTargeting.h
…
RestyleManager.cpp Bug 625289 patch 7 - Expose TryStartingTransition. r=heycam 2014-08-13 15:39:01 -07:00
RestyleManager.h Bug 625289 patch 11 - Call RestyleManager::TryStartingTransition during frame construction. r=heycam 2014-08-13 15:39:02 -07:00
RestyleTracker.cpp Bug 996796 patch 6 - Adjust checks of restyle types to accomodate new types weaker than eRestyle_Self. r=heycam 2014-08-02 19:37:43 -07:00
RestyleTracker.h Bug 996796 patch 18 - Fix RestyleTracker to handle restyle hints exactly rather than pessimistically when restyling continuations with varying styles (e.g., spans inside ::first-line or ::first-letter). r=heycam 2014-08-03 13:11:55 -07:00
ScrollbarStyles.h
…
SelectionCarets.cpp Bug 1048752. Part 17: Rename Get/SetCaretDOMSelection to Get/SetSelection. r=tn 2014-08-06 17:19:27 +12:00
SelectionCarets.h Bug 1023041 - Part 1: Rename SetMouseDownState to SetDragState. r=roc 2014-08-04 00:26:00 -04:00
StackArena.cpp
…
StackArena.h
…
TouchCaret.cpp Bug 1048752. Part 17: Rename Get/SetCaretDOMSelection to Get/SetSelection. r=tn 2014-08-06 17:19:27 +12:00
TouchCaret.h Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn 2014-08-06 17:19:27 +12:00
UnitTransforms.h Backed out 3 changesets (bug 923512) for mochitest-2 bustage on a CLOSED TREE 2014-08-06 16:36:35 -07:00
Units.h Backed out 3 changesets (bug 923512) for mochitest-2 bustage on a CLOSED TREE 2014-08-06 16:36:35 -07:00
WordMovementType.h Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn 2014-08-06 17:19:27 +12:00
moz.build Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn 2014-08-06 17:19:27 +12:00
nsArenaMemoryStats.h Bug 590790, part 1 - Add getTotalSize() methods to nsWindowSizes and nsArenaMemoryStats. r=njn 2014-05-08 10:52:13 +01:00
nsAutoLayoutPhase.cpp
…
nsAutoLayoutPhase.h
…
nsBidi.cpp Bug 1031395 - Remove a double assignment to "limit" to fix a minor warning found by scan-build, the LLVM/Clang static analyzer. r=ehsan 2014-06-27 10:02:00 +02:00
nsBidi.h Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc 2014-01-04 10:02:17 -05:00
nsBidiPresUtils.cpp Bug 1049997 - Separate statements declaring multiple pointers into separate statements. r=froydnj 2014-08-08 07:04:45 -07:00
nsBidiPresUtils.h Bug 491863 - Remove IBMBIDI; r=roc 2014-04-23 21:15:29 -04:00
nsCSSColorUtils.cpp Remove some unneeded #undef's, no bug 2013-12-04 00:00:12 -05:00
nsCSSColorUtils.h Bug 1024930 - Change text highlighting color. r=roc 2014-07-30 00:11:00 -04:00
nsCSSFrameConstructor.cpp Bug 1054563: Remove unnecessary nsresult return value from BuildScrollFrame, and de-indent it. r=tn 2014-08-15 20:22:09 -07:00
nsCSSFrameConstructor.h Bug 1054563: Remove unnecessary nsresult return value from BuildScrollFrame, and de-indent it. r=tn 2014-08-15 20:22:09 -07:00
nsCSSRendering.cpp Bug 1051527 - BackgroundClipState::mHasRounded corners is used uninitialised. r=matt.woodrow. 2014-08-13 11:26:33 +02:00
nsCSSRendering.h Bug 1042423 - Part 5: Remove PaintBackgroundColor. r=roc 2014-07-23 17:23:38 +12:00
nsCSSRenderingBorders.cpp Bug 933019, part 7 - Remove code for handling Thebes backed gfxContext from various files under layout/. r=Bas 2014-07-10 10:58:07 +01:00
nsCSSRenderingBorders.h Bug 933019, part 7 - Remove code for handling Thebes backed gfxContext from various files under layout/. r=Bas 2014-07-10 10:58:07 +01:00
nsCaret.cpp Bug 1048752. Part 22: Factor out SelectionLanguageChange call to run early in nsCaret::GetPaintGeometry. r=tn 2014-08-06 17:19:28 +12:00
nsCaret.h Bug 1048752. Part 22: Factor out SelectionLanguageChange call to run early in nsCaret::GetPaintGeometry. r=tn 2014-08-06 17:19:28 +12:00
nsChangeHint.h Bug 996796 patch 7 - Add new restyle types that replace only the data from CSS transitions or animations. r=heycam 2014-08-02 19:37:43 -07:00
nsCompatibility.h
…
nsCounterManager.cpp Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc. 2014-08-06 06:31:21 -07:00
nsCounterManager.h Bug 966166 - Part 3: Link to other parts. r=dbaron 2014-06-11 21:12:00 -04:00
nsDisplayItemTypes.h
…
nsDisplayItemTypesList.h Bug 975931. Part 1: Add nsDOMWindowUtils API to add an extra scroll offset in the AsyncPanZoomController when compositing. r=kats 2014-02-14 21:59:23 +13:00
nsDisplayList.cpp Bug 1048752. Part 19: Create nsCaret::GetPaintGeometry to call during painting. r=tn 2014-08-06 17:19:28 +12:00
nsDisplayList.h Bug 1048752. Part 19: Create nsCaret::GetPaintGeometry to call during painting. r=tn 2014-08-06 17:19:28 +12:00
nsDisplayListInvalidation.cpp Bug 1003425. When opacity is delegated to an nsDisplayBoxShadowOuter via nsDisplayItem::ApplyOpacity, store the opacity in our geometry so we can invalidate if it changes. r=mattwoodrow 2014-07-22 01:59:10 +12:00
nsDisplayListInvalidation.h Bug 1003425. When opacity is delegated to an nsDisplayBoxShadowOuter via nsDisplayItem::ApplyOpacity, store the opacity in our geometry so we can invalidate if it changes. r=mattwoodrow 2014-07-22 01:59:10 +12:00
nsDocumentViewer.cpp Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
nsFrameManager.cpp Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc. 2014-08-06 06:31:21 -07:00
nsFrameManager.h Bug 1024084: Clean up forward declarations and #includes in nsFrameManager.h and nsFrameManagerBase.h. r=jwatt 2014-06-12 10:09:31 -07:00
nsFrameManagerBase.h Bug 1016680, part 4 - Explicitly initialize members in nsFrameManagerBase's ctor rather than using memset. r=bz 2014-06-12 20:25:33 +01:00
nsFrameTraversal.cpp Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsFrameTraversal.h Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
nsGenConList.cpp
…
nsGenConList.h Bug 1016680, part 3 - DeCOMify nsGenConNode::mText. r=dholbert 2014-06-11 23:11:15 +01:00
nsIDocumentViewerPrint.h
…
nsIFrameTraversal.h
…
nsILayoutDebugger.h
…
nsILayoutHistoryState.h Fix the places where we forward declare already_AddRefed as a struct, no bug, r=I'm-sick-and-tired-of-MSVC-stupidity 2014-06-17 10:57:23 -04:00
nsIPercentHeightObserver.h
…
nsIPresShell.h Bug 1048752. Part 2: Remove InvalidateOutsideCaret and MaybeInvalidateCaretPosition. r=tn 2014-08-06 17:19:23 +12:00
nsIReflowCallback.h
…
nsIStyleSheetService.idl Bug 1024707 - Add API to register style sheets but without loading them. r=bz 2014-07-09 11:43:33 +02:00
nsLayoutDebugger.cpp Bug 1045864 - Disable layerized background-attachment:fixed when we're using a software compositor. r=roc 2014-08-05 15:25:00 +12:00
nsLayoutHistoryState.cpp Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
nsLayoutUtils.cpp Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn 2014-08-06 17:19:27 +12:00
nsLayoutUtils.h Bug 1030993 - Basic reflow implementation for ruby frame classes. r=dbaron 2014-08-15 10:34:20 -07:00
nsPresArena.cpp Bug 1046281 - Use the simpler version of nsTHashtable memory reporters. r=njn 2014-08-05 13:27:41 -07:00
nsPresArena.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
nsPresContext.cpp Bug 1047509 - Part 11: Remove nsCxPusher in nsPresContext::MediaFeatureValuesChanged. r=bholley 2014-08-07 19:44:03 +01:00
nsPresContext.h Bug 1048246 - Fix more bad implicit constructors in layout; r=roc 2014-08-07 19:48:38 -04:00
nsPresShell.cpp Bug 1048752. Part 17: Rename Get/SetCaretDOMSelection to Get/SetSelection. r=tn 2014-08-06 17:19:27 +12:00
nsPresShell.h Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn 2014-08-06 17:19:27 +12:00
nsPresState.h Bug 611556 - Add persistent zoom history sessions. r=roc, r=snorp 2014-04-07 13:43:58 +02:00
nsQuoteList.cpp
…
nsQuoteList.h
…
nsRefreshDriver.cpp Bug 1053078 - Use a timeout instead of tick count for preventing refresh driver hangs since ASAP mode accumulates tick counts too quickly. r=roc 2014-08-15 14:24:50 +12:00
nsRefreshDriver.h Bug 1053078 - Use a timeout instead of tick count for preventing refresh driver hangs since ASAP mode accumulates tick counts too quickly. r=roc 2014-08-15 14:24:50 +12:00
nsStyleChangeList.cpp
…
nsStyleChangeList.h
…
nsStyleSheetService.cpp Bug 1024707 - Add API to register style sheets but without loading them. r=bz 2014-07-09 11:43:33 +02:00
nsStyleSheetService.h Bug 1024707 - Add API to register style sheets but without loading them. r=bz 2014-07-09 11:43:33 +02:00