gecko-dev/widget
Masayuki Nakano f0bff83240 Bug 1318265 NativeKey shouldn't handle messages when mWidget has already been destroyed r=m_kato
When mWidget was already destroyed, anybody shouldn't dispatch WidgetEvent on it. Therefore, NativeKey::InitKeyEvent() has MOZ_CRASH() for detecting such dangerous bug and some users hit it.

Each message handler of NativeKey should check if mWidget has already gone.

Ideally, nsWindow shouldn't create NativeKey and try to handle the message with it. However, using NativeKey's message handlers can put some information to the log. Therefore, this patch doesn't touch nsWindow.

MozReview-Commit-ID: 4k5VfaKHPgG

--HG--
extra : rebase_source : 4269847fbdf5daa66244ce924ddc54feb5c6cd01
2016-11-17 19:02:30 +09:00
..
android Bug 1314466 - part 7, Update JNI Wrappers r=nchen 2016-11-14 16:45:23 -08:00
cocoa Backed out changeset 50f830bdb2c8 (bug 1315121) for failing reftest-sanity/page-width-4.1in.html on OS X 10.10 debug. r=backout on a CLOSED TREE 2016-11-17 21:53:26 +01:00
crashtests
gonk Bug 1310845 - Remove support for mozapp iframes; r=fabrice,jryans,baku,mcmanus 2016-11-16 09:13:38 -05:00
gtk bug 1315668 construct menuitem style contexts from paths r=stransky+263117 2016-11-15 17:11:14 +13:00
gtkxtbin Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 2016-07-14 10:16:42 -06:00
reftests Bug 1288350 - Temporary reftest list for Stylo vs Gecko test r=heycam,manishearth 2016-09-05 11:45:39 +08:00
tests Bug 1310297 - Remove test annotations using b2g, mulet or gonk: widget. r=RyanVM 2016-11-05 11:29:22 +01:00
uikit Bug 1258751: Delete the CoreGraphics backend. r=mstange 2016-10-18 23:22:44 -04:00
windows Bug 1318265 NativeKey shouldn't handle messages when mWidget has already been destroyed r=m_kato 2016-11-17 19:02:30 +09:00
x11 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 2016-07-14 10:16:42 -06:00
xremoteclient Bug 1293384 - Part 1: Rename snprintf_literal to SprintfLiteral. r=froydnj 2016-08-14 23:44:00 -07:00
BasicEvents.h Bug 1315862 Part1: Stop dispatching pointer events in the system group. r=masayuki,smaug 2016-11-11 18:02:37 +08:00
CommandList.h
CompositorWidget.cpp Implement vsync notification for remote compositors. (bug 1285625 part 3, r=mchang) 2016-07-19 11:56:07 -07:00
CompositorWidget.h Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions. r=dvander 2016-11-07 21:16:52 -05:00
ContentCache.cpp Bug 1304620 part.4 ContentCacheInParent::mCompositionStart should be set to better value for mWidgetHasComposition state r=m_kato 2016-10-12 22:05:09 +09:00
ContentCache.h Bug 1304620 part.5 ContentCacheInParent should store the latest composition start offset with mCompositionStartInChild r=m_kato 2016-10-12 21:52:01 +09:00
ContentEvents.h Bug 1259672 Rename InternalFormEvent::originator to mOriginator r=smaug 2016-08-03 17:06:10 +09:00
EventClassList.h
EventForwards.h Bug 1297013 part.2 Implement some helper methods to log constants related to event handling r=smaug 2016-09-15 00:48:47 +09:00
EventMessageList.h Bug 1317853 - Remove DOM/speakermanager and related code. r=jst 2016-11-16 13:14:36 -08:00
FontRange.h
GfxDriverInfo.cpp Backed out changeset cf43cacdb262 (bug 1294232) for XPCShell failures 2016-09-21 14:24:26 +08:00
GfxDriverInfo.h Backed out changeset cf43cacdb262 (bug 1294232) for XPCShell failures 2016-09-21 14:24:26 +08:00
GfxInfoBase.cpp Add a usingGPUProcess property to nsIGfxInfo. (bug 1317441 part 1, r=mattwoodrow) 2016-11-14 15:02:02 -08:00
GfxInfoBase.h Add a usingGPUProcess property to nsIGfxInfo. (bug 1317441 part 1, r=mattwoodrow) 2016-11-14 15:02:02 -08:00
GfxInfoCollector.cpp
GfxInfoCollector.h
GfxInfoWebGL.cpp
GfxInfoWebGL.h
GfxInfoX11.cpp Bug 1314904 - uname() on success can return non-negative value (not just 0). r=bsmedberg 2016-11-03 03:23:46 -07:00
GfxInfoX11.h Backed out changeset cf43cacdb262 (bug 1294232) for XPCShell failures 2016-09-21 14:24:26 +08:00
IMEData.h Bug 1282669 Get rid of nsIMEUpdatePreference::DontNotifyChangesCausedByComposition() r=m_kato 2016-06-28 16:51:59 +09:00
InProcessCompositorWidget.cpp Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions. r=dvander 2016-11-07 21:16:52 -05:00
InProcessCompositorWidget.h Bug 1315706 - Pass a wrapper struct to various CompositorWidget functions. r=dvander 2016-11-07 21:16:52 -05:00
InputData.cpp Bug 1298886 - Convert the PinchGestureInput span fields from float to ParentLayerCoord. r=botond 2016-09-24 09:46:01 -04:00
InputData.h Bug 1302736 - Fire click events with a clickCount of 2 when the user does a double-tap gesture with double taps not allowed. r=botond 2016-09-29 10:05:25 -04:00
LSBUtils.cpp Bug 1289561 - Implement LSB release annotation in crash reports. r=jrmuizel 2016-07-26 14:23:47 -04:00
LSBUtils.h Bug 1289561 - Implement LSB release annotation in crash reports. r=jrmuizel 2016-07-26 14:23:47 -04:00
LookAndFeel.h Bug 1302157 - Remove images-in-menu and images-in-button code (& associated icons) since it's deprecated in GTK. r=bz,dholbert 2016-09-29 00:22:32 +01:00
MiscEvents.h Bug 1259669 Rename WidgetCommandEvent::command to WidgetCommandEvent::mCommand r=masayuki 2016-05-12 13:28:31 +09:00
MouseEvents.h Bug 1304315 - [Pointer Event] Make all pointer events's default width/height to 1. f=bevistseng. r=smaug,masayuki. 2016-09-21 16:26:21 +08:00
NativeKeyToDOMCodeName.h Bug 1285554 - Remove remnants of widget/qt. r=dougt,mshal. 2016-07-12 09:16:45 +10:00
NativeKeyToDOMKeyName.h Bug 1306137 - remove b2g camera code: Remove dom/camera/ and code which depends on it. r=aosmond,bkelly 2016-10-04 20:16:28 +02:00
PCompositorWidget.ipdl Implement vsync notification for remote compositors. (bug 1285625 part 3, r=mchang) 2016-07-19 11:56:07 -07:00
PlatformWidgetTypes.ipdlh Move CompositorWidget construction out of nsIWidget. (bug 1281998 part 5, r=jimm) 2016-07-01 01:15:16 -07:00
PluginWidgetProxy.cpp Bug 1290766 - Return the scroll capture information from the PPluginWidget Create method, instead of using a separate asynchronous method which is delivered later and may race with fast shutdown. r=billm 2016-10-05 11:36:26 -04:00
PluginWidgetProxy.h Bug 1293596 (part 4) - Tweak nsIWidget::Create. r=mstange. 2016-08-19 09:03:17 +10:00
PuppetBidiKeyboard.cpp Bug 1257731 - Part 1. Send HaveBidiKeyboards information to content process. r=masayuki 2016-06-03 18:56:04 +09:00
PuppetBidiKeyboard.h Bug 1257731 - Part 1. Send HaveBidiKeyboards information to content process. r=masayuki 2016-06-03 18:56:04 +09:00
PuppetWidget.cpp Bug 1315974 - When creating the widget layer manager, don't assume it will always be a ClientLayerManager. r=mattwoodrow 2016-11-08 10:42:26 -05:00
PuppetWidget.h Bug 1304692 - Make puppet widget get coordinate rounding from parent. r=smaug 2016-09-27 16:37:07 +10:00
ScreenProxy.cpp Bug 1300421 - Back out 4 csets from bug 1288760 for regressing event coordinate reporting. r=jfkthame 2016-09-29 10:20:52 -04:00
ScreenProxy.h Bug 1300421 - Back out 4 csets from bug 1288760 for regressing event coordinate reporting. r=jfkthame 2016-09-29 10:20:52 -04:00
SharedWidgetUtils.cpp
SystemTimeConverter.h
TextEventDispatcher.cpp Bug 1303273 part.3 Dispatch eKeyPress events without NativeKey::HandleCharMessage() when it handles WM_(SYS)KEYDOWN message and there are following WM_(SYS)CHAR messages which includes non-control character r=m_kato 2016-10-06 20:52:03 +09:00
TextEventDispatcher.h Bug 1303273 part.3 Dispatch eKeyPress events without NativeKey::HandleCharMessage() when it handles WM_(SYS)KEYDOWN message and there are following WM_(SYS)CHAR messages which includes non-control character r=m_kato 2016-10-06 20:52:03 +09:00
TextEventDispatcherListener.h
TextEvents.h Bug 1304620 part.2 ContentCacheInParent should manage if there is pending composition in the remote process r=m_kato 2016-10-12 17:09:02 +09:00
TextRange.h Bug 1275914 part.8 TextComposition should always update its composition start offset during composing r=smaug 2016-06-20 16:34:40 +09:00
TouchEvents.h Bug 1259666 - Part 3- change displayPanFeedback to mDisplayPanFeedback - r=masayuki 2016-05-14 18:03:50 -07:00
VsyncDispatcher.cpp Implement vsync notification for remote compositors. (bug 1285625 part 3, r=mchang) 2016-07-19 11:56:07 -07:00
VsyncDispatcher.h Implement vsync notification for remote compositors. (bug 1285625 part 3, r=mchang) 2016-07-19 11:56:07 -07:00
WidgetEventImpl.cpp Bug 1315862 Part1: Stop dispatching pointer events in the system group. r=masayuki,smaug 2016-11-11 18:02:37 +08:00
WidgetMessageUtils.h Bug 1262671 - void** -> PickleIterator (r=froydnj) 2016-05-27 09:57:38 -07:00
WidgetTraceEvent.h
WidgetUtils.cpp Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 2016-08-24 14:47:04 +08:00
WidgetUtils.h Bug 1260091 - Move using SendBidiKeyboardNotify to WidgetUtils. r=masayuki 2016-05-19 17:47:49 +09:00
WindowSurface.h Bug 1285561 - Refactor surface blitting on X11. r=jrmuizel 2016-07-14 10:11:46 -04:00
WindowSurfaceX11SHM.cpp Bug 1285561 - Refactor surface blitting on X11. r=jrmuizel 2016-07-14 10:11:46 -04:00
WindowSurfaceX11SHM.h Bug 1285561 - Refactor surface blitting on X11. r=jrmuizel 2016-07-14 10:11:46 -04:00
moz.build Bug 1313525 - Remove the nsIPrintOptions interface. r=mstange 2016-10-28 00:31:14 +01:00
nsAppShellSingleton.h
nsBaseAppShell.cpp Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
nsBaseAppShell.h
nsBaseClipboard.cpp Bug 1261299 - Implement nsIClipboard methods in nsClipboard.mm with methods specific for osx. (EmptyClipboard, SetData) methods modified from nsBaseClipboard to also set the current selection cache. r=jimm 2016-08-11 16:43:32 -04:00
nsBaseClipboard.h Bug 1261299 - Implement nsIClipboard methods in nsClipboard.mm with methods specific for osx. (EmptyClipboard, SetData) methods modified from nsBaseClipboard to also set the current selection cache. r=jimm 2016-08-11 16:43:32 -04:00
nsBaseDragService.cpp Bug 1301673, convert the image width and height to device pixels so that custom drag images are drawn at the right size, r=tn 2016-10-19 15:01:40 -04:00
nsBaseDragService.h Bug 1301673, convert the image width and height to device pixels so that custom drag images are drawn at the right size, r=tn 2016-10-19 15:01:40 -04:00
nsBaseFilePicker.cpp Bug 1295914, improve the label of the button of folder picker, r=baku,mstange,karlt,jimm 2016-08-24 02:07:21 +03:00
nsBaseFilePicker.h Bug 1295914, improve the label of the button of folder picker, r=baku,mstange,karlt,jimm 2016-08-24 02:07:21 +03:00
nsBaseScreen.cpp
nsBaseScreen.h
nsBaseWidget.cpp Don't reset devices for each tab when the compositor resets. (bug 1316788, r=rhunt) 2016-11-14 11:47:01 -08:00
nsBaseWidget.h Don't reset devices for each tab when the compositor resets. (bug 1316788, r=rhunt) 2016-11-14 11:47:01 -08:00
nsClipboardHelper.cpp
nsClipboardHelper.h
nsClipboardProxy.cpp Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsClipboardProxy.h
nsColorPickerProxy.cpp Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsColorPickerProxy.h Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsContentProcessWidgetFactory.cpp Bug 825294 - Add framework for datepicker widgets to input[type=date]. r=smaug 2016-06-20 15:55:00 +02:00
nsDatePickerProxy.cpp Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsDatePickerProxy.h Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsDeviceContextSpecProxy.cpp Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 2016-08-24 14:47:04 +08:00
nsDeviceContextSpecProxy.h Bug 1293117 (part 5) - Change many NS_METHOD occurrences to NS_IMETHOD. r=froydnj. 2016-08-08 10:54:50 +10:00
nsDragServiceProxy.cpp Bug 1301673, properly handle disabled drag feedback image and failed drag feedbacks in content processes, r=tn 2016-10-19 15:01:39 -04:00
nsDragServiceProxy.h Bug 1309698 - Remove usage of nsISupportsArray from nsIDragService. r=smaug 2016-10-18 11:56:20 -07:00
nsFilePickerProxy.cpp Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsFilePickerProxy.h Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsGUIEventIPC.h Bug 1258808 - Part 1: Passing PointerId (Gecko). r=smaug, f=btseng 2016-09-01 16:12:15 +08:00
nsHTMLFormatConverter.cpp Bug 1313280 - Fix invalid non-UTF-8 bytes from widget/. r=jimm 2016-11-02 20:46:53 +09:00
nsHTMLFormatConverter.h Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsIAppShell.idl
nsIApplicationChooser.idl
nsIBaseWindow.idl Bug 881832 - Make inner document reflow asynchronous. r=tnikkel 2016-05-12 12:07:45 +12:00
nsIBidiKeyboard.idl
nsIClipboard.idl Bug 1261299 - Add new clipboard kSelectionCache to cache the current selection for OSX service menu. Add a constructor to nsAutoCopyListener which sets the clipboard to copy to. Pass in kSelectionCache for OSX or kSelectionClipboard for linux. r=mstange 2016-06-03 12:04:22 -04:00
nsIClipboardDragDropHookList.idl
nsIClipboardDragDropHooks.idl
nsIClipboardHelper.idl
nsIClipboardOwner.idl
nsIColorPicker.idl
nsIDatePicker.idl Bug 825294 - Add framework for datepicker widgets to input[type=date]. r=smaug 2016-06-20 15:55:00 +02:00
nsIDeviceContextSpec.h Bug 1279628, part 2 - Switch all but one of the gfxASurface::CheckSurfaceSize calls to call Factory::CheckSurfaceSize. r=mstange 2016-06-10 13:32:01 +01:00
nsIDisplayInfo.idl
nsIDragService.idl Bug 1309698 - Remove usage of nsISupportsArray from nsIDragService. r=smaug 2016-10-18 11:56:20 -07:00
nsIDragSession.idl
nsIFilePicker.idl Bug 1295914, improve the label of the button of folder picker, r=baku,mstange,karlt,jimm 2016-08-24 02:07:21 +03:00
nsIFormatConverter.idl Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsIGfxInfo.idl Add a usingGPUProcess property to nsIGfxInfo. (bug 1317441 part 1, r=mattwoodrow) 2016-11-14 15:02:02 -08:00
nsIGfxInfoDebug.idl
nsIIdleService.idl
nsIIdleServiceInternal.idl
nsIJumpListBuilder.idl
nsIJumpListItem.idl
nsIKeyEventInPluginCallback.h Bug 1257759 part.5 PluginInstanceChild should post received native key event to chrome process if the key combination may be a shortcut key r=jimm 2016-04-19 20:09:37 +09:00
nsIMacDockSupport.idl
nsIMacWebAppUtils.idl
nsINativeMenuService.h
nsIPluginWidget.h
nsIPrintDialogService.h
nsIPrintSession.idl
nsIPrintSettings.idl Bug 1260480 - Remove mozNoMarginBoxes. r=dbaron 2016-04-06 09:53:00 +02:00
nsIPrintSettingsService.idl Bug 1189846 Part 3: Remove CreatePrintSettings nsIPrintOptions and use GetNewPrintSettings instead. r=jimm 2016-05-16 10:40:54 +01:00
nsIPrintSettingsWin.idl
nsIPrinterEnumerator.idl Bug 1313525 - Remove the nsIPrintOptions interface. r=mstange 2016-10-28 00:31:14 +01:00
nsIRollupListener.h
nsIScreen.idl Bug 1282003 - (Part 1) Add display type/density info and addScreen/removeScreen function. r=snorp 2016-10-03 16:23:23 +08:00
nsIScreenManager.idl
nsISound.idl
nsIStandaloneNativeMenu.idl
nsISystemStatusBar.idl
nsITaskbarOverlayIconController.idl
nsITaskbarPreview.idl
nsITaskbarPreviewButton.idl
nsITaskbarPreviewController.idl
nsITaskbarProgress.idl
nsITaskbarTabPreview.idl
nsITaskbarWindowPreview.idl
nsITransferable.idl Bug 1312936 - Part 1. Use ACString for nsITranserable.getAnyTransferData. r=masayuki 2016-10-26 11:07:16 +09:00
nsIWidget.h Bug 1282003 - (Part 3) Add screen ID to nsWindow and GeckoView to get the correct nsScreen and density. r=snorp 2016-09-29 14:23:56 +08:00
nsIWidgetListener.cpp Bug 1264409 - Make last transaction ID available via nsIDOMWindowUtils, and pass transaction ID through MozAfterPaint. r=mattwoodrow,mrbkap 2016-04-13 16:59:15 -04:00
nsIWidgetListener.h Bug 1264409 - Make last transaction ID available via nsIDOMWindowUtils, and pass transaction ID through MozAfterPaint. r=mattwoodrow,mrbkap 2016-04-13 16:59:15 -04:00
nsIWinTaskbar.idl
nsIWindowsUIUtils.idl
nsIdleService.cpp Bug 1281793 - part 7 - Remove some non-used telemetry IDs - widget directory, r=gfritzsche 2016-07-04 17:11:52 +02:00
nsIdleService.h
nsNativeTheme.cpp Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ; r=manishearth,xidorn 2016-10-28 06:17:20 +02:00
nsNativeTheme.h bug 1311604 consider block flow direction in vertical writing mode native widget layout r=jfkthame 2016-10-20 17:57:55 +13:00
nsPrimitiveHelpers.cpp Bug 860857, support custom datatransfer types using a special type, r=smaug,jmathies,mstange 2016-04-21 14:11:14 -04:00
nsPrimitiveHelpers.h
nsPrintOptionsImpl.cpp Bug 1313525 - Remove the nsIPrintOptions interface. r=mstange 2016-10-28 00:31:14 +01:00
nsPrintOptionsImpl.h Bug 1313525 - Remove the nsIPrintOptions interface. r=mstange 2016-10-28 00:31:14 +01:00
nsPrintSession.cpp
nsPrintSession.h
nsPrintSettingsImpl.cpp Bug 1260480 - Remove mozNoMarginBoxes. r=dbaron 2016-04-06 09:53:00 +02:00
nsPrintSettingsImpl.h Bug 1260480 - Remove mozNoMarginBoxes. r=dbaron 2016-04-06 09:53:00 +02:00
nsScreenManagerProxy.cpp Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 2016-08-24 14:47:04 +08:00
nsScreenManagerProxy.h
nsShmImage.cpp bug 1316165 ensure xcb_get_input_focus_reply is called to avoid leaking the reply r=lsalzman 2016-11-09 08:56:27 +13:00
nsShmImage.h bug 1316165 ensure xcb_get_input_focus_reply is called to avoid leaking the reply r=lsalzman 2016-11-09 08:56:27 +13:00
nsTransferable.cpp Bug 1312936 - Part 1. Use ACString for nsITranserable.getAnyTransferData. r=masayuki 2016-10-26 11:07:16 +09:00
nsTransferable.h Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsWidgetInitData.h
nsWidgetsCID.h Bug 825294 - Add framework for datepicker widgets to input[type=date]. r=smaug 2016-06-20 15:55:00 +02:00
nsXPLookAndFeel.cpp Bug 1288077: Whitespace fixes, r=froydnj 2016-07-20 17:29:36 +02:00
nsXPLookAndFeel.h Bug 384458 - part 1: make the background color of the SELECTION_ATTENTION range fully transparent when modal highlighting is on. r=masayuki 2016-06-09 13:30:44 +02:00