gecko-dev/dom/plugins
David Major 3e928e865e Bug 1665351 - Disable CFG for plugin hook stub calls r=handyman
As we saw in bug 1598119, 32-bit nop-space patches aren't compatible with clang 11's CFG because they return to the second instruction of the hooked function.

The `FunctionHook`s for plugins were pulling raw function pointers out of the interceptor stubs, so they didn't get the benefit of the stub's `operator()` that already has the CFG annotation.

As a bandaid, this patch marks all users of `BasicFunctionHook::OriginalFunction()` with the CFG annotation as well. A more thorough fix might be to somehow pass through to the stub's `operator()`, but we need something before merge day and I'm not confident in being able to do that regression-free in time.

Differential Revision: https://phabricator.services.mozilla.com/D90629
2020-09-18 16:27:03 +00:00
..
base Bug 1662364 - use content principal as the triggering principal when opening external URIs from plugins, r=ckerschb 2020-09-15 07:33:25 +00:00
ipc Bug 1665351 - Disable CFG for plugin hook stub calls r=handyman 2020-09-18 16:27:03 +00:00
test Bug 1658791: Make SpecialPowers.pushPermissions Fission-compatible. r=mccr8 2020-09-16 19:32:46 +00:00