gecko-dev/docshell
Kris Maglione d7eecef1e9 Bug 1574593: Silently ignore load attempt on/from discarded BrowsingContext. r=nika
The (non-normative) window.open spec does not specify what should happen when
window.open is called on a window with a null/discarded browsing context, but
in general the lookup and creation rules do not make sense when the window has
no BC. It does, however, specify that we should return null when a target BC
cannot be found or created, and gives us broad discretion over when we decide
to ignore a load request and return null. Since we can't trigger a
cross-process load from a discarded BC, simply aborting in that case seems
like the logical solution.

For Location objects, the spec is more specific, and requires that we ignore
load attempts on Location objects whose documents are null, which in our
implementation corresponds to a discarded BrowsingContext.
LocationBase::SetURI already enforces this, but a second check in
BrowsingContext::LoadURI is probably a good idea as well.

Differential Revision: https://phabricator.services.mozilla.com/D45635

--HG--
extra : moz-landing-system : lando
2019-09-12 11:37:01 +00:00
..
base Bug 1574593: Silently ignore load attempt on/from discarded BrowsingContext. r=nika 2019-09-12 11:37:01 +00:00
build Bug 1553498 - Inserts an empty page for about:certviewer and redirects to it when the user put that URL in the browser. r=johannh,smaug 2019-05-23 22:12:30 +00:00
resources/content Bug 1561435 - Format docshell/, a=automatic-formatting 2019-07-05 09:59:46 +02:00
shistory Bug 1528697 - Expose ReferrerPolicy.webidl and use referrerpolicy enum r=smaug 2019-08-21 13:24:45 +00:00
test Bug 1579820 - Handle window.open() from remote subframes. r=nika 2019-09-10 09:04:17 +00:00
moz.build Bug 1529088 - Hold the HTML-based about:config to Nightly until we get Product sign-off. r=florian,paolo 2019-02-27 21:54:57 +00:00