Michael Comella 034b23ff41 Bug 1173147 - Explicitly show Android chooser when there is more than one intent URI match in pb. r=sebastian ... After this changeset series, the expected flow for web links is: * If not pb, open the Intent URI * If pb and no matching applications, open about:neterror * If pb and one matching application, show this dialog * If pb and > 1 matching application, show the Android system chooser When the user explicitly chooses to share (and thus should infer they're exiting Private Browsing), we don't show the dialog. Custom URIs sort of work: I tested `mailto` and it worked as expected but `tel` does not work as expected (i.e. it doesn't show the dialog). Perhaps there's an explicit "Open dialer" code path. To figure this out, I tested this patch against my Intent URI test page [1]. Decisions around explicitly showing the Android chooser: When there are multiple application matches to an Intent URI, we want to show the Android Intent Chooser. However, we have no way of distinguishing regular tabs from private tabs to the chooser. Thus, if a user chooses "Always" in regular browsing mode, the chooser will not be shown and the URL will be opened. Therefore we explicitly show the chooser (which notably does not have an "Always" option). [1]: https://people.mozilla.org/~mcomella/test/uri.html --HG-- extra : commitid : 1cCVQe5jmNx extra : rebase_source : 146766c2ac5cf8814288377453253debc2ff3f8a		2015-09-23 14:48:28 -07:00
..
android	Bug 1173147 - Explicitly show Android chooser when there is more than one intent URI match in pb. r=sebastian	2015-09-23 14:48:28 -07:00
locales	Bug 1200665 - Restricted Profiles: Update SUMO title. r=margaret	2015-09-17 10:04:52 +02:00