gecko-dev/layout
Timothy Nikkel b89bb47353 Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange
PaintMaskSurface shouldn't be applying ImgDrawResult::NOT_READY when we don't have a frame and the mask image hasn't been resolved. ImgDrawResult is only about drawing images, not about waiting for external resources to resolve or frames to get constructed. The only purpose of tracking ImgDrawResult's in painting code is to know which frames we need to invalidate because their rendering might change if we sync decode images during a Draw call. Applying NOT_READY here means we invalidate for every paint with the sync decode images flag (ie reftest paints), and it never changes from NOT_READY. This bites the reftest for this bug 1624532.

To fix it, instead of "overloading" the ImgDrawResult we return a bool to indicate the mask is missing or incomplete.

Differential Revision: https://phabricator.services.mozilla.com/D70595

--HG--
extra : moz-landing-system : lando
2020-04-13 20:08:05 +00:00
..
base Bug 1629096 - Always honor scroll-margin / scroll-padding from nsFocusManager. r=masayuki 2020-04-13 11:34:48 +00:00
build Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang 2020-04-11 13:42:12 +00:00
doc
forms Bug 1629096 - Honor scroll-padding / margin in ns{ListControl,MenuPopup}Frame. r=hiro 2020-04-10 21:34:22 +00:00
generic Bug 1628804 - Ensure nsIFrame::ContentSize() returning non-negative sizes. r=dholbert,AlaskanEmily 2020-04-10 22:51:13 +00:00
inspector Bug 1613985 - Use default for equivalent-to-default constructors/destructors in layout. r=dholbert 2020-03-17 09:38:32 +00:00
ipc Bug 1613985 - Use default for equivalent-to-default constructors/destructors in layout. r=dholbert 2020-03-17 09:38:32 +00:00
mathml Bug 1619349 - patch 1 - Record statistics about font-matching behavior in the presContext. r=jwatt 2020-04-02 01:38:18 +00:00
media
painting Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange 2020-04-13 20:08:05 +00:00
printing Bug 1624829 - Use FunctionRef for various Enumerate* callbacks. r=edgar 2020-03-26 12:44:47 +00:00
reftests Bug 1629343. Add test for bug 1469000. r=emilio 2020-04-13 05:14:17 +00:00
style Bug 1621447 - Convert GenerateServoCSSPropList.py to py3. r=emilio 2020-04-09 11:03:02 +00:00
svg Bug 1628988. Don't apply ImgDrawResult::NOT_READY in PaintMaskSurface. r=mstange 2020-04-13 20:08:05 +00:00
tables Bug 1626665: part 11) Declare `nsILineIterator::GetNumLines` `const`. r=hsivonen 2020-04-08 06:57:07 +00:00
tools Bug 1363541 - Modernize the PermissionManager - part 4 - mozilla namespace, r=timhuang 2020-04-11 13:42:12 +00:00
xul Bug 1629096 - Honor scroll-padding / margin in ns{ListControl,MenuPopup}Frame. r=hiro 2020-04-10 21:34:22 +00:00
moz.build