gecko-dev/devtools/client/aboutdebugging
Julian Descottes 1d736794aa Bug 1669353 - [devtools] Tweak about:debugging main process test to check no target is created r=ochameau
Depends on D92499
Tweak an existing mock in the main process about:debugging test to check that we are not creating any target.

Differential Revision: https://phabricator.services.mozilla.com/D92553
2020-10-07 10:54:16 +00:00
..
documentation Bug 1609716 - Unify xpcshell test folders in devtools. r=jdescottes 2020-01-20 13:56:04 +00:00
src Bug 1669353 - [devtools] Stop instantiating main process target front from about:debugging. r=jdescottes 2020-10-07 21:22:32 +00:00
test Bug 1669353 - [devtools] Tweak about:debugging main process test to check no target is created r=ochameau 2020-10-07 10:54:16 +00:00
README.md Bug 1637983 - Replace Slack links by Matrix in documentation. r=jdescottes. 2020-05-14 14:57:15 +00:00
aboutdebugging.css Bug 1652997: Package all devtools css files and load them using the internal chrome: protocol. r=nchevobbe 2020-07-15 16:02:28 +00:00
aboutdebugging.js Bug 1515008 - Move adb from devtools/shared to devtools/client/shared/remote-debugging r=daisuke 2020-03-30 06:56:57 +00:00
index.html Bug 1499354: Add object-src 'none' to the CSP of all about: pages. r=freddyb 2019-09-26 16:22:41 +00:00
initializer.js Bug 1596686 - Use absolute paths for require calls r=gl 2019-12-27 12:23:47 +00:00
moz.build Bug 1609716 - Unify xpcshell test folders in devtools. r=jdescottes 2020-01-20 13:56:04 +00:00

README.md

about:debugging-new

What is about:debugging-new

The purpose of about:debugging is to be a debugging hub to start inspecting your addons, processes, tabs and workers. This new version of about:debugging will also allow you to debug remote devices (Firefox for Android on a smartphone). The user should be able to connect either via USB or WiFi.

To try out about:debugging, type about:debugging in the Firefox URL bar.

Technical overview

The about:debugging-new UI is built using React and Redux. The various React/Redux files should be organized as follows:

  • devtools/client/aboutdebugging/src/actions
  • devtools/client/aboutdebugging/src/components
  • devtools/client/aboutdebugging/src/middleware
  • devtools/client/aboutdebugging/src/reducers

The folder devtools/client/aboutdebugging/src/modules contains various helpers and classes that are not related to React/Redux. For instance modules/usb-runtimes.js provides an abstraction layer to enable USB runtimes scanning, to list USB runtimes etc...

Firefox Component Registration

about:debugging-new is an "about" page registered via a component manifest that is located in /devtools/startup/aboutdebugging.manifest. The component registration code is at /devtools/startup/aboutdebugging-registration.js.

Actions

Actions should cover all user or external events that change the UI.

asynchronous actions

For asynchronous actions, we will use the thunk middleware, similar to what it done in the webconsole and netmonitor. An asynchronous action should be split in three actions:

  • start
  • success
  • failure

As we will implement asynchronous, we should aim to keep a consistent naming for those actions.

A typical usecase for an asynchronous action here would be selecting a runtime. The selection will be immediate but should trigger actions to retrieve tabs, addons, workers etc… which will all be asynchronous.

Components

Components should avoid dealing with specialized objects as much as possible.

They should never use any of the lifecycle methods that will be deprecated in React 17 (componentWillMount, componentWillReceiveProps, and componentWillUpdate).

When it comes to updating the state, components should do it via an action if the result of this action is something that should be preserved when reloading the UI.

Middlewares

We use several middlewares in the application. The middlewares are required in the create-store module devtools/client/aboutdebugging/src/create-store.js.

thunk

This is a shared middleware used by other DevTools modules that allows to dispatch actions and allows to create multiple asynchronous actions.

debug-target-listener

This middleware is responsible for monitoring a client. It will add various listeners on the client when receiving the WATCH_RUNTIME_SUCCESS action and will remove the listeners when receiving UNWATCH_RUNTIME_SUCCESS. Could probably be ported to an action, no real added value as a middleware.

error-logging

This middleware will forward any error object dispatched by an action to the console. Typically, all the FAILURE actions of our asynchronous actions should dispatch an error object.

extension/tab/worker-component-data

This middleware takes the raw data of a debugging target returned by the devtools client and transforms it to presentation data that can be used by the debugtarget components. Could probably be ported to an action, no real added value as a middleware.

waitUntilService

This is a shared middleware used by other DevTools modules that allows to wait until a given action is dispatched. We use it in mochitests.

state

The state represents the model for the UI of the application.

ui

Holds the global state of the application. This can contain generic preferences such as "is feature X enabled" or purely UI related "is category X collapsed".

runtimes

Holds the current list of runtimes known by the application as well as the currently selected runtime.

debug-targets

Holds all the debug targets (ie tabs, addons, workers etc...) for the currently monitored runtime. There is at most one monitored runtime at a given time.

Constants

Constants can be found at devtools/client/aboutdebugging/src/constants.js. It contains all the actions available in about:debugging as well as several other "packages" of constants used in the application.

If a constant (string, number, etc...) is only used in a single module it can be defined as a const in this module. However as soon as the constant is shared by several modules, it should move to devtools/client/aboutdebugging/src/constants.js.

Types

Types can be found at devtools/client/aboutdebugging/src/types.js. They serve both as documentation as well as validation. We do not aim at having types for every single element of the state, but only for complex objects.

Contact

If you have any questions about the code, features, planning, the active team is:

  • engineering: Belén Albeza (:ladybenko)
  • engineering: Daisuke Akatsuka (:daisuke)
  • engineering: Julian Descottes (:jdescottes)
  • product management: Harald Kischner (:digitarald)

You can find us on Matrix.