gecko-dev/toolkit
Ethan Glasser-Camp 428ab05ab2 Bug 1440779: BaseAction: move _preExecute call out of constructor r=mythmon,Gijs
Having _preExecute be called in the constructor makes it hard to test
it, but because it's a lifecycle hook that subclasses are intended to
override, testing it is very natural.

While we're here, move the initialization of AddonStudyAction from
_preExecute to the constructor, since it doesn't really make sense for
AddonStudyAction to be constructed without all members initialized.

Differential Revision: https://phabricator.services.mozilla.com/D13572

--HG--
extra : moz-landing-system : lando
2018-12-13 16:02:25 +00:00
..
actors Bug 1511138 - Fix getComputedStyle usage of SelectChild. r=mconley 2018-12-07 14:24:49 -05:00
components Bug 1440779: BaseAction: move _preExecute call out of constructor r=mythmon,Gijs 2018-12-13 16:02:25 +00:00
content Merge autoland to mozilla-central. a=merge 2018-12-13 05:54:41 +02:00
crashreporter Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
forgetaboutsite Bug 1286798 - Part 16: Adjust ClearDataService for new local storage implementation; r=asuth 2018-11-29 21:48:05 +01:00
library Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
locales Bug 1474591 - Clarify default theme description. r=mstriemer 2018-12-11 17:21:52 +00:00
modules Bug 1345474 - Check incognito access for webNavigation api, r=rpl 2018-12-12 14:34:19 +00:00
mozapps Bug 1415483 - Apply the new options to reject-importGlobalProperties across the codebase, remove unnecessary importGlobalProperties. r=nika 2018-12-11 21:39:40 +00:00
pluginproblem Bug 1497940 - Part V, Convert pluginProblem to UA Widget r=smaug 2018-11-22 05:49:54 +00:00
profile Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
recordreplay Bug 1513277 part 2 - Use the scripted caller's global in mozJSComponentLoader::FindTargetObject. r=kmag 2018-12-12 21:30:04 +00:00
system Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
themes Bug 1509634 - Remove toolkit/themes/osx/mozapps/extensions/toolbarbutton-dropmarker.png and replace usage with arrow-dropdown-12.svg. r=jaws 2018-12-12 22:31:12 +01:00
xre Bug 1485836: Move call to SandboxBroker::GeckoDependentInitialize into nsXREDirProvider::DoStartup. r=froydnj 2018-12-11 13:12:48 +00:00
.eslintrc.js
moz.build
moz.configure Bug 1513134 - Detect unnecessary --help dependencies. r=firefox-build-system-reviewers,gps 2018-12-11 19:34:28 +00:00
nss.configure Bug 1513134 - Detect unnecessary --help dependencies. r=firefox-build-system-reviewers,gps 2018-12-11 19:34:28 +00:00
toolkit.mozbuild Bug 1508782 - Add moz.yaml for bspatch in toolkit/mozapps/update; r=mhowell 2018-12-10 19:07:42 +00:00