gecko-dev/layout
Emilio Cobos Álvarez 1288b871bf Bug 1510485 - Properly handle errors in nsFind when returning a range. r=bzbarsky
Bug 1505887 changed the behavior here from content calling into nsFind via
window.find(), by making the SetStart and SetEnd calls here fail instead of
succeed for NAC (like the text in textareas).

This patch makes us handle that error gracefully moving on to the next match,
instead of trying to preserve the previous behavior.

This means that we'll fail to highlight textarea content and such from
window.find, which Chromium does, looks like. Though Chromium doesn't expose
the ranges as selection either. In any case I don't think that this is a very
common thing given bugs like bug 1442466, which this bug fixes.

I haven't found anything close to a spec for what window.find() should do... If
we decide to go with this patch then I'll add a crashtest for this and a test
for bug 1442466 as well. Otherwise I'll add a way to skip the security check in
nsFind somehow for NAC, or relax the security restrictions in SetStart /
SetEnd, I guess.

Differential Revision: https://phabricator.services.mozilla.com/D14013

--HG--
extra : moz-landing-system : lando
2018-12-11 01:06:32 +00:00
..
base Bug 1510485 - Properly handle errors in nsFind when returning a range. r=bzbarsky 2018-12-11 01:06:32 +00:00
build Bug 1511730 patch 3 - Verify there are no frame state bit conflicts within groups. r=heycam 2018-12-05 15:44:01 +00:00
doc Bug 1483090 - Rename StyleUserInterface to StyleUI. r=emilio 2018-08-14 08:37:37 +00:00
forms Bug 1513015 - Remove unneeded inherit-scroll-behavior class. r=botond 2018-12-10 18:03:44 +00:00
generic Bug 1486204 - Make nsLookAndFeel.mm return transparent selection colors. r=mstange 2018-12-10 22:41:46 +00:00
inspector Bug 1512112: Remove redundant includes from source files in layout. r=TYLin 2018-12-05 18:55:59 +00:00
ipc Bug 1510853 - Introduce VsyncId and VsyncEvent for identifying vsyncs without timestamp comparisons. r=jrmuizel 2018-12-07 23:27:28 +00:00
mathml Bug 1512716 - Re-indent NS_QUERYFRAME macros after clang-format. r=TYLin 2018-12-07 20:00:18 +00:00
media
painting Bug 1512267 - If you set a pres shell resolution, you must scale to it. r=kats,JanH 2018-12-10 19:32:59 +00:00
printing Bug 1512961 - Reformat recent changes to the Google coding style r=Ehsan 2018-12-10 19:23:16 +00:00
reftests Bug 1484884 - Fix async zoom transform computation for layout viewport. r=kats 2018-12-09 00:53:20 +00:00
style Bug 1513015 - Remove unneeded inherit-scroll-behavior class. r=botond 2018-12-10 18:03:44 +00:00
svg Bug 1512716 - Re-indent NS_QUERYFRAME macros after clang-format. r=TYLin 2018-12-07 20:00:18 +00:00
tables Bug 1512716 - Re-indent NS_QUERYFRAME macros after clang-format. r=TYLin 2018-12-07 20:00:18 +00:00
tools Bug 1513082 - Make the layout debugger window a bit bigger r=emilio 2018-12-10 21:52:44 +00:00
xul Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-12-11 00:10:08 +02:00
moz.build Bug 1512914 - Add an --enable-layout-debugger configure option r=froydnj 2018-12-10 15:47:36 +00:00