зеркало из https://github.com/mozilla/gecko-dev.git
1288b871bf
Bug 1505887 changed the behavior here from content calling into nsFind via window.find(), by making the SetStart and SetEnd calls here fail instead of succeed for NAC (like the text in textareas). This patch makes us handle that error gracefully moving on to the next match, instead of trying to preserve the previous behavior. This means that we'll fail to highlight textarea content and such from window.find, which Chromium does, looks like. Though Chromium doesn't expose the ranges as selection either. In any case I don't think that this is a very common thing given bugs like bug 1442466, which this bug fixes. I haven't found anything close to a spec for what window.find() should do... If we decide to go with this patch then I'll add a crashtest for this and a test for bug 1442466 as well. Otherwise I'll add a way to skip the security check in nsFind somehow for NAC, or relax the security restrictions in SetStart / SetEnd, I guess. Differential Revision: https://phabricator.services.mozilla.com/D14013 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| actors | ||
| components | ||
| content | ||
| crashreporter | ||
| forgetaboutsite | ||
| library | ||
| locales | ||
| modules | ||
| mozapps | ||
| pluginproblem | ||
| profile | ||
| recordreplay | ||
| system | ||
| themes | ||
| xre | ||
| .eslintrc.js | ||
| moz.build | ||
| moz.configure | ||
| nss.configure | ||
| toolkit.mozbuild | ||