зеркало из https://github.com/mozilla/gecko-dev.git
6bba243c2c
HTMLEditor::GetCellIndexes() is an XPCOM method and used a lot internally. So, we need alternative way to retrieve indexes of a cell without virtual calls. In a lot of places, receiving indexes with 2 int32_t variables causes the code messy and that causes making it harder to understand which are index for same cell and where they come from. So, making both of them stored one variable makes the callers simpler. Therefore, this patch creates CellIndexes stack class to get and store the result simply. Then, this makes all callers of GetCellIndexes() use this new class and makes GetCellIndexes() also use this new class. FYI: This patch does NOT put ErrorResult instances in small block scope as far as possible. The reason is, I see its destructor in profile sometimes. I don't think that we should use nsresult& instead of ErrorResult& only for this performance reason, but I think that creating each instance in loops does not make sense. Differential Revision: https://phabricator.services.mozilla.com/D3849 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .. | ||
| composer | ||
| libeditor | ||
| reftests | ||
| spellchecker | ||
| txmgr | ||
| AsyncSpellCheckTestHelper.jsm | ||
| moz.build | ||
| nsEditorCID.h | ||
| nsIDocumentStateListener.idl | ||
| nsIEditActionListener.idl | ||
| nsIEditor.idl | ||
| nsIEditorMailSupport.idl | ||
| nsIEditorObserver.idl | ||
| nsIEditorSpellCheck.idl | ||
| nsIEditorStyleSheets.idl | ||
| nsIEditorUtils.idl | ||
| nsIHTMLAbsPosEditor.idl | ||
| nsIHTMLEditor.idl | ||
| nsIHTMLInlineTableEditor.idl | ||
| nsIHTMLObjectResizer.idl | ||
| nsIPlaintextEditor.idl | ||
| nsITableEditor.idl | ||
| nsIURIRefObject.idl | ||