зеркало из https://github.com/mozilla/gecko-dev.git
390c6943fe
This shouldn't change behavior, but is the biggest cross-platform part
of the change so I'd like to get it landed sooner rather than later.
The two calls like:
GetColor(ColorID::TextSelectBackground, color);
if (color == 0x000000) {
mColorTextSelectForeground = NS_RGB(0xff, 0xff, 0xff);
} else {
mColorTextSelectForeground = NS_DONT_CHANGE_COLOR;
}
that I'm removing are just broken. They were calling the version of
GetColor the function that took a default value when the color wasn't
available, not the version of the color with the outparam.
To prevent such mistakes, add two signatures, GetColor(), returning a
Maybe<nscolor> and Color(), returning a color with a fallback.
Differential Revision: https://phabricator.services.mozilla.com/D110651
|
||
|---|---|---|
| .. | ||
| crashtests | ||
| tests | ||
| jar.mn | ||
| mathfont.properties | ||
| mathfontSTIXGeneral.properties | ||
| mathfontUnicode.properties | ||
| mathml.css | ||
| moz.build | ||
| nsIMathMLFrame.h | ||
| nsMathMLAtoms.h | ||
| nsMathMLChar.cpp | ||
| nsMathMLChar.h | ||
| nsMathMLContainerFrame.cpp | ||
| nsMathMLContainerFrame.h | ||
| nsMathMLFrame.cpp | ||
| nsMathMLFrame.h | ||
| nsMathMLOperators.cpp | ||
| nsMathMLOperators.h | ||
| nsMathMLParts.h | ||
| nsMathMLSelectedFrame.cpp | ||
| nsMathMLSelectedFrame.h | ||
| nsMathMLTokenFrame.cpp | ||
| nsMathMLTokenFrame.h | ||
| nsMathMLmactionFrame.cpp | ||
| nsMathMLmactionFrame.h | ||
| nsMathMLmencloseFrame.cpp | ||
| nsMathMLmencloseFrame.h | ||
| nsMathMLmfracFrame.cpp | ||
| nsMathMLmfracFrame.h | ||
| nsMathMLmmultiscriptsFrame.cpp | ||
| nsMathMLmmultiscriptsFrame.h | ||
| nsMathMLmoFrame.cpp | ||
| nsMathMLmoFrame.h | ||
| nsMathMLmpaddedFrame.cpp | ||
| nsMathMLmpaddedFrame.h | ||
| nsMathMLmrootFrame.cpp | ||
| nsMathMLmrootFrame.h | ||
| nsMathMLmrowFrame.cpp | ||
| nsMathMLmrowFrame.h | ||
| nsMathMLmspaceFrame.cpp | ||
| nsMathMLmspaceFrame.h | ||
| nsMathMLmsqrtFrame.cpp | ||
| nsMathMLmsqrtFrame.h | ||
| nsMathMLmtableFrame.cpp | ||
| nsMathMLmtableFrame.h | ||
| nsMathMLmunderoverFrame.cpp | ||
| nsMathMLmunderoverFrame.h | ||
| nsMathMLsemanticsFrame.cpp | ||
| nsMathMLsemanticsFrame.h | ||
| operatorDictionary.xsl | ||
| updateOperatorDictionary.pl | ||