зеркало из https://github.com/mozilla/gecko-dev.git
2c2c3c23dd
The test that is timing out with these patches does something relatively simple:
await TestUtils.waitForCondition(async function() {
let color = await ContentTask.spawn(browserWindow, async function() {
/* Do stuff... */
});
return color == something;
});
await closeWindow(browserWindow);
Turns out that this can intermittently leak the window due to waitForCondition
using setInterval. setInterval can schedule multiple tasks while awaiting for
the inner ContentTask.
What this means, is that we may still have a ContentTask awaiting us when we get
to close the window. Closing the window makes the ContentTask not finish, and
thus we leak a promise keeping alive the window in gPromises:
https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/testing/mochitest/BrowserTestUtils/ContentTask.jsm#24
Which means that we keep alive the window all the way until shutdown.
Fix it by ensuring that we only run one task at a time.
Differential Revision: https://phabricator.services.mozilla.com/D52833
--HG--
extra : moz-landing-system : lando
|
||
|---|---|---|
| .. | ||
| tests | ||
| AppData.jsm | ||
| AppInfo.jsm | ||
| Assert.jsm | ||
| CoverageUtils.jsm | ||
| FileTestUtils.jsm | ||
| MockRegistrar.jsm | ||
| MockRegistry.jsm | ||
| Sinon.jsm | ||
| StructuredLog.jsm | ||
| TestUtils.jsm | ||
| ajv-4.1.1.js | ||
| moz.build | ||
| sinon-7.2.7.js | ||