gecko-dev/editor/spellchecker
Masayuki Nakano 043e93a8ba Bug 1451672 - part 21: Refine TextEditor::TypedText() r=m_kato
According to existing comments, TextEditor::TypedText() and
HTMLEditor::TypedText() are intentional bottleneck to debug.  However, only
for that purpose, it and its internal methods are made virtual.  This really
doesn't make sense.

So, this patch creates TextEditor::OnInputText() for callers of TypedText()
with non-empty string, TextEditor::OnInputParagraphSeparator() for callers
of TypedText() with eTypeBreak (Enter key or insertParagraphSeparator),
HTMLEditor::OnInputLineBreak() for callers of TypedText() with eTypeBR
(Shift + Enter or insertLineBreak).  Additionally, this creates internal
non-virtual methods for XPCOM methods which are used as internal methods of
TypedText().  One is InsertTextAsAction() for nsIPlatintextEditor.insertText().
the other is InsertParagraphSeparator() for nsIPlaintextEditor.insertLineBreak().

Although those new methods are not have "WithTransaction" postfix, they must
be clearer they'll use transactions since user input and actions should be
undo-able.

MozReview-Commit-ID: AmOkMqovIKA

--HG--
extra : rebase_source : 9c0f4b25fa2a36ad2f3394f72eb290824c31d82a
2018-04-16 23:43:36 +09:00
..
tests Bug 1442500 - Part 3. Move spellchecker tests to editor/spellchecker. r=masayuki 2018-03-02 12:57:54 +09:00
EditorSpellCheck.cpp Bug 1451972 - Remove more nsIDOMDocument usages from editor. r=masayuki 2018-04-06 14:53:05 +09:00
EditorSpellCheck.h Bug 1451972 - Remove more nsIDOMDocument usages from editor. r=masayuki 2018-04-06 14:53:05 +09:00
TextServicesDocument.cpp Bug 1451672 - part 21: Refine TextEditor::TypedText() r=m_kato 2018-04-16 23:43:36 +09:00
TextServicesDocument.h Bug 1451972 - Remove more nsIDOMDocument usages from editor. r=masayuki 2018-04-06 14:53:05 +09:00
moz.build Bug 1442500 - Part 3. Move spellchecker tests to editor/spellchecker. r=masayuki 2018-03-02 12:57:54 +09:00
nsComposeTxtSrvFilter.cpp
nsComposeTxtSrvFilter.h
nsFilteredContentIterator.cpp Bug 1447889 part 8. Remove nsIDOMRange::SelectNode/SelectNodeContents. r=mystor 2018-03-27 00:35:21 -04:00
nsFilteredContentIterator.h Backed out 4 changesets (bug 525063) on request from Andi. a=backout 2018-04-13 16:01:28 +03:00
nsIInlineSpellChecker.idl
nsISpellChecker.h
nsITextServicesFilter.idl