gecko-dev/toolkit/components/captivedetect
Valentin Gosu 5650342313 Bug 1332271 - Do not cancel timer when captive portal request times out r=mcmanus
The fact that nsICaptivePortalServiceCallback.complete got called with a true
argument made it difficult to be sure when the you were actually in a captive
portal, and when the network timed out.
Moreover, one artefact of the initial plan for the captive portal service was
that we'd cancel the timer after the first request succeeded, making the backoff
mechanism not run at all, and only checked for CP when instructed by nsIOService.
This patch changes captivedetect.js to send back success=false when the retry
count is exceeded - it's equivalent to an aborted request anyway - doesn't
cancel the timeer, and changes how we set the current state of the captive portal.

MozReview-Commit-ID: 4RV50KPbEdt
2017-01-24 15:43:30 +01:00
..
test/unit Bug 1332271 - Do not cancel timer when captive portal request times out r=mcmanus 2017-01-24 15:43:30 +01:00
CaptivePortalDetectComponents.manifest
captivedetect.js Bug 1332271 - Do not cancel timer when captive portal request times out r=mcmanus 2017-01-24 15:43:30 +01:00
moz.build Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 2016-07-14 10:16:42 -06:00
nsICaptivePortalDetector.idl