gecko-dev/xpfe/components
Julian Seward 408d24da56 Bug 1382563 - Remove ns*String::AssignWithConversion. r=erahm.
This patch replaces four functions of the name AssignWithConversion which
are essentially wrappers around CopyASCIItoUTF16 and LossyCopyUTF16toASCII
with direct calls to the latter two functions.  The replaced functions are:

  void nsCString::AssignWithConversion( const nsAString& aData )
  void nsString::AssignWithConversion( const nsACString& aData )

  void nsTString_CharT::AssignWithConversion(
                            const incompatible_char_type* aData,
                            int32_t aLength = -1);

The last of the three exists inside the double-included nsTString* world and
so describes two functions, giving four in total.

This has two advantages:

* it removes code

* at the call points, it makes clear (from the replacement name) which
  conversion is being carried out.  The generic name "AssignWithConversion"
  doesn't make that obvious -- one had to infer it from the types.

The patch also removes two commented out lines from
editor/composer/nsComposerCommands.cpp, that appear to be related.  They are
at top level, where they would never have compiled.  They look like
leftovers from some previous change.

--HG--
extra : rebase_source : fb47bf450771c3c9ee3341dd14520f5da69ec4f5
2017-07-24 19:23:52 +02:00
..
autocomplete Bug 1341808 - annotate xpfe/* with BUG_COMPONENTS. r=enndeakin 2017-04-06 07:29:57 -04:00
build Bug 1341808 - annotate xpfe/* with BUG_COMPONENTS. r=enndeakin 2017-04-06 07:29:57 -04:00
directory Bug 1382563 - Remove ns*String::AssignWithConversion. r=erahm. 2017-07-24 19:23:52 +02:00
windowds Bug 1376498 part 2 - Use plain Remove(key) in some places instead of Lookup(key).Remove() for simplicity. r=froydnj 2017-07-05 02:01:44 +02:00
moz.build Bug 1341808 - annotate xpfe/* with BUG_COMPONENTS. r=enndeakin 2017-04-06 07:29:57 -04:00