Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Перейти к файлу
Makoto Kato 609348ba4d Bug 1543312 - Tear down editor when PresShell is destroyed. r=masayuki
When browsing reported site (https://minecraft.curseforge.com/), user that uses Android cannot set caret on some editable contents.

GV's IME code uses `NOTIFY_IME_OF_SELECTION_CHANGE` to update selection on native IME.  But GV doesn't receives this notification on this reported site. This notification is fired by editor's selection listener, but when this occurs, this notification is no logner fired unfortunately.  Because selection listener isn't registered by current selection.

At first, editor registers selection listener by `EditorBase::Init`. But like test case, if PresShell is destroyed after editor is created, this registration is no longer used, and we have to register it by new selection again. So we should tear down editor when PresShell is destroyed. (or we have to add a way to re-initialize selection listener?)

This isn't related to Android. Android's IME code depends on this notification, so this occurs easily.

Also, `PresShell::SetCaretEnabled` only works when caret is valid (`PresShell::GetCaret` has caret).  If caret is nothing, it hits assertion.

And, attached test case is reproduced sample.

Differential Revision: https://phabricator.services.mozilla.com/D41356

--HG--
extra : moz-landing-system : lando
2019-08-13 02:00:00 +00:00
.cargo Bug 1571464: Bump Cranelift to c927680fd42a56efcc9a5ee59e814d9eef6c5b4f; r=jseward 2019-08-07 14:20:48 +00:00
.vscode Bug 1563848 - Recommend a VSCode plugin for prettier. r=vporof 2019-07-06 07:33:28 +00:00
accessible Bug 1567377: Correct a11y semantics for address bar. r=dao 2019-08-12 14:06:27 +00:00
browser Bug 1572670 - Adjusted identity/protections popup heading color and font weight. r=johannh 2019-08-12 19:58:53 +00:00
build Bug 1551344 - Part 1: Remove XULDocument code. r=smaug,Jamie 2019-08-09 19:57:50 +00:00
caps Bug 1551344 - Part 2: Update outdated comments referencing XULDocument. r=smaug 2019-08-09 17:47:41 +00:00
chrome Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE 2019-08-07 01:04:43 +03:00
config Bug 1572394 - Remove MOZ_LDAP_XPCOM ifdef from config/recurse.mk. r=glandium 2019-08-09 01:48:46 +00:00
devtools Bug 1231213 - Various changes to existing tests. r=asuth 2019-08-13 04:04:58 +00:00
docshell Merge mozilla-central to mozilla-inbound. CLOSED TREE 2019-08-10 01:17:41 +03:00
dom Bug 1543312 - Tear down editor when PresShell is destroyed. r=masayuki 2019-08-13 02:00:00 +00:00
editor Bug 1543312 - Tear down editor when PresShell is destroyed. r=masayuki 2019-08-13 02:00:00 +00:00
extensions Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE 2019-08-07 01:04:43 +03:00
gfx Bug 1572646 - Detect and optimize picture cache tiles that are solid colors. r=kvark 2019-08-12 21:59:58 +00:00
gradle/wrapper Bug 1522795 - Update android gradle plugin to 3.4.2. r=nalexander 2019-07-24 18:48:54 +00:00
hal Bug 1289211 - Rename InfallibleTArray to nsTArray in hal/ r=gsvelto 2019-07-10 03:30:52 +00:00
image Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r=smaug 2019-08-09 15:17:06 +00:00
intl Bug 1571671 - Enable RST linting on fluent docs in intl/l10n/docs. r=championshuttler 2019-08-09 19:20:59 +00:00
ipc Backed out 22 changesets (bug 1231213) for build bustages on RemoteWorkerChild.cpp . CLOSED TREE 2019-08-13 07:47:05 +03:00
js Bug 1559963 - Wasm: Add basic tests for declared element segments. r=bbouvier 2019-08-12 22:27:49 +00:00
layout Bug 1572912 - Enable column-span preference to fix existing test failures. r=dbaron 2019-08-12 04:32:34 +00:00
media Bug 1558915 - Use infallible nsIURI::SchemeIs everywhere. r=smaug 2019-08-09 15:17:06 +00:00
memory Bug 1571505 - Properly add dbghelp where needed. r=nalexander 2019-08-06 18:14:12 +00:00
mfbt Bug 1570725 - Show type of assertion in crashreporter MozCrashReason, r=froydnj 2019-08-06 20:33:34 +00:00
mobile Bug 1542004 - Add `android-javadoc` lint. r=agi 2019-08-13 01:45:03 +00:00
modules Bug 1560741 - Part 1: Disallow notification permission requests from cross-origin iframes; r=johannh 2019-08-12 21:38:58 +00:00
mozglue Backed out changeset 58dd47c5aa51 (bug 1573111) for build bustages at TestBaseProfiler.cpp:875:51. CLOSED TREE 2019-08-13 06:21:16 +03:00
netwerk Backed out 22 changesets (bug 1231213) for build bustages on RemoteWorkerChild.cpp . CLOSED TREE 2019-08-13 07:47:05 +03:00
nsprpub Bug 1562330 - Upgrade Firefox 70 to NSPR 4.22 beta1. r=me 2019-07-09 17:40:27 +02:00
other-licenses Bug 1458385: Package mar and mbsdiff as a toolchain; r=glandium 2019-07-11 16:40:13 +00:00
parser Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE 2019-08-07 01:04:43 +03:00
python Bug 1573314 - Add a dependency between 'target-shared' and 'target' targets in the same directory. r=nalexander 2019-08-13 03:00:43 +00:00
remote Bug 1571502: Don't leak TabGroups which have never had windows joined to them. r=nika 2019-08-02 18:19:53 -07:00
security Bug 1564434 - MT_safe_localtime generates incorrect value in sandboxed content process r=handyman 2019-08-12 21:36:03 +00:00
services Bug 1568353 - set the default rest.js timeout to be 5 minutes. r=rfkelly 2019-08-07 05:25:49 +00:00
servo Backed out changeset 0836c998795b (bug 1573106) for wpt failures on accumulation-per-property.html . CLOSED TREE 2019-08-13 05:18:44 +03:00
startupcache Backed out changeset b197ca57677a (bug 1558915) for build bustages. CLOSED TREE 2019-08-07 01:04:43 +03:00
storage Bug 1567739 - Stop using deprecated rust libc integer types in storage_variant and kvstore. r=lina 2019-07-23 00:13:43 +00:00
taskcluster Bug 1573355 - Fix openh264 builds. r=Callek 2019-08-13 04:59:49 +00:00
testing Bug 1573038 - Update test expectation for release or beta. r=jgraham 2019-08-13 05:44:43 +00:00
third_party Bug 1573039 - Part 2: Revendor dependencies. r=emilio 2019-08-12 12:39:47 +00:00
toolkit Bug 1376932 webrequest onHeadersReceived modification test r=robwu 2019-08-12 21:02:22 +00:00
tools Bug 1542004 - Add `android-javadoc` lint. r=agi 2019-08-13 01:45:03 +00:00
uriloader Bug 1570369 - Part 9: Use IPDL refcounted for PHandlerService, r=smaug 2019-08-08 16:46:42 +00:00
view Bug 1563139 - Remove StaticPrefs.h. r=glandium 2019-07-26 01:10:23 +00:00
widget Bug 1231213 - Various changes to existing tests. r=asuth 2019-08-13 04:04:58 +00:00
xpcom Bug 1572565 - Make the remote sandbox broker process' telemetry string consistent r=jld 2019-08-09 00:03:33 +00:00
xpfe/appshell Bug 1551344 - Part 2: Update outdated comments referencing XULDocument. r=smaug 2019-08-09 17:47:41 +00:00
.arcconfig
.clang-format Bug 1547143 - Force the pointer style declaration r=Ehsan 2019-05-01 08:46:08 +00:00
.clang-format-ignore Bug 1563903 - Remove libmar from the clang ignore list r=Ehsan 2019-07-08 15:39:24 +00:00
.cron.yml Bug 1568232 - Run raptor cold page-load test job on fenix and refbrow. r=perftest-reviewers,davehunt 2019-07-31 16:31:42 +00:00
.eslintignore Bug 1571934 - Inline security-prefs.js into all.js. r=keeler 2019-08-07 17:41:22 +00:00
.eslintrc.js Bug 1564555 - Enable some more ESLint rules for layout. r=Standard8,dholbert 2019-07-18 21:00:21 +00:00
.flake8 Bug 1542963 - Fix most flake8 issues in python/mozbuild/mozbuild/* r=firefox-build-system-reviewers,chmanchester 2019-05-28 14:22:20 +00:00
.gdbinit
.gdbinit_python Bug 1564314 - Move gdbpp back to python/. r=nalexander 2019-07-11 02:39:31 +00:00
.git-blame-ignore-revs Bug 1572125 - Update .hg-annotate-ignore-revs and .git-blame-ignore-revs to ignore devtools/client/responsive reformatting using Prettier (Bug 1569574) in blame/annotate. r=vporof 2019-08-12 17:27:22 +00:00
.gitattributes Bug 770286: Prevent git LF-to-CRLF autoconversion r=glandium 2019-07-06 02:36:03 +00:00
.gitignore Bug 1559479 - mach lint complains about newtab node_modules r=dmose 2019-07-12 15:24:07 +00:00
.hg-annotate-ignore-revs Bug 1572125 - Update .hg-annotate-ignore-revs and .git-blame-ignore-revs to ignore devtools/client/responsive reformatting using Prettier (Bug 1569574) in blame/annotate. r=vporof 2019-08-12 17:27:22 +00:00
.hg-format-source Bug 1556393 - Pre 1 (m-c): Update .hg-format-source to use Prettier when running format-source, r=andi, CLOSED TREE 2019-07-03 20:48:37 +02:00
.hgignore Bug 1559479 - mach lint complains about newtab node_modules r=dmose 2019-07-12 15:24:07 +00:00
.hgtags No bug - Tagging mozilla-central e596664275d5e3e2fdcb7fa8d1447289f99269c3 with FIREFOX_NIGHTLY_69_END a=release DONTBUILD CLOSED TREE 2019-07-08 16:13:40 +00:00
.lldbinit
.mailmap
.prettierignore Bug 1572582 - Merge healthreport-prefs.js into all.js. r=chutten 2019-08-11 23:31:30 +00:00
.prettierrc Bug 1551218 - Part 3: Add a top-level .prettierrc and reformat the debugger, r=jlast 2019-05-17 15:51:36 +00:00
.taskcluster.yml Bug 1459355: Don't pass parameters as part of actions; r=dustin 2019-08-09 17:02:15 +00:00
.trackerignore
.yamllint
.ycm_extra_conf.py
AUTHORS
CLOBBER Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-07-08 17:27:36 +00:00
Cargo.lock Bug 1573039 - Part 1: Update image to 0.22. r=emilio 2019-08-12 20:22:06 +00:00
Cargo.toml Bug 1571464: Bump Cranelift to c927680fd42a56efcc9a5ee59e814d9eef6c5b4f; r=jseward 2019-08-07 14:20:48 +00:00
GNUmakefile
LEGAL
LICENSE
Makefile.in Bug 1570798 - Restore relative path for MOZ_FETCHES_DIR. r=nalexander 2019-08-03 07:08:39 +09:00
README.txt
aclocal.m4 Bug 1557583 - Add a --enable-frame-pointers option. r=chmanchester 2019-06-12 22:30:46 +00:00
build.gradle Bug 1571288 - Fix gradle warnings about obsolete APIs. r=nalexander 2019-08-12 15:18:23 +00:00
client.mk
client.py
configure.in
configure.py Bug 1559975 - Make configure.py lint with 'py2' and 'py3' r=catlee 2019-07-08 17:34:09 +00:00
gradle.properties
gradlew
gradlew.bat
mach
moz.build Bug 1560425 - Remove old performance measurement API r=jorendorff 2019-07-02 14:37:17 +00:00
moz.configure Bug 1560340 - Only add confvars.sh as a dependency to config.status when it exists. r=chmanchester 2019-06-20 18:43:25 +00:00
mozilla-config.h.in
old-configure.in Bug 1569330 - Disable telemetry check in Normandy recipe runner r=mythmon,nalexander 2019-08-06 23:54:34 +00:00
package-lock.json Bug 1567134 - Update the node modules packages for the builders. r=ahal 2019-07-18 13:10:40 +00:00
package.json Bug 1564138 - Fix DevTools PropTypes errors when updating eslint. r=Ola. 2019-07-17 10:35:44 +00:00
settings.gradle Bug 1543982 - Part 1: Avoid re-configuring from within Gradle. r=emilio 2019-05-09 20:38:48 +00:00
test.mozbuild

README.txt

An explanation of the Mozilla Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure

For information on how to build Mozilla from the source code, see:

    https://developer.mozilla.org/en/docs/Build_Documentation

To have your bug fix / feature added to Mozilla, you should create a patch and
submit it to Bugzilla (https://bugzilla.mozilla.org). Instructions are at:

    https://developer.mozilla.org/en/docs/Creating_a_patch
    https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

If you have a question about developing Mozilla, and can't find the solution
on https://developer.mozilla.org, you can try asking your question in a
mozilla.* Usenet group, or on IRC at irc.mozilla.org. [The Mozilla news groups
are accessible on Google Groups, or news.mozilla.org with a NNTP reader.]

Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Mozilla developers for
testing, may be buggy.