gecko-dev/dom/smil
Emilio Cobos Álvarez a1f03332c2 Bug 1486488 - Don't assume that SVGAnimationElement has a parent on bind. r=dholbert
This is a regression from bug 1450250, which removed a if (!GetCx()) early
return in this function.

That early return was wrong, both because it prevented elements that were in
shadow trees from targeting other elements, but also because that check was not
present in AfterSetAttr, which means that dynamic updates to the attribute would
work.

Pass the SVGAnimationElement itself to resolve references. That's what we do for
attribute mutations, and also it's the same behavior we have, since the ID
lookup IDTracker does only depends on containing shadow root and containing
document, and that's invariant between a kid and it's DOM parent.

Some other code has been updated to take references instead of pointers so the
null-safety of those methods is explicit.

Differential Revision: https://phabricator.services.mozilla.com/D4349

--HG--
extra : moz-landing-system : lando
2018-08-28 09:06:08 +00:00
..
crashtests
test Bug 1471814 - Add a preference for {Document,Element}.getAnimations(); r=bz,hiro 2018-07-14 09:23:03 +09:00
SMILBoolType.cpp Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
SMILBoolType.h
SMILEnumType.cpp Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
SMILEnumType.h
SMILIntegerType.cpp Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
SMILIntegerType.h
SMILStringType.cpp Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
SMILStringType.h
TimeEvent.cpp
TimeEvent.h Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot 2018-06-26 17:05:01 -07:00
moz.build Bug 1458458: Move setting SMIL override values into nsDOMCSSAttrDeclaration. r=hiro 2018-05-02 18:09:05 +02:00
nsISMILAttr.h
nsISMILType.h
nsSMILAnimationController.cpp Bug 1447827: Remove ServoRestyleManager. r=xidorn 2018-04-07 15:50:06 +02:00
nsSMILAnimationController.h Bug 1448688: Remove RestyleTracker, ComputedStyle::AsServo, old style system element bits. r=xidorn 2018-03-26 09:38:07 +02:00
nsSMILAnimationFunction.cpp Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj 2018-06-17 22:43:11 -07:00
nsSMILAnimationFunction.h
nsSMILCSSProperty.cpp Bug 1458580 - Rename GetSMILStyleOverride since it can't return null. r=emilio 2018-05-25 12:12:37 +02:00
nsSMILCSSProperty.h Bug 1447828 part 8 - Remove remaining uses of StyleBackendType as well as the type itself. r=emilio 2018-03-29 02:34:34 +11:00
nsSMILCSSValueType.cpp Bug 1450250: SMIL document-related fixes. r=heycam 2018-07-20 14:44:47 +02:00
nsSMILCSSValueType.h Bug 1458814: Remove code that is no longer called. r=hiro 2018-05-05 16:31:20 +02:00
nsSMILCompositor.cpp Bug 1479450: Implement nsCSSProps::LookupProperty using Rust. r=xidorn 2018-07-31 12:00:15 +02:00
nsSMILCompositor.h Backed out changeset 9035ff3757ac (bug 1415980) at request from froydnj on the suspicion that it's going to break MSVC builds when it gets merged to central. 2018-07-31 01:19:49 +03:00
nsSMILCompositorTable.h
nsSMILFloatType.cpp Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj 2018-04-28 12:50:58 -07:00
nsSMILFloatType.h
nsSMILInstanceTime.cpp
nsSMILInstanceTime.h
nsSMILInterval.cpp
nsSMILInterval.h
nsSMILKeySpline.cpp
nsSMILKeySpline.h Bug 1453795 - SVG - Initialize member fields in classes/ structures. r=jwatt 2018-06-16 13:54:44 +03:00
nsSMILMilestone.h
nsSMILNullType.cpp Bug 1469769 - Part 6: Replace non-failing NS_NOTREACHED with MOZ_ASSERT_UNREACHABLE. r=froydnj 2018-06-17 22:43:11 -07:00
nsSMILNullType.h
nsSMILParserUtils.cpp
nsSMILParserUtils.h
nsSMILRepeatCount.cpp
nsSMILRepeatCount.h
nsSMILSetAnimationFunction.cpp
nsSMILSetAnimationFunction.h
nsSMILTargetIdentifier.h
nsSMILTimeContainer.cpp
nsSMILTimeContainer.h
nsSMILTimeValue.cpp
nsSMILTimeValue.h
nsSMILTimeValueSpec.cpp Bug 1486488 - Don't assume that SVGAnimationElement has a parent on bind. r=dholbert 2018-08-28 09:06:08 +00:00
nsSMILTimeValueSpec.h Bug 1486488 - Don't assume that SVGAnimationElement has a parent on bind. r=dholbert 2018-08-28 09:06:08 +00:00
nsSMILTimeValueSpecParams.h
nsSMILTimedElement.cpp Bug 1486488 - Don't assume that SVGAnimationElement has a parent on bind. r=dholbert 2018-08-28 09:06:08 +00:00
nsSMILTimedElement.h Bug 1486488 - Don't assume that SVGAnimationElement has a parent on bind. r=dholbert 2018-08-28 09:06:08 +00:00
nsSMILTypes.h
nsSMILValue.cpp Bug 1453795 - SVG - Initialize member fields in classes/ structures. r=jwatt 2018-06-16 13:54:44 +03:00
nsSMILValue.h