gecko-dev/security/nss
J.C. Jones 66170e3716 Bug 1564499 - land NSS bbfc55939d75 UPGRADE_NSS_RELEASE, r=kjacobs
Revset: reverse(89aa19677e37~-1::bbfc55939d75)

2019-08-14  Kevin Jacobs  <kjacobs@mozilla.com>

	* gtests/ssl_gtest/tls_agent.cc:
	Bug 1572593 - Re-revert call to CheckCertReqAgainstDefaultCAs to
	avoid memory leak (filed as bug 1573945). r=jcj

	Revert back to the changes Franziskus had made. Updated the in-
	source bug number to point to the new memleak bug.

	Differential Revision:
	https://phabricator.services.mozilla.com/D42020
	[bbfc55939d75] [tip]

2019-08-12  Kevin Jacobs  <kjacobs@mozilla.com>

	* gtests/freebl_gtest/freebl_gtest.gyp,
	gtests/mozpkix_gtest/mozpkix_gtest.gyp:
	Bug 1415118 - Fix --enable-libpkix builds from build.sh r=mt,jcj

	Differential Revision:
	https://phabricator.services.mozilla.com/D41617
	[f8926908be71]

2019-08-14  J.C. Jones  <jjones@mozilla.com>

	* gtests/ssl_gtest/tls_agent.cc, lib/ssl/ssl3ext.c:
	Bug 1572593 - Reset advertised extensions in ssl_ConstructExtensions
	r=mt,kjacobs

	Reset the list of advertised extensions before sending a new set.

	This reverts the changes of https://hg.mozilla.org/projects/nss/rev/
	1ca362213631d6edc885b6b965b52ecffcf29afd

	Differential Revision:
	https://phabricator.services.mozilla.com/D41302
	[b03ff661491e]

2019-08-14  Kevin Jacobs  <kjacobs@mozilla.com>

	* lib/freebl/ctr.c:
	Bug 1539788 - UBSAN fixup for 128b counter. r=mt,jcj

	Differential Revision:
	https://phabricator.services.mozilla.com/D41884
	[9d1f5e71773d]

2019-08-13  Kevin Jacobs  <kjacobs@mozilla.com>

	* lib/freebl/chacha20poly1305.c, lib/freebl/ctr.c, lib/freebl/gcm.c,
	lib/freebl/intel-gcm-wrap.c, lib/freebl/rsapkcs.c:
	Bug 1539788 - Add length checks for cryptographic primitives
	r=mt,jcj

	This patch adds additional length checks around cryptographic
	primitives.

	Differential Revision:
	https://phabricator.services.mozilla.com/D36079
	[dfd6996fe742]

2019-08-13  Marcus Burghardt  <mburghardt@mozilla.com>

	* gtests/freebl_gtest/mpi_unittest.cc, lib/freebl/mpi/README,
	lib/freebl/mpi/mpi.c, lib/freebl/mpi/mpi.h:
	Bug 1542077 - Added extra controls and tests to mp_set_int and
	mp_set_ulong. r=jcj,kjacobs

	Differential Revision:
	https://phabricator.services.mozilla.com/D40649
	[9bc47e69613e]

2019-08-13  J.C. Jones  <jjones@mozilla.com>

	* gtests/ssl_gtest/ssl_resumption_unittest.cc,
	gtests/ssl_gtest/tls_agent.cc:
	Bug 1572791 - Fixup clang-format r=bustage
	[ec113de50cdd]

	* gtests/ssl_gtest/tls_agent.cc,
	gtests/ssl_gtest/tls_subcerts_unittest.cc, lib/ssl/tls13subcerts.c:
	Bug 1572791 - Check for nulls in SSLExp_DelegateCredential and its
	tests r=kjacobs

	This particularly catches test errors in tls_subcerts_unittest when
	the profile is stale.

	Differential Revision:
	https://phabricator.services.mozilla.com/D41429
	[ed5067857563]

2019-08-13  Kevin Jacobs  <kjacobs@mozilla.com>

	* gtests/ssl_gtest/ssl_auth_unittest.cc,
	gtests/ssl_gtest/ssl_cert_ext_unittest.cc,
	gtests/ssl_gtest/ssl_resumption_unittest.cc,
	gtests/ssl_gtest/tls_agent.cc:
	Bug 1572791 - Fix ASAN cert errors when SSL gtests run on empty
	profile r=jcj

	Differential Revision:
	https://phabricator.services.mozilla.com/D41787
	[cef2aa7f3b8c]

2019-08-09  Kevin Jacobs  <kjacobs@mozilla.com>

	* tests/common/cleanup.sh:
	Bug 1560593 - Cleanup.sh to treat core dumps as test failures on
	optimized builds. r=jcj

	Differential Revision:
	https://phabricator.services.mozilla.com/D41392
	[360010725fdb]

Differential Revision: https://phabricator.services.mozilla.com/D42139

--HG--
extra : moz-landing-system : lando
2019-08-15 16:06:15 +00:00
..
automation Bug 1564499 - land NSS 8c6fad5544a6 UPGRADE_NSS_RELEASE, r=me 2019-07-15 21:40:37 +00:00
cmd Bug 1564499 - land NSS 777b6070fe76 UPGRADE_NSS_RELEASE, r=me 2019-08-05 15:58:54 +00:00
coreconf Bug 1564499 - land NSS bbfc55939d75 UPGRADE_NSS_RELEASE, r=kjacobs 2019-08-15 16:06:15 +00:00
cpputil Bug 1564499 - land NSS a31fc0eefc4c UPGRADE_NSS_RELEASE, r=me 2019-07-23 19:31:53 +00:00
doc Bug 1550889 - land NSS d17569aa9d56 UPGRADE_NSS_RELEASE, r=me 2019-06-07 17:51:08 +00:00
fuzz Bug 1550889 - land NSS ec6843bc0ce7 UPGRADE_NSS_RELEASE, r=me 2019-05-21 20:39:24 +00:00
gtests Bug 1564499 - land NSS bbfc55939d75 UPGRADE_NSS_RELEASE, r=kjacobs 2019-08-15 16:06:15 +00:00
lib Bug 1564499 - land NSS bbfc55939d75 UPGRADE_NSS_RELEASE, r=kjacobs 2019-08-15 16:06:15 +00:00
nss-tool Bug 1488622 - land NSS 94bcc2706b98 UPGRADE_NSS_RELEASE, r=me 2018-10-01 07:44:32 -07:00
pkg
tests Bug 1564499 - land NSS bbfc55939d75 UPGRADE_NSS_RELEASE, r=kjacobs 2019-08-15 16:06:15 +00:00
.arcconfig Bug 1512719 - land NSS NSS_3_42_BETA2 UPGRADE_NSS_RELEASE, r=me 2019-01-25 23:38:02 +00:00
.clang-format
.gitignore
.sancov-blacklist Bug 1445731 - land NSS 3e452651e282 UPGRADE_NSS_RELEASE, r=me 2018-04-19 10:27:14 +02:00
.taskcluster.yml Bug 1564499 - land NSS 8c6fad5544a6 UPGRADE_NSS_RELEASE, r=me 2019-07-15 21:40:37 +00:00
COPYING
Makefile Bug 1550889 - land NSS NSS_3_45_BETA1 UPGRADE_NSS_RELEASE, r=me 2019-07-01 21:19:55 +00:00
TAG-INFO Bug 1564499 - land NSS bbfc55939d75 UPGRADE_NSS_RELEASE, r=kjacobs 2019-08-15 16:06:15 +00:00
build.sh Bug 1564499 - land NSS 8c6fad5544a6 UPGRADE_NSS_RELEASE, r=me 2019-07-15 21:40:37 +00:00
exports.gyp Bug 1488622 - land NSS 94bcc2706b98 UPGRADE_NSS_RELEASE, r=me 2018-10-01 07:44:32 -07:00
help.txt Bug 1564499 - land NSS 8c6fad5544a6 UPGRADE_NSS_RELEASE, r=me 2019-07-15 21:40:37 +00:00
mach Bug 1564499 - land NSS 777b6070fe76 UPGRADE_NSS_RELEASE, r=me 2019-08-05 15:58:54 +00:00
manifest.mn
nss.gyp Bug 1550889 - land NSS d17569aa9d56 UPGRADE_NSS_RELEASE, r=me 2019-06-07 17:51:08 +00:00
readme.md Bug 1470914, NSS 3.39 beta revision 4a086733554e UPGRADE_NSS_RELEASE r=me 2018-07-25 15:17:58 +02:00
trademarks.txt

readme.md

Network Security Services

Network Security Services (NSS) is a set of libraries designed to support cross-platform development of security-enabled client and server applications. NSS supports SSL v3-TLS 1.2 (experimental TLS 1.3), PKCS #5, PKCS#7, PKCS #11, PKCS #12, S/MIME, X.509 v3 certificates, and other security standards.

Getting started

In order to get started create a new directory on that you will be uses as your local work area, and check out NSS and NSPR. (Note that there's no git mirror of NSPR and you require mercurial to get the latest NSPR source.)

git clone https://github.com/nss-dev/nss.git
hg clone https://hg.mozilla.org/projects/nspr

NSS can also be cloned with mercurial

hg clone https://hg.mozilla.org/projects/nss

Building NSS

This build system is under development. It does not yet support all the features or platforms that NSS supports. To build on anything other than Mac or Linux please use the legacy build system as described below.

Build requirements:

After changing into the NSS directory a typical build is done as follows

./build.sh

Once the build is done the build output is found in the directory ../dist/Debug for debug builds and ../dist/Release for opt builds. Exported header files can be found in the include directory, library files in directory lib, and tools in directory bin. In order to run the tools, set your system environment to use the libraries of your build from the "lib" directory, e.g., using the LD_LIBRARY_PATH or DYLD_LIBRARY_PATH.

See help.txt for more information on using build.sh.

Building NSS (legacy build system)

After changing into the NSS directory a typical build of 32-bit NSS is done as follows:

make nss_build_all

The following environment variables might be useful:

  • BUILD_OPT=1 to get an optimised build

  • USE_64=1 to get a 64-bit build (recommended)

The complete list of environment variables can be found here.

To clean the build directory run:

make nss_clean_all

Tests

Setup

Make sure that the address $HOST.$DOMSUF on your computer is available. This is necessary because NSS tests generate certificates and establish TLS connections, which requires a fully qualified domain name. You can test this by calling ping $HOST.$DOMSUF. If this is working, you're all set. If it's not, set or export:

HOST=nss
DOMSUF=local

Note that you might have to add nss.local to /etc/hosts if it's not there. The entry should look something like 127.0.0.1 nss.local nss.

Running tests

Runnning all tests will take a while!

cd tests
./all.sh

Make sure that all environment variables set for the build are set while running the tests as well. Test results are published in the folder ../../test_results/.

Individual tests can be run with the NSS_TESTS environment variable, e.g. NSS_TESTS=ssl_gtests ./all.sh or by changing into the according directory and running the bash script there cd ssl_gtests && ./ssl_gtests.sh. The following tests are available:

cipher lowhash libpkix cert dbtests tools fips sdr crmf smime ssl ocsp merge pkits chains ec gtests ssl_gtests bogo policy

To make tests run faster it's recommended to set NSS_CYCLES=standard to run only the standard cycle.

Releases

NSS releases can be found at Mozilla's download server. Because NSS depends on the base library NSPR you should download the archive that combines both NSS and NSPR.

Contributing

Bugzilla is used to track NSS development and bugs. File new bugs in the NSS product.

A list with good first bugs to start with are listed here.

NSS Folder Structure

The nss directory contains the following important subdirectories:

  • coreconf contains the build logic.

  • lib contains all library code that is used to create the runtime libraries.

  • cmd contains a set of various tool programs that are built with NSS. Several tools are general purpose and can be used to inspect and manipulate the storage files that software using the NSS library creates and modifies. Other tools are only used for testing purposes.

  • test and gtests contain the NSS test suite. While test contains shell scripts to drive test programs in cmd, gtests holds a set of gtests.

A more comprehensible overview of the NSS folder structure and API guidelines can be found here.

NSS supports build configurations for FIPS-140 compliance, and alternative build configurations that disable functionality specific to FIPS-140 compliance.

This section documents the environment variables and build parameters that control these configurations.

Build FIPS startup tests

The C macro NSS_NO_INIT_SUPPORT controls the FIPS startup self tests. If NSS_NO_INIT_SUPPORT is defined, the startup tests are disabled.

The legacy build system (make) by default disables these tests. To enable these tests, set environment variable NSS_FORCE_FIPS=1 at build time.

The gyp build system by default disables these tests. To enable these tests, pass parameter --enable-fips to build.sh.

Building either FIPS compliant or alternative compliant code

The C macro NSS_FIPS_DISABLED can be used to disable some FIPS compliant code and enable alternative implementations.

The legacy build system (make) never defines NSS_FIPS_DISABLED and always uses the FIPS compliant code.

The gyp build system by default defines NSS_FIPS_DISABLED. To use the FIPS compliant code, pass parameter --enable-fips to build.sh.

Test execution

The NSS test suite may contain tests that are included, excluded, or are different based on the FIPS build configuration. To execute the correct tests, it's necessary to determine which build configuration was used.

The legacy build system (make) uses environment variables to control all aspects of the build configuration, including FIPS build configuration.

Because the gyp build system doesn't use environment variables to control the build configuration, the NSS tests cannot rely on environment variables to determine the build configuration.

A helper binary named nss-build-flags is produced as part of the NSS build, which prints the C macro symbols that were defined at build time, and which are relevant to test execution.