зеркало из https://github.com/mozilla/gecko-dev.git
Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
641b0f8465
The call to `cx->jobQueue->reset()` doesn't do anything that isn't also accomplished by the call to `fop->delete_(cx->jobQueue.ref())` two lines later. Since `cx->jobQueue` is a `ThreadData<PersistentRooted<JobQueue>*>`, the `PersistentRooted` actually owns the `JobQueue` (despite the field's name `ptr`), rather than holding a pointer to it, so deleting the `PersistentRooted` invokes the `JobQueue` destructor. In more detail: `JSContext::jobQueue` is a `ThreadData<PersistentRooted<JobQueue>*>`, so the call `cx->jobQueue->reset()` performs the following steps: - Call `ProtectedData::operator->`, obtaining a (const reference to a non-const) pointer `PersistentRooted<JobQueue>*`. - Call `PersistentRooted::reset`, which move-assigns a fresh `JobQueue` to the `ptr` member. Note that `PersistentRooted<JobQueue>::ptr` is a `JobQueue`, *not* a pointer. But the subsequent call to `fop->delete_(cx->jobQueue.ref())` will perform the following steps: - Call `ProtectedData::ref`, obtaining a (reference to a) `PersistentRooted<JobQueue>*` pointer. - Call `PersistentRooted<JobQueue>`'s destructor, which destructs `ptr`. Since `ptr` is a `JobQueue`, this calls the `JobQueue`'s destructor, safely freeing its resources. Differential Revision: https://phabricator.services.mozilla.com/D15120 --HG-- extra : moz-landing-system : lando |
||
|---|---|---|
| .cargo | ||
| .vscode | ||
| accessible | ||
| browser | ||
| build | ||
| caps | ||
| chrome | ||
| config | ||
| db | ||
| devtools | ||
| docshell | ||
| dom | ||
| editor | ||
| embedding | ||
| extensions | ||
| gfx | ||
| gradle/wrapper | ||
| hal | ||
| image | ||
| intl | ||
| ipc | ||
| js | ||
| layout | ||
| media | ||
| memory | ||
| mfbt | ||
| mobile | ||
| modules | ||
| mozglue | ||
| netwerk | ||
| nsprpub | ||
| other-licenses | ||
| parser | ||
| python | ||
| security | ||
| services | ||
| servo | ||
| startupcache | ||
| storage | ||
| taskcluster | ||
| testing | ||
| third_party | ||
| toolkit | ||
| tools | ||
| uriloader | ||
| view | ||
| widget | ||
| xpcom | ||
| xpfe/appshell | ||
| .arcconfig | ||
| .clang-format | ||
| .clang-format-ignore | ||
| .cron.yml | ||
| .eslintignore | ||
| .eslintrc.js | ||
| .flake8 | ||
| .gdbinit | ||
| .gdbinit_python | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .hg-annotate-ignore-revs | ||
| .hg-format-source | ||
| .hgignore | ||
| .hgtags | ||
| .lldbinit | ||
| .mailmap | ||
| .taskcluster.yml | ||
| .trackerignore | ||
| .yamllint | ||
| .ycm_extra_conf.py | ||
| AUTHORS | ||
| CLOBBER | ||
| Cargo.lock | ||
| Cargo.toml | ||
| GNUmakefile | ||
| LEGAL | ||
| LICENSE | ||
| Makefile.in | ||
| README.txt | ||
| aclocal.m4 | ||
| build.gradle | ||
| client.mk | ||
| client.py | ||
| configure.in | ||
| configure.py | ||
| gradle.properties | ||
| gradlew | ||
| mach | ||
| moz.build | ||
| moz.configure | ||
| mozilla-config.h.in | ||
| old-configure.in | ||
| package-lock.json | ||
| package.json | ||
| settings.gradle | ||
| test.mozbuild | ||
README.txt
An explanation of the Mozilla Source Code Directory Structure and links to
project pages with documentation can be found at:
https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure
For information on how to build Mozilla from the source code, see:
https://developer.mozilla.org/en/docs/Build_Documentation
To have your bug fix / feature added to Mozilla, you should create a patch and
submit it to Bugzilla (https://bugzilla.mozilla.org). Instructions are at:
https://developer.mozilla.org/en/docs/Creating_a_patch
https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree
If you have a question about developing Mozilla, and can't find the solution
on https://developer.mozilla.org, you can try asking your question in a
mozilla.* Usenet group, or on IRC at irc.mozilla.org. [The Mozilla news groups
are accessible on Google Groups, or news.mozilla.org with a NNTP reader.]
Nightly development builds can be downloaded from:
https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
- or -
https://www.mozilla.org/firefox/channel/desktop/#nightly
Keep in mind that nightly builds, which are used by Mozilla developers for
testing, may be buggy.