зеркало из https://github.com/mozilla/gecko-dev.git
5c0c6834f5
LUL::mAdminThreadId is used only to assert that certain calls into the LUL object are made on the correct thread. Because those assertions are done using MOZ_ASSERT, some compilers spot that LUL::mAdminThreadId is unused in non-debug builds, emit a warning to that effect, and then cause the build to fail due to the presence of -Werror. Given that (1) it's unlikely that people will use the profiler in debug builds, (2) failure of these assertions is likely to lead to deadlocking or crashing in the profiler, and (3) they don't occur on high-frequency paths, a good solution seems to be to convert them to MOZ_RELEASE_ASSERTs, hence causing LUL::mAdminThreadId to be used in even in non-debug builds. In some cases, related MOZ_ASSERTs relating to LUL::mAdminMode have also been upgraded to MOZ_RELEASE_ASSERTs, for consistency with the LUL::mAdminThreadId changes. --HG-- extra : rebase_source : 554a31060a828db01246ece6d1e3afbcc0b42cd2 |
||
|---|---|---|
| .. | ||
| core | ||
| gecko | ||
| lul | ||
| public | ||
| tasktracer | ||
| tests | ||
| moz.build | ||