gecko-dev/dom/bindings
Jason Orendorff 1def388b28 Bug 1142794 - Change 'receiver' argument to SetProperty functions and ProxyHandler::set methods to be a HandleValue. r=Waldo.
Also: Change signature of these functions and methods to all have the same arguments in the same order: (cx, obj, id, v, receiver). Also change v from MutableHandleValue to HandleValue.

There is no change in behavior.

In fact the new error message `JSMSG_SET_NON_OBJECT_RECEIVER` is
impossible to trigger from scripts for now, I think (after re-reading
the whole patch with this in mind). JS_ForwardSetPropertyTo is the only
way to get a non-object receiver into the engine, but no caller
currently does so.

We're installing new pipes here, and they should work, but for now it's
the same cold water flowing through as before. Actually hooking up the
hot water is left for another bug (one with tests, not to put too fine a
point on it).

Notes:

*   InvokeGetterOrSetter had to be split into two functions:
    InvokeGetter takes a MutableHandleValue out-param,
    InvokeSetter a HandleValue in-param.

*   Watchpoints can still tamper with values being assigned. So can
    JSSetterOps. I'm pleased we can support this craziness in a way that
    doesn't have to spread via the type system to encompass the entire
    codebase.

*   Change in GlobalObject::setIntrinsicValue is not really a change.
    Yes, it asserted before, but an exception thrown during self-hosting
    initialization is not going to go unnoticed either.

*   Since the receiver argument to js::SetProperty() is at the end now, it
    makes sense for it to be optional. Some callers look nicer.

--HG--
extra : rebase_source : e89f916fe267800bc73890e11aceef5c4855b272
2015-03-01 13:16:19 -06:00
..
crashtests Bug 1017424 part 1. Remove support for the dom.window_experimental_bindings preference. r=peterv 2014-09-05 14:28:44 -04:00
docs
mozwebidlcodegen Bug 1119652, create mozilla::dom::Event::As*Event automatically for all the codegen'ed Events and annotate As*Event with MOZ_OVERRIDE in the codegen, r=bz 2015-01-10 13:46:41 +02:00
parser Bug 1141858 - Fix error message for unexpected extended attribute on dictionary members. r=bzbarsky 2015-03-14 16:34:40 +11:00
test Bug 837630 - Stop hiding __proto__ from O.getOwnPropertyNames. r=Waldo,peterv,past 2015-03-19 17:42:15 +01:00
AtomList.h
BindingDeclarations.h Bug 1134112 part 1. When doing fast-init of a Web IDL dictionary, do fast-init of its dictionary members and its ancestors too. r=peterv 2015-02-19 14:36:26 -05:00
BindingUtils.cpp Bug 1142784, part 2 - Change ProxyHandler::defineProperty() to make the desc argument a non-mutable handle. r=Waldo. 2015-02-17 11:58:43 -06:00
BindingUtils.h Bug 1142784, part 2 - Change ProxyHandler::defineProperty() to make the desc argument a non-mutable handle. r=Waldo. 2015-02-17 11:58:43 -06:00
Bindings.conf Bug 1092102 - Implement WorkerDebuggerGlobalScope.reportError;r=khuey 2015-03-26 20:09:45 +01:00
CallbackFunction.h Bug 1105069 - Part 17: Convert xpc_IsGrayGCThing to GCCellPtr; r=mccr8, j=jonco 2014-12-05 09:38:34 -08:00
CallbackInterface.cpp Bug 1065811 - Expose isCallable()/isConstructor() in JS_PUBLIC_API. r=billm 2014-09-25 13:13:28 +02:00
CallbackInterface.h Bug 1019160 - part 4 - use jsids to access JS-implemented interface properties; r=bz 2014-06-05 14:47:13 -04:00
CallbackObject.cpp Bug 1092102 - Implement a WorkerDebuggerGlobalScope;r=khuey 2015-03-04 00:51:53 +01:00
CallbackObject.h Bug 1107953 part 1. Change the invariants around aCompartment in CallSetup to allow passing it even when the exception handling mode is eRethrowExceptions. r=bholley 2015-01-15 17:39:01 -05:00
Codegen.py Bug 1142794 - Change 'receiver' argument to SetProperty functions and ProxyHandler::set methods to be a HandleValue. r=Waldo. 2015-03-01 13:16:19 -06:00
Configuration.py Bug 928336. Make defining unforgeable properties on objects faster by just copying them from an unforgeable holder object. r=peterv 2015-03-03 21:01:58 -05:00
DOMJSClass.h Bug 787070 - Expandos on the xray of DOM prototypes should have effect on xrays of DOM nodes, make Xrays walk the prototype chain when resolving DOM properties. r=bholley. 2014-09-15 16:51:40 +02:00
DOMJSProxyHandler.cpp Bug 1142794 - Change 'receiver' argument to SetProperty functions and ProxyHandler::set methods to be a HandleValue. r=Waldo. 2015-03-01 13:16:19 -06:00
DOMJSProxyHandler.h Bug 1142794 - Change 'receiver' argument to SetProperty functions and ProxyHandler::set methods to be a HandleValue. r=Waldo. 2015-03-01 13:16:19 -06:00
DOMString.h Bug 1132655. Don't allow conversions from DOMString to const XPCOM string references, since it's meant to be an outparam only. r=smaug 2015-02-12 18:39:26 -05:00
Date.cpp Bug 857138 - Remove CheckedUnwrap in binding code. r=bz 2014-10-23 19:53:31 +02:00
Date.h Bug 1050611 - Fix more bad implicit constructors in dom and docshell; r=smaug 2014-08-08 09:49:39 -04:00
ErrorResult.h Bug 1122238 part 3. Drop all the DOMException-cloning and sanitization gunk we added in bug 1107592 and bug 1107953 and bug 1117242 . r=bholley 2015-03-06 01:08:06 -05:00
Errors.msg Bug 940273 - Part 4 - Initial implementation of Service Worker Cache. r=ehsan,baku,janv 2015-03-02 14:20:00 +01:00
Exceptions.cpp Bug 1147193. Go back to having our accessors on JSStackFrame infallible. r=bholley 2015-03-26 23:05:16 -04:00
Exceptions.h Bug 1121682 - fetch() should reject with TypeError 2015-01-14 13:43:27 -08:00
GenerateCSS2PropertiesWebIDL.py Bug 958887 part 4. Generate property accessors on the CSS2Properties interface for the dashed-named CSS properties and float that use their actual property names. r=peterv 2014-09-19 22:58:27 -04:00
JSSlots.h Bug 928336. Make defining unforgeable properties on objects faster by just copying them from an unforgeable holder object. r=peterv 2015-03-03 21:01:58 -05:00
Makefile.in Bug 1044657 - Move PYTHON_UNIT_TESTS to moz.build; r=mshal 2014-07-28 17:51:12 +02:00
MozMap.h Bug 1126593 - Add a global fallible instance, so that using fallible works directly, everywhere. r=njn 2015-02-02 09:56:13 +09:00
NonRefcountedDOMObject.h Bug 1096328 - Remove nativeOwnership from Bindings.conf, remove the now unused nativeOwnership property. r=bz. 2014-11-01 15:25:55 +01:00
Nullable.h Bug 1025173 - Nullable copy, move, and assignment should not transfer |mValue| if |mIsNull|. r=bz 2014-08-28 22:37:00 +02:00
OwningNonNull.h Bug 1035654 - Part 2: Add ImplCycleCollectionTraverse for OwningNonNull<T>. r=bzbarsky 2014-08-01 03:19:00 -04:00
PrimitiveConversions.h Bug 1112774 - Add a raft of other conversion methods to js/public/Conversions.h past just JS::ToObject. r=jorendorff 2014-12-17 13:50:20 -08:00
RootedDictionary.h Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj 2015-03-21 12:28:04 -04:00
StructuredClone.cpp Bug 1117172 part 2. Change the non-wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv 2015-03-19 10:13:32 -04:00
StructuredClone.h Bug 1043853 - Share the code for structured cloning of ImageData objects across main-thread and workers implementations; r=jst 2014-08-01 22:47:47 +02:00
ToJSValue.cpp Bug 742194 part 1. Add support for throwing uncatchable exceptions to Web IDL bindings. People keep asking for this. r=khuey 2015-02-20 23:58:36 -05:00
ToJSValue.h Bug 1095728 - Mark ToJSValue with MOZ_WARN_UNUSED_RESULT. r=bz 2014-12-09 14:45:00 -05:00
TypedArray.h Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj 2015-03-21 12:28:04 -04:00
UnionMember.h
mach_commands.py Bug 1050715 - Update the description of the various tests targed proposed by './mach help' r=jmaher 2014-08-09 15:37:29 +02:00
moz.build Bug 1123461 - Make a real interface for js/ipc (r=dvander) 2015-01-26 13:32:18 -08:00