Masayuki Nakano 32d89118c3 Bug 1420415 - TextEditor::CreateBRImpl() needs to make pointToInsertBrNode store mOffset before calling EditorBase::CreateNode() r=m_kato ... When TextEditor::CreateBRImpl() splits a text node before inserting new <br> element, it initializes pointToInsertBrNode only with the right text node. Then, it refers its Offset() after inserting new <br> node before the point. Therefore, the offset is computed with the new DOM tree. So, adding 1 to the offset is redundant only in this case. So, before calling CreateNode(), it needs to make pointToInsertBrNode store offset with calling its Offset(). Note that this ugly code will be replaced with patches for bug 1408227. Additionally, this doesn't use AutoEditorDOMPointChildInvalidator because it's not available in 58 but we need to uplift this patch. Finally, I'm not sure how to check this in automated tests. Therefore, this patch doesn't include automated tests. MozReview-Commit-ID: IaQBonoGawR --HG-- extra : rebase_source : a89559932f27d98a02baf3e207c6be3c2a545aad		2017-11-24 23:17:38 +09:00
..
crashtests	Bug 1415231 - Add crash tests for a regression of bug 1406482 which has been fixed by bug 1415509 r=m_kato	2017-11-10 10:58:33 +09:00
tests	Bug 748315 - Part 5. Update browserscope test result. r=masayuki	2017-10-25 16:13:10 +09:00
CSSEditUtils.cpp	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
CSSEditUtils.h	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
ChangeAttributeTransaction.cpp	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
ChangeAttributeTransaction.h	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
ChangeStyleTransaction.cpp	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
ChangeStyleTransaction.h	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
CompositionTransaction.cpp	…
CompositionTransaction.h	…
CreateElementTransaction.cpp	Bug 1415445 - part 1: CreateElementTransaction should use EditorRawDOMPoint and RangeBoundary r=m_kato	2017-11-08 16:49:06 +09:00
CreateElementTransaction.h	Bug 1415445 - part 1: CreateElementTransaction should use EditorRawDOMPoint and RangeBoundary r=m_kato	2017-11-08 16:49:06 +09:00
DeleteNodeTransaction.cpp	…
DeleteNodeTransaction.h	…
DeleteRangeTransaction.cpp	Bug 1415414 - Make DeleteRangeTransaction::CreateTxnsToDeleteBetween() and DeleteRangeTransaction::CreateTxnsToDeleteContent() use RawRangeBoundary as their arguments r=m_kato	2017-11-08 15:01:23 +09:00
DeleteRangeTransaction.h	Bug 1415414 - Make DeleteRangeTransaction::CreateTxnsToDeleteBetween() and DeleteRangeTransaction::CreateTxnsToDeleteContent() use RawRangeBoundary as their arguments r=m_kato	2017-11-08 15:01:23 +09:00
DeleteTextTransaction.cpp	…
DeleteTextTransaction.h	…
EditActionListener.h	…
EditAggregateTransaction.cpp	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
EditAggregateTransaction.h	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
EditTransactionBase.cpp	…
EditTransactionBase.h	…
EditorBase.cpp	Bug 1413181 - part 10: Redesign EditorBase::SplitNodeDeep() r=m_kato	2017-11-16 12:09:57 +09:00
EditorBase.h	Bug 1413181 - part 10: Redesign EditorBase::SplitNodeDeep() r=m_kato	2017-11-16 12:09:57 +09:00
EditorCommands.cpp	…
EditorCommands.h	…
EditorController.cpp	…
EditorController.h	…
EditorDOMPoint.h	Bug 1413181 - part 11: Create AutoEditorDOMPointOffsetInvalidator stack class for automatically invalidate offset of EditorDOMPoint r=m_kato	2017-11-17 17:00:56 +09:00
EditorEventListener.cpp	Bug 1411612: Kill nsINode::eCONTENT. r=bz	2017-10-25 17:19:11 +02:00
EditorEventListener.h	…
EditorUtils.cpp	Bug 1414713 - EditorUtils::IsDescendantOf() should take EditorDOMPoint and EditorRawDOMPoint as out param r=catalinb,m_kato	2017-11-06 17:01:33 +09:00
EditorUtils.h	Bug 1413181 - part 13: HTMLEditRules::MaybeSplitAncestorsForInsert() should be able to return a DOM point in text node r=m_kato	2017-11-19 11:05:26 +09:00
EditorUtils.js	…
EditorUtils.manifest	…
HTMLAbsPositionEditor.cpp	…
HTMLAnonymousNodeEditor.cpp	Bug 1407924 - Avoid conversion from nsAtom to string if possible. r=masayuki	2017-10-12 16:28:28 +09:00
HTMLEditRules.cpp	Bug 1413181 - part 13: HTMLEditRules::MaybeSplitAncestorsForInsert() should be able to return a DOM point in text node r=m_kato	2017-11-19 11:05:26 +09:00
HTMLEditRules.h	Bug 1413181 - part 12: Redesign and rename HTMLEditRules::SplitAsNeeded() r=m_kato	2017-11-17 16:03:11 +09:00
HTMLEditUtils.cpp	Bug 1411687 - part 2: Rewrite the check to insert a <br> element in HTMLEditRules::WillInsertBreak() r=m_kato	2017-10-27 01:27:44 +09:00
HTMLEditUtils.h	Bug 1411687 - part 2: Rewrite the check to insert a <br> element in HTMLEditRules::WillInsertBreak() r=m_kato	2017-10-27 01:27:44 +09:00
HTMLEditor.cpp	Bug 1413181 - part 10: Redesign EditorBase::SplitNodeDeep() r=m_kato	2017-11-16 12:09:57 +09:00
HTMLEditor.h	Bug 1413181 - part 6: Rename mozilla::EditorBase::EmptyContainers enum class to mozilla::SplitAtEdges for making its values clearer r=m_kato	2017-11-13 14:35:16 +09:00
HTMLEditorDataTransfer.cpp	Bug 1413181 - part 10: Redesign EditorBase::SplitNodeDeep() r=m_kato	2017-11-16 12:09:57 +09:00
HTMLEditorEventListener.cpp	…
HTMLEditorEventListener.h	…
HTMLEditorObjectResizer.cpp	Bug 1408767 - HTMLEditor::MouseMove: Remove two unused variables r=m_kato	2017-10-15 19:32:43 +02:00
HTMLEditorObjectResizerUtils.h	…
HTMLInlineTableEditor.cpp	…
HTMLStyleEditor.cpp	Bug 1413181 - part 10: Redesign EditorBase::SplitNodeDeep() r=m_kato	2017-11-16 12:09:57 +09:00
HTMLTableEditor.cpp	Bug 1415062 - part 2: Editor should use Selection::Collapse(const RawRangeBoundary&) as far as possible r=m_kato	2017-11-07 19:50:25 +09:00
HTMLURIRefObject.cpp	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
HTMLURIRefObject.h	…
InsertNodeTransaction.cpp	Bug 1413253. Make sure to make it clear that we'd report a JS exception on the ErrorResult in InsertNodeTransaction::DoTransaction. r=peterv	2017-11-07 15:36:41 -05:00
InsertNodeTransaction.h	Backed out changeset d59889304b3f (bug 1408125) for asserting in clipboard test editor/libeditor/tests/test_bug1306532.html. r=backout on a CLOSED TREE	2017-10-14 00:05:15 +02:00
InsertTextTransaction.cpp	…
InsertTextTransaction.h	…
InternetCiter.cpp	…
InternetCiter.h	…
JoinNodeTransaction.cpp	…
JoinNodeTransaction.h	…
ManualNAC.h	…
PlaceholderTransaction.cpp	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
PlaceholderTransaction.h	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
SelectionState.cpp	Bug 1413181 - part 3: EditorBase::CreateTxnForSplitNode() and EditorBase::SplitNode() should take EditorRawDOMPoint to specify the start of right node r=m_kato	2017-11-12 11:30:30 +09:00
SelectionState.h	Bug 1413181 - part 3: EditorBase::CreateTxnForSplitNode() and EditorBase::SplitNode() should take EditorRawDOMPoint to specify the start of right node r=m_kato	2017-11-12 11:30:30 +09:00
SplitNodeTransaction.cpp	Bug 1413181 - part 2: SplitNodeTransaction should store start of existing right node with RangeBoundary r=m_kato	2017-11-12 09:27:19 +09:00
SplitNodeTransaction.h	Bug 1413181 - part 2: SplitNodeTransaction should store start of existing right node with RangeBoundary r=m_kato	2017-11-12 09:27:19 +09:00
StyleSheetTransactions.cpp	…
StyleSheetTransactions.h	…
TextEditRules.cpp	Bug 1415509 - part 2: EditorBase::InsertTextImpl() should take |const EditorRawDOMPoint&| argument as input and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument r=m_kato	2017-11-09 01:00:36 +09:00
TextEditRules.h	…
TextEditRulesBidi.cpp	…
TextEditUtils.cpp	…
TextEditUtils.h	…
TextEditor.cpp	Bug 1420415 - TextEditor::CreateBRImpl() needs to make pointToInsertBrNode store mOffset before calling EditorBase::CreateNode() r=m_kato	2017-11-24 23:17:38 +09:00
TextEditor.h	Backed out changeset febed94fa592 (bug 1408227) for asserting at editor/libeditor/EditorBase.cpp:2513 during execution of web-platform-test /editing/run/inserttext.html. r=backout on a CLOSED TREE	2017-10-13 19:48:22 +02:00
TextEditorDataTransfer.cpp	…
TextEditorTest.cpp	…
TextEditorTest.h	…
TypeInState.cpp	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
TypeInState.h	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
WSRunObject.cpp	Bug 1415509 - part 3: WSRunObject::InsertText() should take |const EditorRawDOMPoint&| as input argument and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument r=m_kato	2017-11-09 13:24:06 +09:00
WSRunObject.h	Bug 1415509 - part 3: WSRunObject::InsertText() should take |const EditorRawDOMPoint&| as input argument and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument r=m_kato	2017-11-09 13:24:06 +09:00
moz.build	Bug 1408544 - part 1: Reimplement EditorDOMPoint as a subclass of RangeBoundary r=catalinb,m_kato	2017-11-01 14:41:03 +09:00
nsIAbsorbingTransaction.h	Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.	2017-10-03 09:05:19 +11:00
nsIEditRules.h	…