gecko-dev/js
Nicholas Nethercote 6d93e1b2e4 Bug 1232224 - Streamline setting of compile warnings in configure.in. r=glandium,cpeterson.
The main changes are to the warnings, which are as follows.

- Kept -Wall.

- Part of -Wall or on by default; remove all mentions:
  * -Waddress
  * -Wchar-subscripts
  * -Wcomment
  * -Wconversion-null
  * -Wendif-labels
  * -Wenum-compare
  * -Wimplicit-function-declaration
  * -Wint-to-pointer-cast
  * -Wmissing-braces
  * -Wmultichar
  * -Wnonnull
  * -Wparentheses
  * -Wpointer-sign
  * -Wpointer-to-int-cast (C only)
  * -Wreorder
  * -Wreturn-type
  * -Wsequence-point
  * -Wsign-compare (C++ only)
  * -Wswitch
  * -Wtrigraphs
  * -Wuninitialized
  * -Wunknown-pragmas
  * -Wunused-label
  * -Wunused-value
  * -Wwrite-strings (C++ only)

- Part of -Wextra; kept where present, added where missing:
  * -Wempty-body
  * -Wignored-qualifiers (not added for C++ code; many fixes needed to enable)
  * -Wtype-limits

- Part of -pedantic; kept where present, added where missing:
  * -pointer-arith

- C++ only, kept:
  * -Wno-invalid-offsetof
  * -Woverloaded-virtual

- Clang-only, kept:
  * -Wnon-literal-null-conversion (affected by a clang bug; see the big comment
    in the code)
  * -Wrange-loop-analysis (C++ only)
  * -Wno-unused-local-typedef

- This no longer exists?  I kept it to be safe:
  * -Winline-new-delete

A consequence of this is that, when --enable-warnings-as-errors is on, in
directories which have ALLOW_COMPILER_WARNINGS specified we no longer have any
fatal warnings. (We previously did have all the explicitly-mentioned
-Werror=foo ones.) This is a sensible change; if we are going to allow warnings
in a directory we should allow all of them, not just some of them.

Other changes:

- Some C warnings incorrectly used the CXX macros. Fixes that.

- Moves comments about warnings closer to the lines where they are defined, to
  make it easier to keep the comments consistent with the code.

- Reorders things a little, e.g. so that all enabled warnings are before all
  disabled warnings.

The C and C++ warnings are now very similar, in both configure.in and
js/src/configure.in.

--HG--
extra : rebase_source : 6f8db0fecda1315504a29fbcafb6fdee3053d8a5
2015-12-16 18:39:50 -08:00
..
ductwork/debugger Bug 1125423 part 2 - Rename stopAtOuter argument to *Unwrap functions to stopAtWindowProxy. r=bz 2015-11-06 19:03:52 +01:00
examples Bug 863089 - replace Debugger.Script.getOffsetLine with getOffsetLocation; r=fitzgen 2015-10-22 09:35:00 +02:00
ipc Backed out 2 changesets (bug 1235598) for linux reftest bustage 2015-12-31 15:51:13 -08:00
public Backed out 2 changesets (bug 1235598) for linux reftest bustage 2015-12-31 15:51:13 -08:00
src Bug 1232224 - Streamline setting of compile warnings in configure.in. r=glandium,cpeterson. 2015-12-16 18:39:50 -08:00
xpconnect Backed out 2 changesets (bug 1235598) for linux reftest bustage 2015-12-31 15:51:13 -08:00