gecko-dev/mobile
Agi Sferro dce83ed0dd Bug 1542009 - Don't create a GeckoSession if there isn't one. r=geckoview-reviewers,esawin,snorp
This fixes a problem where Gecko would call Vsync even when the browser does
not have a surface attached to.

This can be triggered by attaching a GeckoView without a session and then
attaching a GeckoSession to the view. This causes GeckoView to create two
Windows, one of which never gets put in the background causing Gecko to think
the browser is still visible.

The GeckoSession should be cleaned up by the GC but this may take a long time.

To avoid this footgun we just don't create a GeckoSession when there isn't one
already attached to the GeckoView, logging a warning in case the embedder is
confused by the blank screen.

Differential Revision: https://phabricator.services.mozilla.com/D27366

--HG--
extra : moz-landing-system : lando
2019-04-15 17:14:46 +00:00
..
android Bug 1542009 - Don't create a GeckoSession if there isn't one. r=geckoview-reviewers,esawin,snorp 2019-04-15 17:14:46 +00:00
locales Bug 1523741 - Converting legacy aboutTelemetry to Fluent aboutTelemetry, r=jaws,flod,Gijs 2019-04-08 09:15:16 +00:00