gecko-dev/netwerk/system
Valentin Gosu d130f41722 Bug 1562388 - Remove legacy ICS handling from nsNotifyAddrListener r=mayhemer
This code was added in bug 465158 to deal with on-demand dial-up
connections. That scenario is hopefully not common anymore.
One benefit of the code was that it excludes network adapters
that share the computers network from being part of network
change notifications, network ID, etc. However, the code assumed
that only adapters with the address 192.168.0.1 would be a ICS
adapter, but trying to set up ICS on Windows 10 actually set the
LAN interface with 192.168.137.1 - so that assumption isn't
valid anymore. So the code is likely not even running for
adapters that are ICS. It may run for adapters which have the
IP 192.168.0.1, but probably that's quite rare as that's more
often a gateway IP than a client IP.

In any case, it's better to just get rid of it and if needed,
however unlikely, we'll replace it with a more modern API.

Depends on D52573

Differential Revision: https://phabricator.services.mozilla.com/D52574

--HG--
extra : moz-landing-system : lando
2019-11-12 18:21:48 +00:00
..
android Backed out changeset 6384318223b4 (bug 1588218) for Linting failure on mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java. CLOSED TREE 2019-11-11 23:16:27 +02:00
linux Backed out 2 changesets (bug 1589461, bug 1589447) for wpt failures on report-only-in-meta.sub.html 2019-10-29 19:05:09 +02:00
mac Bug 1589448 - Add network id changed event on MacOS r=dragana 2019-10-29 23:19:03 +00:00
netlink Bug 1593693 - nsINetworkLinkService.isLinkUp returns true when no network connection is available, r=valentin 2019-11-07 15:16:36 +00:00
win32 Bug 1562388 - Remove legacy ICS handling from nsNotifyAddrListener r=mayhemer 2019-11-12 18:21:48 +00:00
moz.build Bug 1561944 - Implement nsINetworkLinkService.networkID for Android r=valentin 2019-09-19 13:47:46 +00:00