gecko-dev/servo
Igor Matuszewski 17d094116c servo: Merge #19644 - Root sequence<any> params using CustomAutoRooter (from Xanewok:root-seq-any); r=jdm
<!-- Please describe your changes on the following line: -->

Attempt at https://github.com/servo/servo/issues/16678. At the moment this pulls an external [remove-handle-conv](https://github.com/Xanewok/rust-mozjs/tree/remove-handle-conv) branch for rust-mozjs (removing `FromJSValConvertible` implementation for `HandleValue` and adding one for `*mut JSObject`)

In short, this roots the `sequence<any>` and `sequence<object>` function arguments using `CustomAutoRooter` (introduced in https://github.com/servo/rust-mozjs/pull/382).

As per https://github.com/servo/servo/issues/16678#issuecomment-302224110 the underlying vector contains raw gc thing pointers instead of handles. To do that, this introduces new possible `isMember = "AutoRoot"` value in CodegenRust.py.
The rooted argument is passed to a function wrapped in a `CustomAutoRooterGuard` [RAII root guard](ed5e37a288/src/rust.rs (L586-L588)) (e.g. as `CustomAutoRooterGuard<Vec<JSVal>>`)

I felt quite out of my depth when trying to adapt CodegenRust.py code, so I'd appreciate any help with how can be done better/in a more clean manner.
Also the name `CustomAutoRooterGuard` is quite lengthy, so I'm also open to changing it (`AutoRoot`? `AutoRootGuard`?)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #16678  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 989d2fd53267d063212ef3b7b7f13f2402943c4a

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 1d2081536bfa13c32a50b4862abbe3a03f305da3
2018-01-05 14:02:53 -06:00
..
.cargo servo: Merge #19017 - Print the full path for errors occurring in the servo crate (from tigercosmos:test); r=jdm 2017-11-03 09:05:17 -05:00
components servo: Merge #19644 - Root sequence<any> params using CustomAutoRooter (from Xanewok:root-seq-any); r=jdm 2018-01-05 14:02:53 -06:00
docs servo: Merge #19116 - Fix dead link in COMMAND_LINE_ARGS.md (from servo:cla-doc-link); r=KiChjang 2017-11-04 15:58:27 -05:00
etc servo: Merge #19523 - Filter out failed test-perf runs (from asajeffrey:test-perf-filter-out-failed-tests); r=avadacatavra 2018-01-05 09:15:48 -06:00
ports servo: Merge #19667 - Revert #19666 since we do create NAC elements and expect them to be inline (from emilio:root-and-item); r=emilio 2017-12-31 10:01:58 -06:00
python servo: Merge #19586 - let mutation testing display diff if compilation fails (from tigercosmos:x1); r=jdm 2018-01-03 10:21:18 -06:00
resources servo: Merge #19640 - tests/net: Update testing cert (from emilio:testing-cert); r=emilio 2017-12-24 08:53:29 -06:00
support servo: Merge #18967 - Bump bitflags to 1.0 (from Eijebong:bitflags2.0); r=mbrubeck 2017-10-30 18:25:45 -05:00
tests servo: Merge #19640 - tests/net: Update testing cert (from emilio:testing-cert); r=emilio 2017-12-24 08:53:29 -06:00
.gitattributes
.gitignore servo: Merge #19232 - Update web-platform-tests (from jdm:updatewpt8); r=jdm 2017-11-15 23:53:19 -06:00
.hgignore
.mailmap
.taskcluster.yml servo: Merge #19591 - Actually run Taskcluster jobs on PRs (from aneeshusa:actually-trigger-taskcluster); r=edunham 2018-01-04 18:40:39 -06:00
.travis.yml servo: Merge #19612 - deny warnings (from tigercosmos:o1); r=jdm 2017-12-21 13:57:04 -06:00
CLOBBER
CONTRIBUTING.md
Cargo.lock servo: Merge #19644 - Root sequence<any> params using CustomAutoRooter (from Xanewok:root-seq-any); r=jdm 2018-01-05 14:02:53 -06:00
Cargo.toml servo: Merge #19614 - Update WR (dual-source subpixel text optimizations, clip-out segment builder) (from glennw:update-wr-clip-out-seg); r=jdm 2018-01-05 02:34:38 -06:00
Info.plist
LICENSE
PULL_REQUEST_TEMPLATE.md
README.md servo: Merge #19701 - Update Arch Linux setup to include clang (from ntenczar:update-readme-clang); r=jdm 2018-01-05 13:01:28 -06:00
appveyor.yml servo: Merge #19612 - deny warnings (from tigercosmos:o1); r=jdm 2017-12-21 13:57:04 -06:00
dependencyci.yml servo: Merge #18903 - Don't report smallbitvec as an error (from servo:jdm-patch-2); r=emilio 2017-10-16 20:37:02 -05:00
mach
mach.bat servo: Merge #19324 - Get back to working dir after vcvarsall.bat (from drewler:fix_matchbat); r=jdm 2017-11-21 17:27:34 -06:00
moz.build servo: Merge #19041 - Bug 1411583 - servo directory in-tree has no BUGZILLA_COMPONENTS info… (from jmaher:mozbuild); r=jdm 2017-10-28 14:13:25 -05:00
rust-stable-version servo: Merge #19532 - Use Rust 1.22.1 for geckolib (from mbrubeck:rustup); r=SimonSapin 2017-12-09 01:14:02 -06:00
rust-toolchain servo: Merge #19574 - Downgrade to rustc nightly-2017-11-14 (from asajeffrey:rustdown-2017-11-14); r=glennw 2017-12-18 13:59:23 -06:00
rustfmt.toml servo: Merge #19681 - Format parts of layout (from pyfisch:rustfmt-display-lists); r=emilio 2018-01-03 19:49:02 -06:00
servo-tidy.toml servo: Merge #19559 - implement valid week string (from tigercosmos:t1); r=KiChjang 2017-12-17 03:50:33 -06:00
servobuild.example servo: Merge #19213 - Stop using "alternate" rustc builds (from servo:nightly); r=nox 2017-11-14 02:18:20 -06:00

README.md

The Servo Parallel Browser Engine Project

Linux Build Status Windows Build Status Changelog #228

Servo is a prototype web browser engine written in the Rust language. It is currently developed on 64-bit OS X, 64-bit Linux, 64-bit Windows, and Android.

Servo welcomes contribution from everyone. See CONTRIBUTING.md and HACKING_QUICKSTART.md for help getting started.

Visit the Servo Project page for news and guides.

Setting up your environment

Please select your operating system:

OS X

On OS X (homebrew)

brew install automake pkg-config python cmake yasm
pip install virtualenv

On OS X (MacPorts)

sudo port install python27 py27-virtualenv cmake yasm

On OS X >= 10.11 (El Capitan), you also have to install OpenSSL

brew install openssl

export OPENSSL_INCLUDE_DIR="$(brew --prefix openssl)/include"
export OPENSSL_LIB_DIR="$(brew --prefix openssl)/lib"

./mach build ...

If you've already partially compiled servo but forgot to do this step, run ./mach clean, set the shell variables, and recompile.

On Debian-based Linuxes

sudo apt install git curl freeglut3-dev autoconf libx11-dev \
    libfreetype6-dev libgl1-mesa-dri libglib2.0-dev xorg-dev \
    gperf g++ build-essential cmake virtualenv python-pip \
    libssl1.0-dev libbz2-dev libosmesa6-dev libxmu6 libxmu-dev \
    libglu1-mesa-dev libgles2-mesa-dev libegl1-mesa-dev \
    pulseaudio dbus-x11 libavcodec-dev libavformat-dev \
    libavutil-dev libswresample-dev  libswscale-dev libdbus-1-dev \
    libpulse-dev clang

If you using a version prior to Ubuntu 17.04 or Debian Sid, replace libssl1.0-dev with libssl-dev.

If you are on Ubuntu 14.04 and encountered errors on installing these dependencies involving libcheese, see #6158 for a workaround.

If virtualenv does not exist, try python-virtualenv.

On Fedora

sudo dnf install curl freeglut-devel libtool gcc-c++ libXi-devel \
    freetype-devel mesa-libGL-devel mesa-libEGL-devel glib2-devel libX11-devel libXrandr-devel gperf \
    fontconfig-devel cabextract ttmkfdir python python-virtualenv python-pip expat-devel \
    rpm-build openssl-devel cmake bzip2-devel libXcursor-devel libXmu-devel mesa-libOSMesa-devel \
    dbus-devel ncurses-devel pulseaudio-libs-devel clang clang-libs

On CentOS

sudo yum install curl freeglut-devel libtool gcc-c++ libXi-devel \
    freetype-devel mesa-libGL-devel mesa-libEGL-devel glib2-devel libX11-devel libXrandr-devel gperf \
    fontconfig-devel cabextract ttmkfdir python python-virtualenv python-pip expat-devel \
    rpm-build openssl-devel cmake3 bzip2-devel libXcursor-devel libXmu-devel mesa-libOSMesa-devel \
    dbus-devel ncurses-devel python34 pulseaudio-libs-devel clang clang-libs llvm-toolset-7

Build inside llvm-toolset and devtoolset:

scl enable devtoolset-7 llvm-toolset-7 bash

with the following environmental variables set:

export CMAKE=cmake3
export LIBCLANG_PATH=/opt/rh/llvm-toolset-7/root/usr/lib64

On openSUSE Linux

sudo zypper install libX11-devel libexpat-devel libbz2-devel Mesa-libEGL-devel Mesa-libGL-devel cabextract cmake \
    dbus-1-devel fontconfig-devel freetype-devel gcc-c++ git glib2-devel gperf \
    harfbuzz-devel libOSMesa-devel libXcursor-devel libXi-devel libXmu-devel libXrandr-devel libopenssl-devel \
    python-pip python-virtualenv rpm-build glu-devel llvm-clang libclang

On Arch Linux

sudo pacman -S --needed base-devel git python2 python2-virtualenv python2-pip mesa cmake bzip2 libxmu glu pkg-config clang

On Gentoo Linux

sudo emerge net-misc/curl media-libs/freeglut \
    media-libs/freetype media-libs/mesa dev-util/gperf \
    dev-python/virtualenv dev-python/pip dev-libs/openssl \
    x11-libs/libXmu media-libs/glu x11-base/xorg-server

On Windows (MSVC)

  1. Install Python for Windows (https://www.python.org/downloads/release/python-2714/). The Windows x86-64 MSI installer is fine. You should change the installation to install the "Add python.exe to Path" feature.

  2. Install virtualenv.

In a normal Windows Shell (cmd.exe or "Command Prompt" from the start menu), do:

pip install virtualenv

If this does not work, you may need to reboot for the changed PATH settings (by the python installer) to take effect.

  1. Install Git for Windows (https://git-scm.com/download/win). DO allow it to add git.exe to the PATH (default settings for the installer are fine).

  2. Install Visual Studio Community 2017 (https://www.visualstudio.com/vs/community/). You MUST add "Visual C++" to the list of installed components. It is not on by default. Visual Studio 2017 MUST installed to the default location or mach.bat will not find it.

If you encountered errors with the environment above, do the following for a workaround:

  1. Download and install Build Tools for Visual Studio 2017
  2. Install python2.7 x86-x64 and virtualenv
  3. Run mach.bat build -d.

If you have troubles with x64 type prompt as mach.bat set by default:

  1. you may need to choose and launch the type manually, such as x86_x64 Cross Tools Command Prompt for VS 2017 in the Windows menu.)
  2. cd to/the/path/servo
  3. python mach build -d

Cross-compilation for Android

Pre-installed Android tools are needed. See wiki for details

The Rust compiler

Servo's build system automatically downloads a Rust compiler to build itself. This is normally a specific revision of Rust upstream, but sometimes has a backported patch or two. If you'd like to know which nightly build of Rust we use, see rust-toolchain.

Building

Servo is built with Cargo, the Rust package manager. We also use Mozilla's Mach tools to orchestrate the build and other tasks.

Normal build

To build Servo in development mode. This is useful for development, but the resulting binary is very slow.

git clone https://github.com/servo/servo
cd servo
./mach build --dev
./mach run tests/html/about-mozilla.html

Or on Windows MSVC, in a normal Command Prompt (cmd.exe):

git clone https://github.com/servo/servo
cd servo
mach.bat build --dev

For benchmarking, performance testing, or real-world use, add the --release flag to create an optimized build:

./mach build --release
./mach run --release tests/html/about-mozilla.html

Checking for build errors, without building

If youre making changes to one crate that cause build errors in another crate, consider this instead of a full build:

./mach check

It will run cargo check, which runs the analysis phase of the compiler (and so shows build errors if any) but skips the code generation phase. This can be a lot faster than a full build, though of course it doesnt produce a binary you can run.

Building for Android target

git clone https://github.com/servo/servo
cd servo

export ANDROID_SDK="/path/to/sdk"
export ANDROID_NDK="/path/to/ndk"
export ANDROID_TOOLCHAIN="/path/to/toolchain"
export PATH="$PATH:/path/to/toolchain/bin"

./mach build --release --android
./mach package --release --android

Rather than setting the ANDROID_* environment variables every time, you can also create a .servobuild file and then edit it to contain the correct paths to the Android SDK/NDK tools:

cp servobuild.example .servobuild
# edit .servobuild

Running

Run Servo with the command:

./servo [url] [arguments] # if you run with nightly build
./mach run [url] [arguments] # if you run with mach

# For example
./mach run https://www.google.com

Also, don't miss the info on the browserhtml page on how to run the Browser.html full tech demo (it provides a more browser-like experience than just browsing a single URL with servo).

Commandline Arguments

  • -p INTERVAL turns on the profiler and dumps info to the console every INTERVAL seconds
  • -s SIZE sets the tile size for painting; defaults to 512
  • -z disables all graphical output; useful for running JS / layout tests
  • -Z help displays useful output to debug servo

Keyboard Shortcuts

  • Ctrl+- zooms out
  • Ctrl+= zooms in
  • Alt+left arrow goes backwards in the history
  • Alt+right arrow goes forwards in the history
  • Esc exits servo

Developing

There are lots of mach commands you can use. You can list them with ./mach --help.

The generated documentation can be found on http://doc.servo.org/servo/index.html