gecko-dev/widget
Toshihito Kikuchi 5a07f6187c Bug 1516423 - Clean up MessageData holding TaskbarWindowPreview when it's destroyed. r=cmartin
When `TaskbarWindowPreview` is constructed, it registers its adress in `WindowHook`
as a listener.  However, when an instance of `TaskbarWindowPreview` is destroyed,
it does not remove all listeners.  This emerges as Thunderbird's crash because TB
creates `TaskbarWindowPreview` to show a tray icon but the instance is accidentally
freed when the icon is still active due to another bug.  As a result, TB crashes
when `TaskbarPreview::MainWindowHook` tries to access a freed `TaskbarWindowPreview`
to handle a click on the icon.

This patch adds a call to `SetVisible(false)` in `TaskbarWindowPreview`'s dtor to
clean up the things.  This will stop the crash in TB, but TB's taskbar icon still
does not behave correctly because it accidentally disappears without crash.
We need an additional patch to fix it.

Differential Revision: https://phabricator.services.mozilla.com/D109720
2021-04-01 00:32:27 +00:00
..
android Bug 1701830 - Remove LookAndFeelCache. r=cmartin,geckoview-reviewers,mstange,esawin 2021-03-30 22:58:22 +00:00
cocoa Bug 1700148, add an appearance type that forces a dropshadow on menus on Windows, and uses SetWindowRgn to clip the popup to the border radius, r=tnikkel 2021-04-01 00:13:09 +00:00
crashtests
generic Bug 1657401 - Prelude: rearrange IPDL files in widget/. r=spohl 2020-11-11 23:17:40 +00:00
gtk Backed out changeset c83c9af968f8 (bug 1701182) for build bustages at system_wrappers/gdk/gdk.h on a CLOSED TREE 2021-03-31 19:33:47 +03:00
headless Bug 1701830 - Remove LookAndFeelCache. r=cmartin,geckoview-reviewers,mstange,esawin 2021-03-30 22:58:22 +00:00
reftests Bug 1699931 - A couple other fuzz tweaks. 2021-03-22 10:53:23 +01:00
tests Bug 1699792 - Fix a bug in the handling of dynamic collapsed/hidden attribute changes. r=harry 2021-03-23 13:40:24 +00:00
uikit Bug 1701830 - Remove LookAndFeelCache. r=cmartin,geckoview-reviewers,mstange,esawin 2021-03-30 22:58:22 +00:00
windows Bug 1516423 - Clean up MessageData holding TaskbarWindowPreview when it's destroyed. r=cmartin 2021-04-01 00:32:27 +00:00
x11 Bug 1654103: Standardize on Black for Python code in `mozilla-central`. 2020-10-26 18:34:53 +00:00
BasicEvents.h Bug 1689317 - Clipboard events should be composed. r=smaug 2021-01-29 13:30:40 +00:00
CommandList.h Bug 1357365 - part 3: Make `TypeInState::OnSelectionChange()` stop keeping link style if caret is positioned at edge of a link element and not moved in the link r=m_kato,edgar 2021-01-13 01:55:29 +00:00
CompositorWidget.cpp Bug 1678892 - Pass dirty and opaque regions to layers compositor. r=sotaro 2021-03-23 06:36:39 +00:00
CompositorWidget.h Bug 1690216 - Clarify that StartRemoteDrawingInRegion does not actually modify the region. r=mattwoodrow 2021-02-24 18:34:52 +00:00
ContentCache.cpp Bug 1683226 - part 4: Make stop `ContentCache` check whether a plugin has focus or not r=m_kato 2020-12-21 05:59:57 +00:00
ContentCache.h Bug 1678553 - part 12: Make `ContentCache` store character rects with `Maybe` r=m_kato 2020-11-27 14:48:03 +00:00
ContentEvents.h
EventClassList.h Bug 1683226 - part 16: Get rid of `WidgetPluginEvent` r=smaug 2020-12-29 21:19:45 +00:00
EventForwards.h Bug 1691622 - part 9: Make `nsIWidget::SynthesizeNativeMouseEvent` take an XP button ID and abstract message value r=smaug,geckoview-reviewers,agi,m_kato 2021-02-24 01:27:10 +00:00
EventMessageList.h Bug 1701789 - Restore UserProximityEvent r=smaug 2021-03-30 20:44:47 +00:00
FontRange.h
GfxDriverInfo.cpp Bug 1697577 - Let gen7lp WebRender ride into release. r=aosmond 2021-03-10 21:33:08 +00:00
GfxDriverInfo.h Bug 1690568 - Block WebRender on Linux with Mesa r600 driver if older than 17.3.0. r=jrmuizel 2021-02-03 16:00:47 +00:00
GfxInfoBase.cpp Bug 1696071 - Add support for DMABuf to the blocklist. r=rmader 2021-03-16 20:14:51 +00:00
GfxInfoBase.h Bug 1689945 - Update display info when WM_DISPLAYCHANGE happens r=jrmuizel 2021-02-04 23:25:35 +00:00
GfxInfoCollector.cpp
GfxInfoCollector.h
GfxInfoX11.cpp Bug 1701977 - Enable WR on Intel/AMD on Wayland, r=aosmond 2021-03-31 22:54:21 +00:00
GfxInfoX11.h Bug 1696937 [Linux] Remove wayland/drm info from about:support, r=jhorak 2021-03-08 21:26:19 +00:00
IMEData.cpp Bug 1683226 - part 11: Get rid of `IMEEnabled::Plugin` r=m_kato 2020-12-21 08:26:24 +00:00
IMEData.h Bug 1683226 - part 11: Get rid of `IMEEnabled::Plugin` r=m_kato 2020-12-21 08:26:24 +00:00
IconLoader.cpp Bug 1691861 - Remove unused mContentType fields. r=mconley 2021-02-12 00:32:06 +00:00
IconLoader.h Bug 1691861 - Remove unused mContentType fields. r=mconley 2021-02-12 00:32:06 +00:00
InProcessCompositorWidget.cpp Bug 1674142: Add additional checks to find a crash in InProcessCompositorWidget::PreRender. r=jrmuizel 2021-03-10 00:45:49 +00:00
InProcessCompositorWidget.h Bug 1674142: Add additional checks to find a crash in InProcessCompositorWidget::PreRender. r=jrmuizel 2021-03-10 00:45:49 +00:00
InputData.cpp Bug 1700819 - Avoid dispatching pinch gesture events with mLineOrPageDeltaY == 0. r=tnikkel 2021-03-27 23:29:19 +00:00
InputData.h Bug 1700819 - Avoid dispatching pinch gesture events with mLineOrPageDeltaY == 0. r=tnikkel 2021-03-27 23:29:19 +00:00
LSBUtils.cpp
LSBUtils.h
LookAndFeel.h Bug 1701830 - Remove LookAndFeelCache. r=cmartin,geckoview-reviewers,mstange,esawin 2021-03-30 22:58:22 +00:00
LookAndFeelTypes.ipdlh Bug 1701830 - Remove LookAndFeelCache. r=cmartin,geckoview-reviewers,mstange,esawin 2021-03-30 22:58:22 +00:00
MediaKeysEventSourceFactory.h Bug 1640998 - part9 : use `MediaControlKey` to replace `MediaControlKeysEvent` r=chunmin,agi,geckoview-reviewers 2020-06-09 02:59:57 +00:00
MiscEvents.h Bug 1683226 - part 16: Get rid of `WidgetPluginEvent` r=smaug 2020-12-29 21:19:45 +00:00
MouseEvents.h Bug 1701108 - Split this assertion up into three assertions that are easier to understand. r=masayuki 2021-03-26 02:06:53 +00:00
NativeKeyToDOMCodeName.h
NativeKeyToDOMKeyName.h
NativeMenu.h Bug 1702041 - Clear document.popupNode when a native menu closes. r=tnikkel 2021-03-31 17:41:56 +00:00
PluginWidgetProxy.cpp
PluginWidgetProxy.h
PrintBackgroundTask.h Bug 1660686: Add telemetry for time taken in print background tasks. r=jwatt, dr=tdsmith 2020-08-31 14:36:45 +00:00
PuppetBidiKeyboard.cpp
PuppetBidiKeyboard.h
PuppetWidget.cpp Bug 1689156 - Bring the fast tab switch paint back r=mstange,mattwoodrow 2021-03-22 20:49:04 +00:00
PuppetWidget.h Bug 1689156 - Bring the fast tab switch paint back r=mstange,mattwoodrow 2021-03-22 20:49:04 +00:00
RemoteLookAndFeel.cpp Bug 1701825 - Allow passing some colors from GTK even in dark themes. r=stransky 2021-03-30 08:17:38 +00:00
RemoteLookAndFeel.h Bug 1683204 - Include content theme configuration details in FullLookAndFeel. r=spohl 2020-12-22 19:26:41 +00:00
Screen.cpp
Screen.h
ScreenManager.cpp Bug 1696845 - Use dlsym for gdk_*_display_get_type. r=stransky 2021-03-11 14:32:53 +00:00
ScreenManager.h
ScrollbarDrawingMac.cpp Bug 1697240 - Refactor ScrollbarDrawingMac to not depend on a DrawTarget. r=mstange 2021-03-10 16:43:58 +00:00
ScrollbarDrawingMac.h Bug 1519636 - Reformat recent changes to the Google coding style r=andi 2021-03-15 08:45:29 +00:00
SharedWidgetUtils.cpp
SystemTimeConverter.h Bug 1626734 - Fix edge case that can cause TimeStamps to go backwards by fractional milliseconds. r=karlt 2020-05-07 12:56:09 +00:00
TextEventDispatcher.cpp Bug 1685491 - part 5: Move the code remapping arrow keys in vertical content to `NativeKeyBindings` r=smaug,jfkthame 2021-02-02 03:29:31 +00:00
TextEventDispatcher.h Bug 1685491 - part 5: Move the code remapping arrow keys in vertical content to `NativeKeyBindings` r=smaug,jfkthame 2021-02-02 03:29:31 +00:00
TextEventDispatcherListener.h
TextEvents.h Bug 1634281 - Use nsTHashMap instead of nsDataHashtable. r=xpcom-reviewers,necko-reviewers,jgilbert,nika,valentin 2021-03-10 10:47:47 +00:00
TextRange.h
ThemeChangeKind.h Bug 1668875 - Distinguish theme changes that can and cannot affect style/layout. r=tnikkel 2020-10-27 10:24:40 +00:00
TouchEvents.h Bug 1626570 - Improve handling of copying arrays in widget/. r=jhorak 2020-05-07 08:49:18 +00:00
TouchResampler.cpp Bug 1676771 - Add a TouchResampler class. r=kats 2020-11-18 03:57:35 +00:00
TouchResampler.h Bug 1676771 - Add a TouchResampler class. r=kats 2020-11-18 03:57:35 +00:00
VsyncDispatcher.cpp
VsyncDispatcher.h
WidgetEventImpl.cpp Bug 1701108 - Split this assertion up into three assertions that are easier to understand. r=masayuki 2021-03-26 02:06:53 +00:00
WidgetMessageUtils.h Bug 1640186 - Add machinery for sending native pinch gestures from a test, and a test which uses it r=botond 2021-02-19 05:35:40 +00:00
WidgetTraceEvent.h
WidgetUtils.cpp Bug 1686616 - make StringBundle use Components instead of Services. r=kmag 2021-02-18 13:26:32 +00:00
WidgetUtils.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
WindowSurface.h
WindowSurfaceX11SHM.cpp
WindowSurfaceX11SHM.h
moz.build Bug 1699792 - Split off the inner parts of nsStandaloneNativeMenu into a new class called NativeMenuMac. r=harry 2021-03-23 13:40:32 +00:00
nsAppShellSingleton.h
nsAutoRollup.cpp
nsAutoRollup.h
nsBaseAppShell.cpp
nsBaseAppShell.h
nsBaseClipboard.cpp
nsBaseClipboard.h
nsBaseDragService.cpp Bug 941356 - Fix start offset of transformed drag images. r=botond 2021-03-04 10:56:22 +00:00
nsBaseDragService.h
nsBaseFilePicker.cpp Bug 1686616 - make StringBundle use Components instead of Services. r=kmag 2021-02-18 13:26:32 +00:00
nsBaseFilePicker.h Bug 1634154. Make `widget/gtk` buildable outside of `unified-build` environment. r=karlt 2020-05-01 03:02:13 +00:00
nsBaseScreen.cpp
nsBaseScreen.h
nsBaseWidget.cpp Bug 1695162 - Use range-based for instead of custom hashtable iterators. r=xpcom-reviewers,kmag 2021-03-17 15:49:46 +00:00
nsBaseWidget.h Bug 1696802. Add test. r=botond,mstange 2021-03-12 02:10:43 +00:00
nsCUPSShim.cpp Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsCUPSShim.h Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsClipboardHelper.cpp Bug 1634154. Make `widget/gtk` buildable outside of `unified-build` environment. r=karlt 2020-05-01 03:02:13 +00:00
nsClipboardHelper.h
nsClipboardProxy.cpp
nsClipboardProxy.h
nsColorPickerProxy.cpp
nsColorPickerProxy.h
nsContentProcessWidgetFactory.cpp
nsDeviceContextSpecProxy.cpp Bug 1698235 - Add some error handling when using RemotePrintJobChild which may be destroyed. r=TYLin 2021-03-18 19:39:09 +00:00
nsDeviceContextSpecProxy.h
nsDragServiceProxy.cpp Bug 1641270 - Part 8: Make the Drag&Drop to use the correct cookieJarSettings to download the url. r=smaug,dimi 2020-11-11 11:14:05 +00:00
nsDragServiceProxy.h
nsFilePickerProxy.cpp Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
nsFilePickerProxy.h
nsGUIEventIPC.h Bug 1528289 - part 4: Prevent `click` event if APZC cancels autoscroll synchronously r=botond 2021-03-23 19:22:49 +00:00
nsHTMLFormatConverter.cpp Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 2020-07-01 08:29:29 +00:00
nsHTMLFormatConverter.h
nsIAppShell.idl
nsIApplicationChooser.idl
nsIBaseWindow.idl Bug 1653214 - Part 2: Remove nsIBaseWindow::Create; r=nika 2020-07-16 20:42:20 +00:00
nsIBidiKeyboard.idl
nsIClipboard.idl
nsIClipboardHelper.idl
nsIClipboardOwner.idl
nsIColorPicker.idl
nsIDeviceContextSpec.h Bug 1664258 - Increase the default PDF resolution for non-windows platforms. r=jwatt 2020-09-11 11:37:40 +00:00
nsIDisplayInfo.idl
nsIDragService.idl Bug 1641270 - Part 8: Make the Drag&Drop to use the correct cookieJarSettings to download the url. r=smaug,dimi 2020-11-11 11:14:05 +00:00
nsIDragSession.idl Bug 1650562: Add missing null check for document BrowsingContext. r=nika 2020-07-13 18:39:52 +00:00
nsIFilePicker.idl
nsIFormatConverter.idl
nsIGfxInfo.idl Bug 1696071 - Add support for DMABuf to the blocklist. r=rmader 2021-03-16 20:14:51 +00:00
nsIGfxInfoDebug.idl
nsIGtkTaskbarProgress.idl
nsIJumpListBuilder.idl
nsIJumpListItem.idl
nsIMacDockSupport.idl
nsIMacFinderProgress.idl
nsIMacSharingService.idl
nsIMacWebAppUtils.idl
nsIPaper.idl Bug 1662538 - patch 1 - Make nsIPaper expose a non-localizable .id in addition to a localizable .name attribute. r=jwatt 2020-09-17 20:05:08 +00:00
nsIPaperMargin.idl Bug 1655558 - Retrieve the paper margins lazily on Windows. r=jwatt,bobowen 2020-08-05 11:26:13 +00:00
nsIPluginWidget.h
nsIPrintDialogService.h
nsIPrintSession.idl
nsIPrintSettings.idl Bug 1692845 - Restore read from global print settings for a few settings, including print_bgcolor and print_bgimages. r=bobowen 2021-02-23 10:52:53 +00:00
nsIPrintSettingsService.idl Bug 1669723. Stop unnecessarily catching exceptions from nsIPrintSettingsService.lastUsedPrinterName. r=mstriemer 2020-10-09 10:21:44 +00:00
nsIPrintSettingsWin.idl Bug 1663940: Ensure the unwriteable margins are populated in the print settings. r=emilio 2020-09-11 15:00:18 +00:00
nsIPrinter.idl Bug 1663652 part 1 - Implement combined CreateDefaultSettings and GetPaperList interface for nsPrinterBase r=emilio,mstriemer 2020-11-03 20:35:38 +00:00
nsIPrinterList.idl Bug 1659807 - Add nsIPrinter.systemName and nsIPrinterList.getPrinterBySystemName r=emilio 2020-09-15 21:23:27 +00:00
nsIRollupListener.h Bug 1702041 - Call NativeMenu::Close() before firing the contextmenu event. r=harry 2021-03-31 17:41:56 +00:00
nsIScreen.idl
nsIScreenManager.idl
nsISharePicker.idl
nsISound.idl
nsIStandaloneNativeMenu.idl Bug 1699792 - Remove nativeData IDL property and use the NativeNSMenu() C++ method instead. r=harry 2021-03-23 13:40:24 +00:00
nsISystemStatusBar.idl
nsITaskbarOverlayIconController.idl
nsITaskbarPreview.idl
nsITaskbarPreviewButton.idl
nsITaskbarPreviewController.idl
nsITaskbarProgress.idl
nsITaskbarTabPreview.idl
nsITaskbarWindowPreview.idl
nsITouchBarHelper.idl
nsITouchBarInput.idl
nsITouchBarUpdater.idl
nsITransferable.idl Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug 2021-02-01 12:05:12 +00:00
nsIUserIdleService.idl Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp 2020-07-20 16:06:59 +00:00
nsIUserIdleServiceInternal.idl Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp 2020-07-20 16:06:59 +00:00
nsIWidget.h Bug 1700371: Update references for Mac OS X to macOS in nsIWidget.h. r=mstange 2021-03-31 16:38:10 +00:00
nsIWidgetListener.cpp Bug 1699506 - Part 1 - Add a NSTitlebarAccessoryViewController to ToolbarWindow to track when the titlebar is shown in fullscreen. r=mac-reviewers,mstange 2021-03-18 20:20:39 +00:00
nsIWidgetListener.h Bug 1699506 - Part 1 - Add a NSTitlebarAccessoryViewController to ToolbarWindow to track when the titlebar is shown in fullscreen. r=mac-reviewers,mstange 2021-03-18 20:20:39 +00:00
nsIWinTaskbar.idl
nsIWindowsUIUtils.idl
nsNativeBasicTheme.cpp Bug 1701825 - Minor scrollbar tweaks. r=stransky 2021-03-30 17:31:33 +00:00
nsNativeBasicTheme.h Bug 1701846 - Make setting overlay scrollbars on GTK do something sane-ish. r=mstange 2021-03-30 03:31:21 +00:00
nsNativeTheme.cpp Bug 1698821 - Simplify native-appearance-disabling for number spinners. r=dholbert 2021-03-16 21:53:20 +00:00
nsNativeTheme.h Bug 1615038: Fine-tune scrollbars in the non-native theme on Windows. r=emilio 2021-01-20 21:33:34 +00:00
nsPaper.cpp Bug 1662538 - patch 1 - Make nsIPaper expose a non-localizable .id in addition to a localizable .name attribute. r=jwatt 2020-09-17 20:05:08 +00:00
nsPaper.h Bug 1678374 - Avoid including js/RootingAPI.h from header files. r=jandem 2020-11-23 16:12:12 +00:00
nsPaperMargin.cpp Bug 1655558 - Retrieve the paper margins lazily on Windows. r=jwatt,bobowen 2020-08-05 11:26:13 +00:00
nsPaperMargin.h Bug 1655558 - Retrieve the paper margins lazily on Windows. r=jwatt,bobowen 2020-08-05 11:26:13 +00:00
nsPrimitiveHelpers.cpp
nsPrimitiveHelpers.h
nsPrintSession.cpp
nsPrintSession.h
nsPrintSettingsImpl.cpp Bug 1689789 part 2 - Use Ceil instead of Truncate the ensure the print surface is large enough for the requested paper size. r=jfkthame 2021-02-06 00:28:29 +00:00
nsPrintSettingsImpl.h Bug 1669854 - Add a single pageRanges print setting. r=nordzilla 2020-11-07 16:01:57 +00:00
nsPrintSettingsService.cpp Bug 1692845 - Restore read from global print settings for a few settings, including print_bgcolor and print_bgimages. r=bobowen 2021-02-23 10:52:53 +00:00
nsPrintSettingsService.h Bug 1667285. Make nsPrintSettingsService::_CreatePrintSettings pure virtual. r=bobowen 2020-09-25 09:33:14 +00:00
nsPrinterBase.cpp Bug 1663652 part 2 - Add combined printerInfo method to nsPrinterCUPS r=emilio 2020-11-03 20:35:38 +00:00
nsPrinterBase.h Bug 1663652 part 2 - Add combined printerInfo method to nsPrinterCUPS r=emilio 2020-11-03 20:35:38 +00:00
nsPrinterCUPS.cpp Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsPrinterCUPS.h Bug 1693395 - Add XROutputColor:PrintAsGrayscale to the grayscale values for CUPS. r=jfkthame 2021-02-18 05:18:38 +00:00
nsPrinterListBase.cpp Bug 1667486 part 1 - Make fallback paper sizes public to nsPaper, localize the sizes only once in nsPrinterListBase r=jwatt,emilio 2020-10-13 21:53:47 +00:00
nsPrinterListBase.h Bug 1660470 - Add missing include directives/forward declarations. r=nika 2020-11-23 16:21:38 +00:00
nsPrinterListCUPS.cpp Bug 1701019 - Add support for cups 1.6+ to the printing code. r=jwatt 2021-03-29 10:08:44 +00:00
nsPrinterListCUPS.h Bug 1683226 - part 14: Get rid of `ComplexTextInputPanel` r=m_kato 2020-12-24 02:49:02 +00:00
nsShmImage.cpp
nsShmImage.h
nsSoundProxy.cpp
nsSoundProxy.h
nsTransferable.cpp Bug 1641270 - Part 7: Add setter/getter of nsICookieJarSettings to nsITransferable. r=smaug 2020-11-11 11:14:07 +00:00
nsTransferable.h Bug 1641270 - Part 7: Add setter/getter of nsICookieJarSettings to nsITransferable. r=smaug 2020-11-11 11:14:07 +00:00
nsUserIdleService.cpp Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp 2020-07-20 16:06:59 +00:00
nsUserIdleService.h Bug 1651165 - Rename idle service r=Gijs,geckoview-reviewers,snorp 2020-07-20 16:06:59 +00:00
nsWidgetInitData.h Bug 1679087 - Remove ability to create non-Unicode widgets. r=mhowell 2020-12-17 18:21:39 +00:00
nsWidgetsCID.h Bug 1695873 - remove nativemenuservice remnants and fix macOS openedwithkey attribute use, r=mak,mstange 2021-03-04 22:54:23 +00:00
nsXPLookAndFeel.cpp Bug 1701830 - Remove LookAndFeelCache. r=cmartin,geckoview-reviewers,mstange,esawin 2021-03-30 22:58:22 +00:00
nsXPLookAndFeel.h Bug 1701830 - Remove LookAndFeelCache. r=cmartin,geckoview-reviewers,mstange,esawin 2021-03-30 22:58:22 +00:00