gecko-dev/accessible
James Teh ba7d805a62 Bug 1650590: A11y COM handler: Use CoTaskMemAlloc/Free for row/column header ids arrays when returned by IGeckoBackChannel::Refresh. r=MarcoZ
DynamicIA2Data can be built to be transmitted in two different ways:

1. As part of the payload included in the stream when an accessible is marshaled; or
2. As an out parameter returned by IGeckoBackChannel::Refresh().

DynamicIA2Data includes arrays for row/column header ids.
Normally, such arrays would be allocated by CoTaskMemAlloc and freed by CoTaskMemFree.
However, in the first case, the struct is actually marshaled by RPC encoding functions, not by COM itself.
This means we must use midl_user_allocate/free, lest we crash.
We previously used midl_user_allocate/free for the second case as well.
Unfortunately, it turns out that this too causes crashes.

To fix this, we now use different memory allocation functions depending on how the struct is transmitted.

This patch also cleans up the old DynamicIA2Data in the client before calling IGeckoBackChannel::Refresh.
Previously, we didn't do this, which would have resulted in a leak.

Differential Revision: https://phabricator.services.mozilla.com/D82823
2020-07-09 06:56:24 +00:00
..
android Bug 1649217 - Part 2: Send isSelectionCollapsed for caret move in IPC. r=Jamie 2020-07-02 18:08:52 +00:00
aom Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 2020-07-01 08:29:29 +00:00
atk Bug 1606721 - Fix crash on screen reader text requests with end offset smaller than -1, r=Jamie 2020-07-08 22:47:11 +00:00
base Bug 1226473 - Support AXSelectedTextMarkerRange. r=morgan 2020-07-06 17:32:45 +00:00
generic Bug 1649217 - Part 2: Send isSelectionCollapsed for caret move in IPC. r=Jamie 2020-07-02 18:08:52 +00:00
html Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 2020-07-01 08:29:29 +00:00
interfaces Bug 1649575 - Part 2: Wrap opaque NSObjects for testing. r=morgan 2020-07-02 21:24:39 +00:00
ipc Bug 1650590: A11y COM handler: Use CoTaskMemAlloc/Free for row/column header ids arrays when returned by IGeckoBackChannel::Refresh. r=MarcoZ 2020-07-09 06:56:24 +00:00
mac Backed out changeset 8d3a31f6fcd6 (bug 1643765) by morgan's request CLOSED TREE 2020-07-08 19:57:22 +03:00
other Bug 1649217 - Part 2: Send isSelectionCollapsed for caret move in IPC. r=Jamie 2020-07-02 18:08:52 +00:00
tests Bug 1648813 - disable browser_webarea.js on macos opt builds. r=jmaher 2020-07-07 14:05:52 +00:00
windows Bug 1648010 - Remove NS_NAMED_LITERAL_CSTRING and NS_NAMED_LITERAL_STRING macros. r=froydnj 2020-07-01 08:42:31 +00:00
xpcom Bug 1649575 - Part 2: Wrap opaque NSObjects for testing. r=morgan 2020-07-02 21:24:39 +00:00
xul Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 2020-07-01 08:29:29 +00:00
moz.build Bug 1630391: Add telemetry test for backplate and a11y theme scalars. r=chutten,yzen 2020-06-12 17:02:45 +00:00