gecko-dev/build
Chris Peterson 874e8bf033 Bug 1483761 - Enable clang's -Wfloat-(overflow|zero)-conversion warnings. r=glandium
-Wfloat-overflow-conversion detects when a constant floating point value is converted to an integer type and will overflow the target type.

https://clang.llvm.org/docs/DiagnosticsReference.html#wfloat-overflow-conversion

-Wfloat-zero-conversion detects when a non-zero floating point value is converted to a zero integer value.

https://clang.llvm.org/docs/DiagnosticsReference.html#wfloat-zero-conversion

There are currently no -Wfloat-overlap-conversion warnings in mozilla-central. There is one -Wfloat-zero-conversion warning in a webrtc test. It doesn't block enabling this check because the webrtc tests are not compiled with warnings-as-errors.

media/webrtc/trunk/webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller_unittest.cc:255:54 [-Wfloat-zero-conversion] implicit conversion from 'const float' to 'int' changes non-zero value from 0.045000002 to 0

We can't enable all -Wfloat-conversion warnings (for any implicit conversion of a floating-point number into an integer) because there are currently over 1400 warnings. I spot checked a few of these -Wfloat-conversion warnings. I didn't find any obvious bugs, but there is some suspicious code, such as implicit conversions of floats to bools.

Differential Revision: https://phabricator.services.mozilla.com/D3476

--HG--
extra : rebase_source : 589be9e593749c7000b1f89ca155e4f95a487f8f
2018-08-14 23:03:52 -07:00
..
autoconf Bug 1480558 - part 1 - set AS appropriately on aarch64 windows; r=mshal 2018-08-21 11:00:35 -04:00
build-clang Bug 1484888 - Apply upstream patch that fixes a clang crash with stack overflow on PGO + LTO on Linux. r=froydnj 2018-08-22 09:52:17 +09:00
build-infer Bug 1479401: Include lib directory into the infer tar, and change maintainer. r=andi 2018-07-30 12:45:02 +01:00
clang-plugin Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj 2018-07-31 22:10:07 +09:00
compare-mozconfig Bug 1471620 - Skip python-tests locally that don't run with python 3 in CI r=davehunt 2018-06-27 11:10:02 -04:00
debian-packages Bug 1479055 - Upgrade valgrind to current git trunk. r=froydnj 2018-08-14 07:25:08 +09:00
docs Bug 1473821 - The MOZ_PGO_INSTRUMENTED environment variable is not used anymore so remove all remaining mentions of it r=gps 2018-08-17 16:40:10 +00:00
gyp_includes Bug 1371485 - Remove OS X find_sdk.py check; r=chmanchester 2018-06-27 10:01:02 -04:00
macosx Bug 1429056 - Wrap llvm-dsymutil calls on automation. r=ted 2018-01-19 10:20:41 +09:00
mobile Bug 1482887 - Remote automation should kill already running instances rather than dying, r=gbrown. 2018-08-18 10:47:12 -07:00
moz.configure Bug 1483761 - Enable clang's -Wfloat-(overflow|zero)-conversion warnings. r=glandium 2018-08-14 23:03:52 -07:00
package/mac_osx
pgo bug 1463425 - Fix flake8/pep8 issue by hand in build/ r=gps 2018-05-21 23:58:19 +02:00
pymake
sanitizers Bug 1466722 - Remove remaining references to nsCSSRuleProcessor since it has been removed. r=heycam 2018-08-22 01:29:39 +00:00
sparse-profiles Bug 1468751 - Add images in documentation sparse checkout r=gps 2018-06-15 00:00:05 +00:00
tests/cram Bug 1411462 - Abort when I/O error seen; r=glandium 2017-11-09 20:44:10 -08:00
unix Bug 1484872 - Move LTO flags to python configure. r=froydnj 2018-08-21 08:40:26 +09:00
valgrind Bug 1485210 - Add --sym-offsets=yes to valgrind command line. r=njn 2018-08-22 13:44:38 +09:00
win32 Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj 2018-07-31 22:10:07 +09:00
win64 Bug 1475384: Use lld-link for official Windows builds. r=gps 2018-07-15 21:01:50 -04:00
.gdbinit_python.in Bug 1346025 - Move vendored python modules from /python to /third_party/python, r=ted 2017-05-25 11:48:03 -04:00
.lldbinit.in
__init__.py
appini_header.py Backed out changeset 602bdd9d5a96 (bug 1461851) for linting failures on /checkouts/gecko/build/appini_header.py on a CLOSED TREE 2018-05-30 19:03:50 +03:00
application.ini.in
automation.py.in Bug 1451159 - [testing/profiles] Store profile data in actual profile look alike folders r=gbrown 2018-04-19 16:12:26 -04:00
binary-location.mk
buildconfig.py Bug 1406650 - Make build/*.py and a few other files flake8 compatible and add them to the list of files to check r=chmanchester 2017-10-07 16:45:22 +02:00
cargo-linker Bug 1418598 - Make cargo-linker properly handle quoted strings in MOZ_CARGO_WRAP_LD and MOZ_CARGO_WRAP_LDFLAGS. r=ted 2017-11-18 20:24:12 +09:00
checksums.py Bug 1455143 - Refactor checksumming to occur after upload.py; r=ted 2018-04-18 16:24:03 -07:00
defines.sh
dumbmake-dependencies Bug 1363061 - Rename toolkit/components/jsdownloads to toolkit/components/downloads. r=mak 2018-03-06 17:40:59 +00:00
gecko_templates.mozbuild Backed out changeset d602a2f69ff8 (bug 1475573) on request from truber. a=backout 2018-08-16 17:49:01 +03:00
gen_automation.py Bug 1372381 - Generate automation.py with GENERATED_FILES rather than Makefile.in r=mshal 2018-04-30 11:08:59 -07:00
gen_symverscript.py Bug 1478499 - Move symbol version script generation for js shared library to moz.build. r=mshal 2018-08-01 13:25:38 -07:00
gen_test_backend.py
gen_test_packages_manifest.py Bug 1455872 - Build support for the new raptor performance framework; r=gps 2018-05-02 16:42:41 -04:00
genrc.sh
gn.mozbuild Backed out 5 changesets (bug 1393119) for bustage on linux in /builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers/alsa/asoundlib.h:3:15: alsa/asoundlib.h missing on a CLOSED TREE 2018-01-24 13:00:42 +02:00
gyp.mozbuild Bug 1478000 - nICEr and nrappkit should use the same warnings under clang-cl as with clang; r=dmajor 2018-07-25 14:02:02 -04:00
gyp_base.mozbuild Bug 1357323 - Remove support for gonk in the build system. r=gps 2017-04-18 16:56:09 +09:00
mach_bootstrap.py Bug 1257478 - Turn mercurial-setup into vcs-setup and add git support. r=gps 2018-07-04 21:48:42 +03:00
moz-automation.mk Bug 1455120 - Prefix output from automation tiers; r=mshal 2018-04-18 14:30:05 -07:00
moz.build Bug 1426176 - Add symbols file for Clang ASan runtime on Windows. r=ted 2018-07-26 11:16:50 +02:00
mozconfig.artifact Bug 1373150 - Disable compile environment on l10n builds. r=Callek 2017-06-15 15:06:45 +09:00
mozconfig.artifact.automation Bug 1412057 - Do not attempt to enable the clang plugin in mozconfigs during artifact builds on try. r=nalexander 2017-10-26 13:04:54 -07:00
mozconfig.automation Backed out 2 changesets (bug 1436662) for build bustages on /installer/windows. CLOSED TREE 2018-04-17 19:08:21 +03:00
mozconfig.cache Bug 1237182: get rid of oauth.txt r=mtabara 2018-05-25 17:43:15 -04:00
mozconfig.clang-cl Backed out changeset 7a3882f27aa3 (bug 1341525) for failing win Sa builds on a CLOSED TREE 2018-08-02 02:26:13 +03:00
mozconfig.comm-support Bug 1410475: Add support for detecting whether c-c is topdir in mozconfigs; r=mshal 2017-10-19 13:56:13 -06:00
mozconfig.common Bug 1468362: Remove ADDON_SINGING buildconfig setting. r=aswan 2018-06-12 13:56:58 -04:00
mozconfig.common.override
mozconfig.lld-link Bug 1444429: Add a build/mozconfig.lld-link for automation. r=froydnj DONTBUILD 2018-03-09 12:25:58 -05:00
mozconfig.no-compile Bug 1478813 - Auto-generate ServoStyleConsts. r=xidorn,ted 2018-08-17 19:48:23 +02:00
mozconfig.node Bug 1478995 - Add node toolchain path to automation mozconfigs, r=gps 2018-06-01 14:59:45 -07:00
mozconfig.rust Bug 1478813 - Auto-generate ServoStyleConsts. r=xidorn,ted 2018-08-17 19:48:23 +02:00
mozconfig.stylo Bug 1384258 - Build Stylo by default. r=chmanchester 2017-07-25 14:29:52 -07:00
mozconfig.vs-common
mozconfig.win-common Backed out 2 changesets (bug 1436662) for build bustages on /installer/windows. CLOSED TREE 2018-04-17 19:08:21 +03:00
qemu-wrap
rebuild-backend.mk
subconfigure.py Bug 1466401 - Re-run configure in js/src based on dependencies generated by python configure. r=mshal 2018-06-07 15:50:06 -07:00
submit_telemetry_data.py Bug 1406650 - Make build/*.py and a few other files flake8 compatible and add them to the list of files to check r=chmanchester 2017-10-07 16:45:22 +02:00
templates.mozbuild Backed out 2 changesets (bug 1474028) per chmanchester`s request. a=backout 2018-08-12 21:22:45 +03:00
test_templates.mozbuild
update-settings.ini
upload.py Bug 1455127 - Remove --package from upload.py; r=ted 2018-04-19 09:31:00 -07:00
upload_generated_sources.py Bug 1406650 - Make build/*.py and a few other files flake8 compatible and add them to the list of files to check r=chmanchester 2017-10-07 16:45:22 +02:00
variables.py Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood 2018-01-31 14:32:08 -05:00
virtualenv_packages.txt Bug 1476661 - Ensure H2 dependencies are packaged alongside wptserve where needed, r=jgraham 2018-08-09 11:38:37 +01:00
windows_toolchain.py Bug 1424281 - Use Visual Studio 2017 15.6.0 for Windows builds. r=froydnj 2018-03-12 19:24:44 -04:00