зеркало из https://github.com/mozilla/gecko-dev.git
aa43fa218e
This changes comes with several different refactorings all rolled into one, unfotunately I couldn't find a way to pull them apart: - First of all annotations now can either recorded (that is, we copy the value and have the crash reporting code own the copy) or registered. Several annotations are changed to use this functionality so that we don't need to update them as their value change. - The code in the exception handler is modified to read the annotations from the mozannotation_client crate. This has the unfortunate side-effect that we need three different bits of code to serialize them: one for annotations read from a child process, one for reading annotations from the main process outside of the exception handler and one for reading annotations from the main process within the exception handler. As we move to fully out-of-process crash reporting the last two methods will go away. - The mozannotation_client crate now doesn't record annotation types anymore. I realized as I was working on this that storing types at runtime has two issues: the first one is that buggy code might change the type of an annotation (that is record it under two different types at two different moments), the second issue is that types might become corrupt during a crash, so better enforce them at annotation-writing time. The end result is that the mozannotation_* crates now only store byte buffers, track the format the data is stored in (null-terminated string, fixed size buffer, etc...) but not the type of data each annotation is supposed to contain. - Which brings us to the next change: concrete types for annotations are now enforced when they're written out. If an annotation doesn't match the expected type it's skipped. Storing an annotation with the wrong type will also trigger an assertion in debug builds. Differential Revision: https://phabricator.services.mozilla.com/D195248 |
||
|---|---|---|
| .. | ||
| external | ||
| faster | ||
| makefiles | ||
| mozunit | ||
| tests | ||
| AB_rCD.mk | ||
| Makefile.in | ||
| MozZipFile.py | ||
| autoconf-js.mk.in | ||
| autoconf.mk.in | ||
| baseconfig.mk | ||
| check_js_msg_encoding.py | ||
| check_js_opcode.py | ||
| check_macroassembler_style.py | ||
| check_source_count.py | ||
| check_spidermonkey_style.py | ||
| check_vanilla_allocations.py | ||
| config.mk | ||
| create_rc.py | ||
| create_res.py | ||
| createprecomplete.py | ||
| emptyvars-js.mk.in | ||
| emptyvars.mk.in | ||
| gcc-stl-wrapper.template.h | ||
| gcc_hidden.h | ||
| install.bat | ||
| make-stl-wrappers.py | ||
| make-system-wrappers.py | ||
| make-windows-h-wrapper.py | ||
| milestone.txt | ||
| moz.build | ||
| msvc-stl-wrapper.template.h | ||
| nsinstall.c | ||
| nsinstall.py | ||
| pathsub.c | ||
| pathsub.h | ||
| printconfigsetting.py | ||
| printprereleasesuffix.py | ||
| rebuild_check.py | ||
| recurse.mk | ||
| rules.mk | ||
| run-and-prefix.py | ||
| run_spidermonkey_checks.py | ||
| shlwapi-h-constant.decls.h | ||
| shlwapi-h-unicode.decls.h | ||
| shlwapi-h-wrapper.template.h | ||
| static-checking-config.mk | ||
| stl-headers.mozbuild | ||
| system-headers.mozbuild | ||
| wasm2c.py | ||
| windows-h-constant.decls.h | ||
| windows-h-unicode.decls.h | ||
| windows-h-wrapper.template.h | ||