Harvey Hunt 1b9fe429b2 servo: Merge #17514 - deny_public_fields: display field identifier in help message (from HarveyHunt:deny-public-fields-error-message); r=jdm ... Use a binding's field identifier to produce more descriptive output. Fall back to a binding's identifier if a field identifier is not available. Additionally, make the privatize.rs compiletest more specific and wrap the identifier in backticks to aid readability. As an aside, should I send a PR to rename ```compile-fail/privatize.rs``` to ```compile-fail/deny_public_fields.rs``` as privatize isn't mentioned in the codebase any more? ``` $ find . -name "*privatize*" ./tests/compiletest/plugin/compile-fail/privatize.rs ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #17438 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 3f2d7476890bffdaad6fdc0e66aa7ac7bc995a87 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : b170b7dc790815fce9081f9765b07a159432def5		2017-06-25 10:45:42 -07:00
..
Cargo.toml	…
lib.rs	servo: Merge #17514 - deny_public_fields: display field identifier in help message (from HarveyHunt:deny-public-fields-error-message); r=jdm	2017-06-25 10:45:42 -07:00