зеркало из https://github.com/mozilla/gecko-dev.git
58786e1ea7
This patch makes the following changes to the macros.
- Removes PROFILER_LABEL_FUNC. It's only suitable for use in functions outside
classes, due to PROFILER_FUNCTION_NAME not getting class names, and it was
mostly misused.
- Removes PROFILER_FUNCTION_NAME. It's no longer used, and __func__ is
universally available now anyway.
- Combines the first two string literal arguments of PROFILER_LABEL and
PROFILER_LABEL_DYNAMIC into a single argument. There was no good reason for
them to be separate, and it forced a '::' in the label, which isn't always
appropriate. Also, the meaning of the "name_space" argument was interpreted
in an interesting variety of ways.
- Adds an "AUTO_" prefix to PROFILER_LABEL and PROFILER_LABEL_DYNAMIC, to make
it clearer they construct RAII objects rather than just being function calls.
(I myself have screwed up the scoping because of this in the past.)
- Fills in the 'js::ProfileEntry::Category::' qualifier within the macro, so
the caller doesn't need to. This makes a *lot* more of the uses fit onto a
single line.
The patch also makes the following changes to the macro uses (beyond those
required by the changes described above).
- Fixes a bunch of labels that had gotten out of sync with the name of the
class and/or function that encloses them.
- Removes a useless PROFILER_LABEL use within a trivial scope in
EventStateManager::DispatchMouseOrPointerEvent(). It clearly wasn't serving
any useful purpose. It also serves as extra evidence that the AUTO_ prefix is
a good idea.
- Tweaks DecodePool::SyncRunIf{Preferred,Possible} so that the labelling is
done within them, instead of at their callsites, because that's a more
standard way of doing things.
--HG--
extra : rebase_source : 318d1bc6fc1425a94aacbf489dd46e4f83211de4
|
||
|---|---|---|
| .. | ||
| ActiveLayerTracker.cpp | ||
| ActiveLayerTracker.h | ||
| BorderCache.h | ||
| BorderConsts.h | ||
| DashedCornerFinder.cpp | ||
| DashedCornerFinder.h | ||
| DisplayItemClip.cpp | ||
| DisplayItemClip.h | ||
| DisplayItemClipChain.cpp | ||
| DisplayItemClipChain.h | ||
| DisplayItemScrollClip.cpp | ||
| DisplayItemScrollClip.h | ||
| DisplayListClipState.cpp | ||
| DisplayListClipState.h | ||
| DottedCornerFinder.cpp | ||
| DottedCornerFinder.h | ||
| FrameLayerBuilder.cpp | ||
| FrameLayerBuilder.h | ||
| LayerState.h | ||
| MaskLayerImageCache.cpp | ||
| MaskLayerImageCache.h | ||
| PaintTracker.cpp | ||
| PaintTracker.h | ||
| moz.build | ||
| nsCSSRendering.cpp | ||
| nsCSSRendering.h | ||
| nsCSSRenderingBorders.cpp | ||
| nsCSSRenderingBorders.h | ||
| nsCSSRenderingGradients.cpp | ||
| nsCSSRenderingGradients.h | ||
| nsDisplayItemTypes.h | ||
| nsDisplayItemTypesList.h | ||
| nsDisplayList.cpp | ||
| nsDisplayList.h | ||
| nsDisplayListInvalidation.cpp | ||
| nsDisplayListInvalidation.h | ||
| nsImageRenderer.cpp | ||
| nsImageRenderer.h | ||