gecko-dev/browser/components/downloads
Gijs Kruitbosch 1e1ef247f3 Bug 1628255 - do not add a label/accesskey attribute to the button in the about:downloads and library downloads views, r=mconley,flod,fluent-reviewers
As noted by Jamie, accessible labels for richlistitem elements come from the
label elements that have value attributes within them.

In bug 1608202, we accidentally reused the same fluent message for the buttons
in about:downloads and the library download view (DownloadsViewUI.jsm) and
the context menuitems that do the same thing. This meant that
those menuitems gained a tooltip they shouldn't have, and the buttons gained
a label and accesskey they shouldn't have. The latter caused the
accessibility regression described in the bug.

This patch separates out the two usecases for the same string. I also checked
the other l10nIds used in DownloadsViewUI.jsm, and as far as I can tell this
is the only one that is reused in this way.

Differential Revision: https://phabricator.services.mozilla.com/D70219

--HG--
extra : moz-landing-system : lando
2020-04-08 21:39:14 +00:00
..
content Bug 1628255 - do not add a label/accesskey attribute to the button in the about:downloads and library downloads views, r=mconley,flod,fluent-reviewers 2020-04-08 21:39:14 +00:00
test/browser Bug 1615732 - Don't show download panel on Mac when ctrl key is pressed; r=Gijs 2020-04-06 20:56:19 +00:00
DownloadsCommon.jsm Bug 1608281 - Automated rewrite away from reading properties on the global `this` in JSM files - round 1 r=mossop 2020-01-29 21:50:04 +00:00
DownloadsMacFinderProgress.jsm
DownloadsSubview.jsm Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio 2020-04-08 16:17:50 +00:00
DownloadsTaskbar.jsm Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug 2019-11-05 17:56:28 +00:00
DownloadsViewUI.jsm Bug 1628255 - do not add a label/accesskey attribute to the button in the about:downloads and library downloads views, r=mconley,flod,fluent-reviewers 2020-04-08 21:39:14 +00:00
jar.mn Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop 2019-12-11 00:27:19 +00:00
moz.build