gecko-dev/editor
Masayuki Nakano 32d89118c3 Bug 1420415 - TextEditor::CreateBRImpl() needs to make pointToInsertBrNode store mOffset before calling EditorBase::CreateNode() r=m_kato
When TextEditor::CreateBRImpl() splits a text node before inserting new <br>
element, it initializes pointToInsertBrNode only with the right text node.
Then, it refers its Offset() after inserting new <br> node before the point.
Therefore, the offset is computed with the new DOM tree.  So, adding 1 to
the offset is redundant only in this case.

So, before calling CreateNode(), it needs to make pointToInsertBrNode store
offset with calling its Offset().

Note that this ugly code will be replaced with patches for bug 1408227.
Additionally, this doesn't use AutoEditorDOMPointChildInvalidator because
it's not available in 58 but we need to uplift this patch.

Finally, I'm not sure how to check this in automated tests.  Therefore, this
patch doesn't include automated tests.

MozReview-Commit-ID: IaQBonoGawR

--HG--
extra : rebase_source : a89559932f27d98a02baf3e207c6be3c2a545aad
2017-11-24 23:17:38 +09:00
..
composer Bug 1416622 - Tighten up libpref's process checking. r=glandium 2017-11-13 09:19:55 +11:00
libeditor Bug 1420415 - TextEditor::CreateBRImpl() needs to make pointToInsertBrNode store mOffset before calling EditorBase::CreateNode() r=m_kato 2017-11-24 23:17:38 +09:00
reftests Bug 464450 - Get rid of the padded class and clean up related styling. r=mak 2017-11-07 14:15:19 +01:00
txmgr Bug 1413013 - Remove unused nsITransactionList. r=masayuki 2017-10-30 20:35:00 +00:00
txtsvc Bug 1413181 - part 4: Redesign nsIEditActionListener::DidSplitNode() r=m_kato 2017-11-13 23:52:16 +09:00
AsyncSpellCheckTestHelper.jsm Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
moz.build Bug 1417400 - Get rid of nsIContentFilter. r=masayuki 2017-11-16 13:36:10 +09:00
nsEditorCID.h
nsIDocumentStateListener.idl
nsIEditActionListener.idl Bug 1413181 - part 4: Redesign nsIEditActionListener::DidSplitNode() r=m_kato 2017-11-13 23:52:16 +09:00
nsIEditor.idl Bug 1407854 - Part 1: Remove nsIEditor.createNode(); r=masayuki 2017-10-12 17:13:55 -04:00
nsIEditorMailSupport.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIEditorObserver.idl
nsIEditorSpellCheck.idl
nsIEditorStyleSheets.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIEditorUtils.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIHTMLAbsPosEditor.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIHTMLEditor.idl Bug 1417400 - Get rid of nsIContentFilter. r=masayuki 2017-11-16 13:36:10 +09:00
nsIHTMLInlineTableEditor.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIHTMLObjectResizer.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsIPlaintextEditor.idl Bug 1060051 - Make editor related interfaces builtin classes if it's possible r=Ehsan,smaug 2017-08-04 13:57:56 +09:00
nsITableEditor.idl Bug 1387317 - part1: Make AutoSelectionSetterAfterTableEdit use HTMLEditor instead of nsITableEditor r=m_kato 2017-08-08 10:57:19 +09:00
nsIURIRefObject.idl
nsPIEditorTransaction.idl