gecko-dev/tools
Gerald Squelart a354af1934 Bug 1707537 - Make ChildProfilerController::mThread thread-safe, and reset it before final dispatch and shutdown, to prevent re-entrancy - r=florian
Bug 1613798 (shutdown crashes during ChildProfilerController::ShutdownAndMaybeGrabShutdownProfileFirst's nsThread::Shutdown) could be explained by another nested shutdown destroying the same thread first, so when coming back to the first inner loop, there's a UAF on the already-destroyed thread!

Now we first reset the `mThread` pointer so it cannot be used by later/nested function calls, but keep a local reference (which should be the last one) to dispatch the shutdown operations and then shutdown the thread itself.

Also the thread pointer is now encapsulated in a DataMutex, in case it is accessed from different threads (e.g., the main thread and the IPC reception thread.)

Differential Revision: https://phabricator.services.mozilla.com/D113304
2021-04-26 23:17:02 +00:00
..
bloatview
browsertime Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE 2021-04-23 02:53:36 +03:00
clang-tidy Bug 1602143 - Use ShortStatementLines=1 for readability-braces-around-statements. r=andi 2021-02-18 08:26:11 +00:00
code-coverage Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers 2021-03-02 22:11:58 +00:00
compare-locales Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE 2021-04-23 02:53:36 +03:00
coverity
crashreporter Bug 1697929 - Create a breakpad injector toolchain build. r=glandium 2021-04-19 14:21:42 +00:00
fuzzing Bug 1695761 - Patch libFuzzer to return instead of exit() r=decoder 2021-04-07 13:37:12 +00:00
github-sync Bug 1685198 - Fix failure on first sync for new repo. r=jrmuizel 2021-01-06 01:31:35 +00:00
infer Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi 2021-01-07 08:53:08 +00:00
jprof Bug 1686632 - Remove non-inclusive language r=jesup 2021-01-21 17:28:23 +00:00
leak-gauge
lint Bug 1702922 - mozlint/clippy: Adjust the tests with the new version of clippy r=linter-reviewers,marco DONTBUILD 2021-04-26 09:12:24 +00:00
moztreedocs Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE 2021-04-23 02:53:36 +03:00
performance Bug 1703956 - Extend network perfstats to include all http channel completion times r=necko-reviewers,valentin 2021-04-12 21:42:21 +00:00
phabricator Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE 2021-04-23 02:53:36 +03:00
power Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE 2021-04-23 02:53:36 +03:00
profiler Bug 1707537 - Make ChildProfilerController::mThread thread-safe, and reset it before final dispatch and shutdown, to prevent re-entrancy - r=florian 2021-04-26 23:17:02 +00:00
quitter Bug 1698158 - part 3.2 - Remove unnecessary imports from testharness addons experimental API. r=mixedpuppy 2021-03-16 18:15:41 +00:00
rb Backed out 8 changesets (bug 1696531) for test_dmd.js and test_subprocess.js xpc failures CLOSED TREE 2021-04-14 17:49:29 +03:00
rewriting Bug 1690475 - [remote] Reorganize xpcshell and browser chrome tests. r=remote-protocol-reviewers,jdescottes 2021-02-23 17:37:03 +00:00
rusttests Bug 1697489: Run rusttests on Mac in CI r=firefox-build-system-reviewers,glandium 2021-04-08 23:06:29 +00:00
sanitizer/docs Bug 1700475 - Allow the WebRender build script to leak under ASAN. r=firefox-build-system-reviewers,glandium 2021-04-01 09:14:40 +00:00
tryselect Bug 1702310 - Add --gecko-profile-features and similar options to `mach try fuzzy` and `mach raptor` etc. to make it easier to generate marker-only profiles, configure threads and sampling interval, etc. r=perftest-reviewers,sparky 2021-04-26 21:59:29 +00:00
update-packaging Bug 1643195 Remove nonfunctional make_incremental_updates.py r=aki 2021-02-17 21:43:39 +00:00
update-programs Bug 1681574: Remove the old update agent skeleton. r=nalexander 2020-12-15 19:00:25 +00:00
update-verify Bug 1689040 - bump update-verify docker image to ubuntu 20.04. r=bhearsum 2021-03-01 10:49:26 +00:00
vcs Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE 2021-04-23 02:53:36 +03:00
mach_commands.py Backed out 2 changesets (bug 1696251) for causing js-bench-sm failures. CLOSED TREE 2021-04-23 02:53:36 +03:00
moz.build Bug 1641000 - Start documenting the Gecko Profiler; r=gerald 2020-11-20 18:55:26 +00:00