gecko-dev/image
Nicholas Nethercote 7974362afd Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm
Currently it's completely unclear at use sites that the getters for `once`
static prefs return the pref value from startup, rather than the current pref
value. (Bugs have been caused by this.) This commit improves things by changing
the getter name to make it clear that the pref value obtained is from startup.

This required changing things within libpref so it distinguishes between the
"base id" (`foo_bar`) and the "full id" (`foo_bar` or
`foo_bar_DoNotUseDirectly` or `foo_bar_AtStartup` or
`foo_bar_AtStartup_DoNotUseDirectly`; the name used depends on the `mirror` and
`do_not_use_directly` values in the YAML definition.) The "full id" is used in
most places, while the "base id" is used for the `GetPrefName_*` and
`GetPrefDefault_*` functions.

(This is a nice demonstration of the benefits of the YAML file, BTW. Making
this change with the old code would have involved adding an entry to every
single pref in StaticPrefList.h.)

The patch also rejigs the comment at the top of StaticPrefList.yaml, to clarify
some things.

Differential Revision: https://phabricator.services.mozilla.com/D38604

--HG--
extra : moz-landing-system : lando
2019-07-22 02:10:14 +00:00
..
build Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
decoders Bug 1289211 - Rename InfallibleTArray to nsTArray in image/ r=aosmond 2019-07-10 03:31:04 +00:00
encoders Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond 2019-02-25 16:07:58 -06:00
test Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
AnimationFrameBuffer.cpp Bug 1516011 - Part 2. Deny recycling for frames used in blob recordings. r=tnikkel 2019-01-14 13:21:57 -05:00
AnimationFrameBuffer.h Bug 1510601 - Part 1. Move size increments into AnimationFrameBuffer::InsertInternal. r=tnikkel 2018-12-05 12:04:20 -05:00
AnimationParams.h Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel 2019-03-18 07:30:34 -04:00
AnimationSurfaceProvider.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
AnimationSurfaceProvider.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
BMPHeaders.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ClippedImage.cpp Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert 2019-05-02 23:28:21 +00:00
ClippedImage.h Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert 2019-05-02 23:28:21 +00:00
CopyOnWrite.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
DecodePool.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
DecodePool.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
DecodedSurfaceProvider.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
DecodedSurfaceProvider.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
Decoder.cpp Bug 1255106 - Part 1. Move color transform state to image decoder base class. r=tnikkel 2019-05-28 11:38:46 -04:00
Decoder.h Bug 1255106 - Part 1. Move color transform state to image decoder base class. r=tnikkel 2019-05-28 11:38:46 -04:00
DecoderFactory.cpp Bug 1561491 - Make image.* static prefs follow the naming convention. r=KrisWright 2019-06-26 13:24:21 +10:00
DecoderFactory.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
DecoderFlags.h Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel 2019-03-18 07:30:34 -04:00
Downscaler.cpp Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
Downscaler.h Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
DownscalingFilter.h Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
DynamicImage.cpp Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
DynamicImage.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
FrameAnimator.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
FrameAnimator.h Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
FrameTimeout.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
FrozenImage.cpp Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
FrozenImage.h Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
ICOFileHeaders.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
IDecodingTask.cpp Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
IDecodingTask.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
IProgressObserver.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ISurfaceProvider.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
Image.cpp Bug 1550422 - P23. Remove now unused gfxPrefs. r=jrmuizel 2019-05-26 14:31:53 +00:00
Image.h Bug 1527085 - Ensure we invalidate when the image request changes. r=jrmuizel 2019-02-15 09:24:21 -05:00
ImageCacheKey.cpp Bug 1554361 - Move the high-level storage access check APIs to mozilla/StorageAccess.h; r=baku 2019-05-27 14:06:49 +00:00
ImageCacheKey.h Bug 1548349 - Make sure the image cache for third-party tracking subresources is keyed to the top-level document's eTLD+1; r=baku,aosmond 2019-05-02 12:27:07 +00:00
ImageFactory.cpp Bug 1561491 - Make image.* static prefs follow the naming convention. r=KrisWright 2019-06-26 13:24:21 +10:00
ImageFactory.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ImageLogging.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ImageMemoryReporter.cpp Bug 1561491 - Make image.* static prefs follow the naming convention. r=KrisWright 2019-06-26 13:24:21 +10:00
ImageMemoryReporter.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ImageMetadata.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ImageOps.cpp Bug 1545567 - Ensure ImageOps decode methods can handle unbuffered input streams properly. r=baku 2019-04-26 11:58:24 -04:00
ImageOps.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ImageRegion.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ImageWrapper.cpp Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
ImageWrapper.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ImgDrawResult.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
LookupResult.h Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel 2019-04-18 14:35:58 -04:00
MultipartImage.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
MultipartImage.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
Orientation.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
OrientedImage.cpp Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert 2019-05-02 23:28:21 +00:00
OrientedImage.h Bug 1547792 - AspectRatio should be a single ratio, not a size. r=dholbert 2019-05-02 23:28:21 +00:00
PlaybackType.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ProgressTracker.cpp Bug 1552077. Use medium high runnables for a few more imagelib runnables. r=smaug 2019-05-17 23:09:38 +00:00
ProgressTracker.h Bug 1552077. Use medium high runnables for a few more imagelib runnables. r=smaug 2019-05-17 23:09:38 +00:00
RasterImage.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
RasterImage.h Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
RecyclingSourceSurface.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
SVGDocumentWrapper.cpp Bug 1544215 - Make nsIContentVewer::GetPresShell() return mozilla::PresShell instead of nsIPresShell r=bzbarsky 2019-04-16 02:47:26 +00:00
SVGDocumentWrapper.h Bug 1544215 - Make nsIContentVewer::GetPresShell() return mozilla::PresShell instead of nsIPresShell r=bzbarsky 2019-04-16 02:47:26 +00:00
SVGDrawingParameters.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ScriptedNotificationObserver.cpp Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ScriptedNotificationObserver.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ShutdownTracker.cpp Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond 2019-02-25 16:07:58 -06:00
ShutdownTracker.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
SourceBuffer.cpp Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond 2019-02-25 16:07:58 -06:00
SourceBuffer.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
StreamingLexer.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
SurfaceCache.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
SurfaceCache.h Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel 2019-04-18 14:35:58 -04:00
SurfaceCacheUtils.cpp Bug 1523969 part 10 - Move method definition inline comments to new line in 'image/'. r=aosmond 2019-02-25 16:07:58 -06:00
SurfaceCacheUtils.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
SurfaceFilters.h Bug 1255106 - Part 2. Implement color management filter for SurfacePipe. r=tnikkel 2019-05-28 11:38:46 -04:00
SurfaceFlags.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
SurfacePipe.cpp Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel 2019-03-18 07:30:34 -04:00
SurfacePipe.h Bug 1530774 - Part 2. Remove support for paletted surface pipes. r=tnikkel 2019-03-18 07:30:34 -04:00
SurfacePipeFactory.h Bug 1255106 - Part 3. Use color management filter with decoders using SurfacePipe. r=tnikkel 2019-05-28 11:38:46 -04:00
VectorImage.cpp Bug 1559096. Rename SVGObserverUtils::mInObserverList. r=longsonr 2019-06-06 11:12:21 -07:00
VectorImage.h Bug 1543584 - Always rasterize SVGs but clamp the maximum size. r=tnikkel 2019-04-18 14:35:58 -04:00
imgFrame.cpp Bug 1561491 - Make image.* static prefs follow the naming convention. r=KrisWright 2019-06-26 13:24:21 +10:00
imgFrame.h Bug 1530774 - Part 3. Remove decoder support for producing paletted frames. r=tnikkel 2019-03-18 07:30:34 -04:00
imgICache.idl Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug 2019-01-03 17:48:33 +01:00
imgIContainer.idl Bug 1550523 - Ensure that decoding methods for frozen images request the correct frame. r=tnikkel 2019-05-22 06:22:50 -04:00
imgIContainerDebug.idl
imgIEncoder.idl
imgILoader.idl
imgINotificationObserver.idl
imgIRequest.idl Bug 1554847 - Improve cross-origin checks in canvas API - imgIRequest.hadCrossOriginRedirects, r=aosmond 2019-06-04 06:31:42 +00:00
imgIScriptedNotificationObserver.idl
imgITools.idl
imgLoader.cpp Bug 1567329 - Append `_AtStartup` to `once` static pref getters. r=erahm 2019-07-22 02:10:14 +00:00
imgLoader.h Bug 1548835 - Load moz-extension:// URIs from the cache over reloading. r=tnikkel 2019-05-17 07:21:56 -04:00
imgRequest.cpp Bug 1561491 - Make image.* static prefs follow the naming convention. r=KrisWright 2019-06-26 13:24:21 +10:00
imgRequest.h Bug 1377457. Only apply locks to the image if SetHasImage has been called. r=aosmond 2019-05-01 23:05:47 +00:00
imgRequestProxy.cpp Bug 1554847 - Improve cross-origin checks in canvas API - imgIRequest.hadCrossOriginRedirects, r=aosmond 2019-06-04 06:31:42 +00:00
imgRequestProxy.h Bug 1554847 - Improve cross-origin checks in canvas API - imgIRequest.hadCrossOriginRedirects, r=aosmond 2019-06-04 06:31:42 +00:00
imgTools.cpp Bug 1532005 - Implement a new js/public/ArrayBuffer.h header to centralize functionality for creating and interacting with ArrayBuffers. r=sfink 2019-03-04 15:19:16 -08:00
imgTools.h Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
moz.build Bug 1530190. De-unify image/DecodePool.cpp on Windows. r=aosmond 2019-04-22 17:30:40 -05:00
nsIIconURI.idl