gecko-dev/dom/animation
Brian Birtles c64d600a96 Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro
The difference between nsDocument::IsWebAnimationsEnabled and
nsContentUtils::AnimationsAPICoreEnabled is that the former checks the caller
type and treats the preference as set for system callers which is particularly
needed for enabling things like the getProperties() API for DevTools etc.

Generally in API-facing call sites we have a JS context / CallerType and so we
want to distinguish between system callers and non-system callers. However, for
a few internal uses--specifically filling-in missing keyframes--we don't care
about the caller type and always follow the pref setting.

That may or not be quite what we want, but this patch doesn't change that except
for one call site: KeyframeUtils::GetKeyframesFromObject. This patch changes
GetKeyframesFromObject from *not* checking the caller type to checking the
caller type. That seems to be the correct behavior here since this is called
from KeyframeEffectReadOnly::SetKeyframes(JSContext*, JS::Handle<JSObject*>,
ErrorResult&) (i.e. a JS API-facing call site) where we *should* enable the full
API when the caller is chrome code.

MozReview-Commit-ID: FQJBk3zytwd

--HG--
extra : rebase_source : 577bca1e551e39fecfab309f64c993eba110337f
2017-11-20 14:18:43 +09:00
..
test Bug 1415729 - Make 'necessary_update_should_be_invoked' test in file_restyles.html more strict. r=birtles 2017-11-15 13:43:20 +09:00
AnimValuesStyleRule.cpp Bug 1384542: Move GetParent and IsLinkContext to GeckoStyleContext. r=heycam 2017-07-31 14:32:59 +02:00
AnimValuesStyleRule.h
Animation.cpp Bug 1291413 - Fix assertion when resuming an Animation with both a start time and hold time; r=hiro 2017-10-05 10:50:38 +09:00
Animation.h Bug 1411318 - Don't consider an animation playing if its timeline is inactive; r=hiro 2017-10-26 10:18:42 +09:00
AnimationComparator.h Bug 1417365 - Unified build issues in dom/animation. r=baku 2017-10-26 11:55:28 +01:00
AnimationEffectReadOnly.cpp Bug 1417365 - Unified build issues in dom/animation. r=baku 2017-10-26 11:55:28 +01:00
AnimationEffectReadOnly.h Bug 1379564 - Use BaseTimeDuration::bool() to check the TimeDuration is not zero. r=birtles 2017-07-10 16:21:30 +09:00
AnimationEffectTiming.cpp Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
AnimationEffectTiming.h Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
AnimationEffectTimingReadOnly.cpp Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
AnimationEffectTimingReadOnly.h Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
AnimationPerformanceWarning.cpp Bug 1386600 - Change nsIStringBundle methods to return |AString| instead of |wstring|. r=emk,sr=dbaron. 2017-08-04 14:40:52 +10:00
AnimationPerformanceWarning.h Bug 1391803 - Use nsStringFwd.h for forward declaring string classes. r=froydnj 2017-08-16 16:48:52 -07:00
AnimationPropertySegment.h Bug 1311257 - Move AnimationPropertySegment in a separate header and expose it in FFI. r=heycam 2017-04-06 10:34:50 +09:00
AnimationTarget.h Bug 1318223 - Use NonOwningAnimationTarget in OwningElementRef. r=boris, r=birtles 2017-03-26 16:46:00 -04:00
AnimationTimeline.cpp Bug 1374125 - Use EnsureInserted instead of Contains+PutEntry to avoid unnecessary hashtable lookups. r=froydnj 2017-06-19 18:19:14 +02:00
AnimationTimeline.h
AnimationUtils.cpp Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro 2017-11-20 14:18:43 +09:00
AnimationUtils.h Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro 2017-11-20 14:18:43 +09:00
CSSPseudoElement.cpp Bug 1413216 - Fix some missing includes in dom code. r=baku 2017-10-12 13:50:23 +01:00
CSSPseudoElement.h Bug 1412125, part 2 - Fix dom/ mode lines. r=qdot 2017-10-26 15:08:41 -07:00
ComputedTiming.h Bug 1264125 part 10 - Remove unnecessary whitespace and align the colum of variable definition on ComputedTiming.h. r=whitespace-only DONTBUILD 2017-04-27 09:10:44 +09:00
ComputedTimingFunction.cpp Bug 1248340 - Part 2: Implement Frames in ComputedTimingFunction. r=birtles 2017-02-24 16:59:02 +08:00
ComputedTimingFunction.h Bug 1354947 - Add equal operators for comparing ComputedTimingFunction with nsTimingFunction. r=birtles 2017-05-13 16:34:38 +09:00
DocumentTimeline.cpp Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv 2017-08-29 16:02:48 -07:00
DocumentTimeline.h
EffectCompositor.cpp Bug 1417365 - Unified build issues in dom/animation. r=baku 2017-10-26 11:55:28 +01:00
EffectCompositor.h Bug 1406750: Fix detection of animations to avoid flushing. r=hiro,birtles 2017-10-25 19:02:01 +02:00
EffectSet.cpp Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro. 2017-10-03 09:05:19 +11:00
EffectSet.h Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro. 2017-10-03 09:05:19 +11:00
Keyframe.h Bug 1381389 - Append PropertyValuePair objects on Gecko side so they are initialized correctly; r=hiro 2017-07-20 14:38:54 +09:00
KeyframeEffect.cpp Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro 2017-11-20 14:18:43 +09:00
KeyframeEffect.h Bug 1339690 - Part 3: Drop spacing mode. r=birtles,smaug 2017-06-13 15:09:19 +08:00
KeyframeEffectParams.h Bug 1339690 - Part 3: Drop spacing mode. r=birtles,smaug 2017-06-13 15:09:19 +08:00
KeyframeEffectReadOnly.cpp Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro 2017-11-20 14:18:43 +09:00
KeyframeEffectReadOnly.h Bug 1303235 - Part 2: Templatize CalculateCumulativeChangeHint. r=hiro 2017-10-12 16:12:54 +08:00
KeyframeUtils.cpp Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro 2017-11-20 14:18:43 +09:00
KeyframeUtils.h Bug 1382017 part 4 Gecko piece - Remove usage of ServoComputedValues from most Gecko code; r=xidorn 2017-07-20 17:27:05 -07:00
PendingAnimationTracker.cpp Bug 1403433 - Add another variant of SchedulePaint that does not call InvalidateRenderingObservers for PendingAnimationTracker. r=birtles 2017-09-29 19:42:13 +09:00
PendingAnimationTracker.h Bug 1282691 - Drop the assertion about an animation that we're making play-pending not already being pause-pending; r=boris 2017-10-13 14:37:51 +09:00
PseudoElementHashEntry.h
TimingParams.cpp Bug 1374882 - Precompute active duration and end time. r=birtles 2017-06-22 12:12:43 +09:00
TimingParams.h Bug 1379564 - Use BaseTimeDuration::bool() to check the TimeDuration is not zero. r=birtles 2017-07-10 16:21:30 +09:00
moz.build Bug 1339690 - Part 3: Drop spacing mode. r=birtles,smaug 2017-06-13 15:09:19 +08:00