Read-only Git mirror of the Mercurial gecko repositories at https://hg.mozilla.org. How to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
Перейти к файлу
Drew Willcoxon ad4b3ecfcb Bug 1538117 - Fix autofill when typing the last character of an autofilled value. r=mak
_autofillValueOnInput correctly uses the placeholder string as the autofilled value, but it incorrectly uses _lastSearchString as the current input value.  _lastSearchString at that point is -- yes -- the previous search string, not what the user has just typed.  So when _autofillValueOnInput sets selectionStart to _lastSesarchString.length, the length is one char less than what it should be.

But why does that mess up only the last char typed and not every char?  Because when the first result comes in, we correctly autofill it.  It's only when the first result is not an autofill result that the incorrect placeholder autofill sticks around -- e.g., just after you type the last char in an @ alias.

This patch just gets rid of _autofillValueOnInput and inlines the body in _maybeAutofillOnInput.

Differential Revision: https://phabricator.services.mozilla.com/D24551

--HG--
extra : moz-landing-system : lando
2019-03-22 20:34:44 +00:00
.cargo Bug 1524396 - Unify how target/host linker/flags are passed to rust. r=chmanchester 2019-03-22 11:05:18 +00:00
.vscode Bug 1514820 - Recommend a VSCode extension for IDL language highlighting r=jya 2018-12-18 19:43:33 +00:00
accessible Bug 1536648 - accessible/ manual ESLint no-throw-literal fixes. r=Jamie 2019-03-20 00:23:17 +00:00
browser Bug 1538117 - Fix autofill when typing the last character of an autofilled value. r=mak 2019-03-22 20:34:44 +00:00
build Bug 1524396 - Unify how target/host linker/flags are passed to rust. r=chmanchester 2019-03-22 11:05:18 +00:00
caps Bug 1534971: Add helper function within CSP to check if two CSPs are equal. r=jkt 2019-03-15 12:20:52 +00:00
chrome Bug 1523609 - avoid triggering nsChromeRegistryChrome::CheckForNewChrome (which does main thread I/O) during shutdown of system add-ons, r=kmag. 2019-03-22 14:19:59 +00:00
config Bug 1524396 - Unify how target/host linker/flags are passed to rust. r=chmanchester 2019-03-22 11:05:18 +00:00
db Bug 1530749 - Upgrade to SQLite 3.27.2. r=mak 2019-02-26 23:21:05 +00:00
devtools Bug 1537877 - Update getDocumentWalker to fallback to non-anonymous walker;r=pbro 2019-03-22 19:43:08 +00:00
docshell Bug 1508817 - Enable ESLint for docshell (manual changes). r=Standard8,bzbarsky 2019-03-22 07:53:32 +00:00
dom Bug 1513911 - Part 3 - replace PIndexedDBPermissionRequest with async returns in IPC; r=asuth 2019-03-22 19:14:01 +00:00
editor Backed out 3 changesets (bug 1533293) for causing Bug 1536595 a=backout 2019-03-20 13:29:17 +02:00
embedding Bug 1514594: Part 3 - Change ChromeUtils.import API. 2019-01-17 10:18:31 -08:00
extensions Backed out 3 changesets (bug 1533293) for causing Bug 1536595 a=backout 2019-03-20 13:29:17 +02:00
gfx Bug 1441308 - Always send parent commands when sending mDestroyedActors r=kats,sotaro 2019-03-22 18:29:04 +00:00
gradle/wrapper Bug 1509572 - Part 1: Bump Gradle wrapper to 4.10.2; decouple script from Gradle version. r=snorp 2018-11-26 21:42:27 +00:00
hal Bug 1523969 part 9 - Move method definition inline comments to new line in 'hal/'. r=gsvelto 2019-02-25 16:07:35 -06:00
image Bug 1478134 - disabled wrapper.html?pal8os2sp.bmp on all platforms r=jmaher 2019-03-22 16:04:49 +00:00
intl Bug 1536103 - Fix Sphinx Warning - Title Underline too short in 'mach doc'. r=ahal 2019-03-22 19:30:34 +00:00
ipc Bug 1212103 : Added assert to check if the id is exceeding bounds of signed 32 bit integer r=jld 2019-03-22 19:06:02 +00:00
js Bug 1222552 - Fix xpconnect test. r=smaug 2019-03-22 18:11:10 +00:00
layout Bug 1529238 - Avoid TypeError in 'mach test <reftest> --verify'; r=bc 2019-03-22 19:52:07 +00:00
media Bug 1536070 - Enable ASM in dav1d for Tier3 platforms. r=TD-Linux 2019-03-22 14:18:27 +00:00
memory Bug 1529922 - Add guard pages following huge allocations. r=glandium 2019-03-20 10:45:15 +00:00
mfbt Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-03-21 06:36:37 +02:00
mobile Bug 1536866 - Hide enter guest session option from the menu. r=petru 2019-03-22 06:51:51 +00:00
modules Bug 1533584 - Enable capping the maximum life-time of client-side cookies to seven days on Nightly; r=baku 2019-03-22 06:01:27 +00:00
mozglue Bug 632954 - Add an explicit __llvm_profile_dump() call for Android; r=snorp 2019-03-18 23:52:31 +00:00
netwerk Bug 1538207 - Don't call into the prefs service OMT. r=decoder 2019-03-22 16:29:27 +00:00
nsprpub Bug 1526010, NSPR 4.21 RTM, r=me 2019-03-07 11:16:36 +01:00
other-licenses Bug 1523118 atk: Implement scrollsubstringto ATK API. r=surkov 2019-01-26 20:38:53 +01:00
parser Bug 1534346 - Mark malformed SVG scripts as malformed for real. r=alchen 2019-03-21 20:39:22 +00:00
python Backed out changeset d12b8cd1cee8 (bug 1534858) for causing diff build bustages CLOSED TREE 2019-03-22 15:17:30 +02:00
remote Bug 1536794 - Test Page.frameStoppedLoading and Page.navigatedWithinDocument. r=ato 2019-03-21 14:23:20 +00:00
security Bug 1474759 - added strings to the empty MOZ_Crash() in Linux sandboxing module. r=handyman 2019-03-22 07:43:29 +00:00
services No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM 2019-03-21 12:29:05 +00:00
servo Bug 1536586 - followup of the followup: Remove unused #[macro_use] in 32-bit builds. 2019-03-22 00:09:22 +01:00
startupcache Bug 1353013 - create preloaded newtab browser from an idle task, only in top window(s), r=dthayer 2019-03-19 17:29:48 +00:00
storage Bug 1523969 part 22 - Move method definition inline comments to new line in 'storage/'. r=mak 2019-02-25 16:12:31 -06:00
taskcluster Bug 1536103 - Fix Sphinx Warning - Title Underline too short in 'mach doc'. r=ahal 2019-03-22 19:30:34 +00:00
testing Bug 1536103 - Fix Sphinx Warning - Title Underline too short in 'mach doc'. r=ahal 2019-03-22 19:30:34 +00:00
third_party Bug 1523417 - BITS client library for update downloading r=aklotz,emilio,froydnj 2019-03-21 22:43:41 +00:00
toolkit Bug 1154295 - use normal formatting for plaintext documents in reader mode r=Gijs 2019-03-22 20:08:56 +00:00
tools Bug 1536805 - Tell codespell 'whats' is a valid word r=ahal 2019-03-22 19:32:59 +00:00
uriloader Bug 1533074 - Implement Fingerprinting and Cryptomining annotation features - Part 1 - Classification flags in nsIHttpChannel, r=valentin,dimi 2019-03-14 17:47:59 +00:00
view Bug 1533617 part 1. Improve MOZ_CAN_RUN_SCRIPT annotations around synth mouse events. r=emilio 2019-03-11 14:58:04 +00:00
widget Bug 1441308 - Core renderroot splitting changes r=kats,sotaro 2019-03-22 18:28:42 +00:00
xpcom Bug 1441308 - Core renderroot splitting changes r=kats,sotaro 2019-03-22 18:28:42 +00:00
xpfe/appshell Bug 1533405 - Do not create the hidden window if it's too early on startup or during shutdown. r=mossop 2019-03-20 19:35:59 +00:00
.arcconfig
.clang-format Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre 2019-01-18 10:16:18 +01:00
.clang-format-ignore Bug 1528492 - Add cbor-cpp to the thirdparty list r=jcj 2019-02-17 01:03:40 +00:00
.cron.yml Bug 1535057: Always re-fetch chromium in cron; r=aki 2019-03-13 20:05:24 +00:00
.eslintignore Bug 1508817 - Enable ESLint for docshell (manual changes). r=Standard8,bzbarsky 2019-03-22 07:53:32 +00:00
.eslintrc.js Bug 1536653 - browser/ manual ESLint no-throw-literal fixes. r=Gijs 2019-03-20 10:15:03 +00:00
.flake8 Bug 1523835 - Added python/mozbuild/mozpack to the flake8 linter and solved the errors, r=ahal 2019-03-01 15:36:45 -05:00
.gdbinit Bug 1486903 - Add "ftl" command to dump frame subtree to .gdbinit. r=Ehsan 2018-08-28 20:20:21 +00:00
.gdbinit_python
.git-blame-ignore-revs No Bug - Ignore bug 1128203 in blame/annotate. r=me 2019-03-21 16:37:20 -07:00
.gitignore Bug 1521864 - It should be possible to open the debugger in a tab. r=davidwalsh 2019-02-21 14:56:47 +00:00
.hg-annotate-ignore-revs No Bug - Ignore bug 1128203 in blame/annotate. r=me 2019-03-21 16:37:20 -07:00
.hg-format-source Bug 1511181 - Quick fix for .hg-format-source that has an empty line. r=ehsan, a=aryx 2018-11-30 13:25:44 +02:00
.hgignore Bug 1525638 - Let hg ignore the build directories of WebRender standalone builds. r=ted 2019-02-11 13:37:44 +00:00
.hgtags No bug - Tagging mozilla-central 9421b477d67cfc4c9e03350cd554a9e6acc7f435 with FIREFOX_NIGHTLY_67_END a=release DONTBUILD CLOSED TREE 2019-03-18 10:56:58 +00:00
.lldbinit
.mailmap
.taskcluster.yml Bug 1491371, 1512188 - use new decision task image, with new options r=tomprince 2019-03-21 18:12:23 +00:00
.trackerignore Bug 1486468 - Add .trackerignore file to avoid GNOME Tracker indexing mozilla-central files. r=ahal 2018-08-27 16:45:03 +02:00
.yamllint
.ycm_extra_conf.py Bug 1522135 - Make .ycm_extra_conf.py work with python3. r=jgraham 2019-01-24 13:51:28 +01:00
AUTHORS Bug 1481409 - Use HTTPS protocol for Mozilla's Credits link in AUTHORS file r=mossop 2018-08-13 16:39:30 +00:00
CLOBBER Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-03-18 11:01:13 +00:00
Cargo.lock Bug 1523417 - BITS client library for update downloading r=aklotz,emilio,froydnj 2019-03-21 22:43:41 +00:00
Cargo.toml Bug 1505343 - Part 1: Rename binsource => binast. r=Yoric 2019-03-13 04:29:44 +00:00
GNUmakefile
LEGAL
LICENSE
Makefile.in Bug 1535501 - Allow to get full crashreporter symbols on artifact builds. r=mshal 2019-03-15 21:56:14 +00:00
README.txt Bug 1480997 - Remove "Mozilla FTP server" link in README.txt r=mossop 2018-10-23 10:06:29 +00:00
aclocal.m4 Bug 1519603 - Manually inline AC_OUTPUT_SUBDIRS and MOZ_RUN_ALL_SUBCONFIGURES. r=nalexander 2019-01-14 18:37:06 +00:00
build.gradle Bug 1535013: [geckoview] Add default impls to all interfaces. r=snorp 2019-03-14 16:48:57 +00:00
client.mk Bug 1498031 - Merge code paths for running configure between Tup and Make based backends. r=firefox-build-system-reviewers,mshal 2018-10-16 22:21:36 +00:00
client.py
configure.in
configure.py Bug 1528241 - Add a trace mode to python configure that logs internal values. r=chmanchester 2019-02-20 07:46:22 +09:00
gradle.properties Bug 1527896 - Increase Gradle heaps to handle large assets. r=nalexander 2019-02-14 18:21:13 +00:00
gradlew
mach
moz.build Bug 1507334 - Add mozconfigs for 3-stage PGO; r=firefox-build-system-reviewers,chmanchester#firefox-build-system-reviewers 2019-01-10 01:34:49 +00:00
moz.configure Bug 1535501 - Allow to get full crashreporter symbols on artifact builds. r=mshal 2019-03-15 21:56:14 +00:00
mozilla-config.h.in Bug 1504022 - Map GetExceptionCode to a nop to avoid an error r=bobowen 2018-11-02 13:28:01 -05:00
old-configure.in Bug 1535226 - Remove uses of XP_WIN32 in Gecko. r=glandium 2019-03-21 01:28:50 +00:00
package-lock.json Bug 1517707. Update ESLint related modules to latest versions. r=mossop 2019-01-04 16:44:49 +00:00
package.json Bug 1517707. Update ESLint related modules to latest versions. r=mossop 2019-01-04 16:44:49 +00:00
settings.gradle
test.mozbuild

README.txt

An explanation of the Mozilla Source Code Directory Structure and links to
project pages with documentation can be found at:

    https://developer.mozilla.org/en/Mozilla_Source_Code_Directory_Structure

For information on how to build Mozilla from the source code, see:

    https://developer.mozilla.org/en/docs/Build_Documentation

To have your bug fix / feature added to Mozilla, you should create a patch and
submit it to Bugzilla (https://bugzilla.mozilla.org). Instructions are at:

    https://developer.mozilla.org/en/docs/Creating_a_patch
    https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree

If you have a question about developing Mozilla, and can't find the solution
on https://developer.mozilla.org, you can try asking your question in a
mozilla.* Usenet group, or on IRC at irc.mozilla.org. [The Mozilla news groups
are accessible on Google Groups, or news.mozilla.org with a NNTP reader.]

Nightly development builds can be downloaded from:

    https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/
            - or -
    https://www.mozilla.org/firefox/channel/desktop/#nightly

Keep in mind that nightly builds, which are used by Mozilla developers for
testing, may be buggy.