4c184ca81b
We only need to default `browser.urlbar.merino.enabled` to true. If the user has opted in (either through the modal or by toggling on the data collection pref in the prefs UI), then `quicksuggest.dataCollection.enabled` will also be true and we'll fetch Merino suggestions. Otherwise it will be false and we won't fetch Merino suggestions. That logic is implemented here: https://searchfox.org/mozilla-central/rev/9a5f36b0ddb9cb8ae556fc5b45f8ccea0f0da6f8/browser/components/urlbar/UrlbarProviderQuickSuggest.jsm#144 Note this defaults the pref to true for everyone, even users in offline. It make senses now that we have a separate toggle for data collection in the preferences UI. Even offline users can opt in to Merino and data collection. I also updated the various sets of prefs for test suites so that the Merino endpoint URL is empty when running tests so they don't hit the network. I could have forced `merino.enabled` to false instead, but setting the endpoint URL has a couple of benefits, although admittedly they're very small: * It runs a little more of the Merino code path (i.e., calls `_fetchMerinoSuggestions`) * It lets Merino tests set only one pref, the endpoint URL, instead of two, both the endpoint pref and enabled pref Differential Revision: https://phabricator.services.mozilla.com/D131988 |
||
|---|---|---|
| .. | ||
| cdp | ||
| components | ||
| doc | ||
| marionette | ||
| server | ||
| shared | ||
| test | ||
| webdriver-bidi | ||
| .eslintrc.js | ||
| .gitignore | ||
| README.md | ||
| jar.mn | ||
| mach_commands.py | ||
| moz.build | ||
README.md
The Firefox remote agent is a low-level debugging interface based on the CDP protocol.
With it, you can inspect the state and control execution of documents running in web content, instrument Gecko in interesting ways, simulate user interaction for automation purposes, and debug JavaScript execution.
This component provides an experimental and partial implementation of a remote devtools interface using the CDP protocol and transport layer.
See https://firefox-source-docs.mozilla.org/remote/ for documentation.
It is available in Firefox and is started this way:
% ./mach run --remote-debugging-port
Puppeteer
Puppeteer is a Node library which provides a high-level API to control Chrome, Chromium, and Firefox over the Chrome DevTools Protocol. Puppeteer runs headless by default, but can be configured to run full (non-headless) browsers.
To verify that our implementation of the CDP protocol is valid we do not only run xpcshell and browser-chrome mochitests in Firefox CI but also the Puppeteer unit tests.
Expectation Data
With the tests coming from upstream, it is not guaranteed that they
all pass in Gecko-based browsers. For this reason it is necessary to
provide metadata about the expected results of each test. This is
provided in a manifest file under test/puppeteer-expected.json.
For each test of the Puppeteer unit test suite an equivalent entry will exist
in this manifest file. By default tests are expected to PASS.
Tests that are intermittent may be marked with multiple statuses using a list of possibilities e.g. for a test that usually passes, but intermittently fails:
"Page.click should click the button (click.spec.ts)": [
"PASS", "FAIL"
],
Disabling Tests
Tests are disabled by using the manifest file test/puppeteer-expected.json.
For example, if a test is unstable, it can be disabled using SKIP:
"Workers Page.workers (worker.spec.ts)": [
"SKIP"
],
For intermittents it's generally preferable to give the test multiple expectations rather than disable it.
Autogenerating Expectation Data
After changing some code it may be necessary to update the expectation
data for the relevant tests. This can of course be done manually, but
mach is able to automate the process:
mach puppeteer-test --write-results
By default it writes the output to test/puppeteer-expected.json.
Given that the unit tests run in Firefox CI only for Linux it is advised to download the expectation data (available as artifact) from the TaskCluster job.