gecko-dev/accessible
Marco Zehe 0a23cd946b Bug 1512411 - Don't expose broken label children accessibles on a XUL toolbarbutton which specifies the label attribute, r=Jamie
In bug 1507365, we introduced the ability of nested label children of toolbar buttons to provide the accessible name for a xul:toolbarbutton element. However, the XBL of xul:toolbarbutton causes the creation of a label accessible even if no xul:label child is present, and only the label attribute is being used. The nsIAccessibleText interface on such labels is, however, completely broken. This causes NVDA's mouse tracking, which always uses the deepest nested child, to fail. As a result, when hovering over Hamburger menu items, the announcement would be wrong, e. g., lag one behind the actual button the mouse is hovering over.

To fix this, we only accept xul:label children if they come from real XUL markup, not from the label attribute and the XBL creating the label. This means that some of the test changes from bug 1507365 have to be reverted to accommodate the new old behavior. But the new test for an actual label child still passes.

Differential Revision: https://phabricator.services.mozilla.com/D14469

--HG--
extra : moz-landing-system : lando
2018-12-14 08:20:02 +00:00
..
android Bug 1512961 - Reformat recent changes to the Google coding style r=Ehsan 2018-12-10 19:23:16 +00:00
aom Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
atk Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
base Bug 1511955 - Don't traverse into children without hypertext interfaces. r=Jamie 2018-12-10 03:30:21 +00:00
generic Bug 1492326, use Element helper methods in accessibility instead of QueryInterface to get interface implementations that might be implemented by custom elements, r=surkov 2018-12-04 11:32:15 -05:00
html Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
interfaces Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
ipc Bug 1510791 - Add action count to BatchData and set isClickable correctly in Android. r=yzen 2018-12-05 15:37:24 +00:00
jsat Bug 1510794 - Implement AccessibilityNodeInfo.ACTION_CLICK natively. r=yzen 2018-12-05 16:08:01 +00:00
mac Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
other Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
tests Bug 1512411 - Don't expose broken label children accessibles on a XUL toolbarbutton which specifies the label attribute, r=Jamie 2018-12-14 08:20:02 +00:00
windows Bug 1511393 - Use c-basic-offset: 2 in Emacs mode line for C/C++ code. r=nbp 2018-12-01 04:52:05 +09:00
xpcom Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format 2018-11-30 11:46:48 +01:00
xul Bug 1512411 - Don't expose broken label children accessibles on a XUL toolbarbutton which specifies the label attribute, r=Jamie 2018-12-14 08:20:02 +00:00
.eslintrc.js Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop 2018-02-07 16:16:09 +00:00
moz.build Bug 1479033 - Introduce Android accessibility directory. r=Jamie 2018-09-18 10:43:18 -07:00