gecko-dev/editor/libeditor
Masayuki Nakano cbb83f40f6 Bug 1655988 - Fix assertion in `WhiteSpaceVisibilityKeeper::MakeSureToKeepVisibleStateOfWhiteSpacesAroundDeletingRange()` r=m_kato
This is a bug of the assertion.

When there is 2 text nodes are adjacent, one ends with a visible character and
the other starts with a white-space, and the deleting range ends at end of the
first one, `GetReplaceRangeDataAtEndOfDeletionRange()` returns a range starting
with the start of the second one since it does not need to touch the first one.
Therefore, the white-space range start may be after the deleting range end.

This patch adds new condition to the `MOZ_ASSERT_IF`, and test this specific
case with new `MOZ_ASSERT_IF`.

Differential Revision: https://phabricator.services.mozilla.com/D110068
2021-03-30 06:09:23 +00:00
..
crashtests Bug 1655988 - Fix assertion in `WhiteSpaceVisibilityKeeper::MakeSureToKeepVisibleStateOfWhiteSpacesAroundDeletingRange()` r=m_kato 2021-03-30 06:09:23 +00:00
tests Bug 1692052 - Don't notify IMEContext of widget when IMEStateManger doesn't manage this content. r=masayuki 2021-03-15 09:31:58 +00:00
CSSEditUtils.cpp Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam 2020-12-17 14:04:35 +00:00
CSSEditUtils.h
ChangeAttributeTransaction.cpp
ChangeAttributeTransaction.h
ChangeStyleTransaction.cpp Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam 2020-12-17 14:04:35 +00:00
ChangeStyleTransaction.h Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam 2020-12-17 14:04:35 +00:00
CompositionTransaction.cpp
CompositionTransaction.h
CreateElementTransaction.cpp
CreateElementTransaction.h Bug 1673931 - Avoid including Element.h from header files. 2020-11-23 16:08:40 +00:00
DeleteNodeTransaction.cpp
DeleteNodeTransaction.h
DeleteRangeTransaction.cpp
DeleteRangeTransaction.h
DeleteTextTransaction.cpp
DeleteTextTransaction.h
EditAction.h
EditActionListener.h
EditAggregateTransaction.cpp Bug 1683534 - Make `editor` buildable outside of `unified-build` environment. r=sg 2021-01-04 14:18:50 +00:00
EditAggregateTransaction.h
EditTransactionBase.cpp
EditTransactionBase.h
EditorBase.cpp Bug 1692673 - Avoid enabling Cut/Copy menu commands in text editor context when there's no selection, unless a listener is present. r=masayuki 2021-03-12 16:34:42 +00:00
EditorBase.h Bug 1220696 - part 5: Support "contentReadOnly" and "getHTML" commands in `<input>` and `<textarea>` r=smaug 2021-03-24 01:55:09 +00:00
EditorCommands.cpp Bug 1220696 - part 6: Support `insertLineBreak` and `insertParagraphSeparator` commands in `<textarea>` r=smaug 2021-03-24 01:55:09 +00:00
EditorCommands.h
EditorController.cpp
EditorController.h
EditorDOMPoint.h
EditorEventListener.cpp Bug 1678361 - Return gracely when GetDataTransfer fails r=masayuki 2020-11-20 06:04:43 +00:00
EditorEventListener.h
EditorUtils.cpp Bug 1677566 - part 3: Ignore non-deletable ranges in `HTMLEditor::HandleDeleteSelection()` r=m_kato 2021-03-09 23:57:54 +00:00
EditorUtils.h Bug 1677566 - part 3: Ignore non-deletable ranges in `HTMLEditor::HandleDeleteSelection()` r=m_kato 2021-03-09 23:57:54 +00:00
HTMLAbsPositionEditor.cpp Bug 1683534 - Make `editor` buildable outside of `unified-build` environment. r=sg 2021-01-04 14:18:50 +00:00
HTMLAnonymousNodeEditor.cpp Bug 1682003 - Avoid UTF-8 -> UTF-16 conversion during CSSOM serialization. r=heycam 2020-12-17 14:04:35 +00:00
HTMLEditSubActionHandler.cpp Bug 1697249 - Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato 2021-03-11 07:19:33 +00:00
HTMLEditUtils.cpp Bug 1517028 - Make `HTMLEditor::SplitNodeDeepWithTransaction` not try to split non-splittable node and `HTMLEditor::HandleInsertParagraphInHeadingElement` check its result r=m_kato 2021-03-02 00:51:05 +00:00
HTMLEditUtils.h Bug 1677566 - part 2: Make `HTMLEditUtils` treat a found non-editable element as a leaf node even if it has children r=m_kato 2021-03-09 23:57:54 +00:00
HTMLEditor.cpp Bug 1677566 - part 3: Ignore non-deletable ranges in `HTMLEditor::HandleDeleteSelection()` r=m_kato 2021-03-09 23:57:54 +00:00
HTMLEditor.h Bug 1697249 - Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato 2021-03-11 07:19:33 +00:00
HTMLEditorCommands.cpp
HTMLEditorController.cpp
HTMLEditorController.h
HTMLEditorDataTransfer.cpp Bug 1697249 - Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato 2021-03-11 07:19:33 +00:00
HTMLEditorDeleteHandler.cpp Bug 1677566 - part 3: Ignore non-deletable ranges in `HTMLEditor::HandleDeleteSelection()` r=m_kato 2021-03-09 23:57:54 +00:00
HTMLEditorDocumentCommands.cpp Bug 1220696 - part 5: Support "contentReadOnly" and "getHTML" commands in `<input>` and `<textarea>` r=smaug 2021-03-24 01:55:09 +00:00
HTMLEditorEventListener.cpp Bug 1357365 - part 2: Make `TypeInState::OnSelectionChange()` stop inserting new content into the link if clicked outside it r=m_kato 2021-01-13 01:55:27 +00:00
HTMLEditorEventListener.h Bug 1357365 - part 1: Rename `HTMLEditor::OnMouseDown()`, `HTMLEditor::OnMouseUp()` and `HTMLEditor::OnMouseMove()` r=m_kato 2021-01-13 01:54:17 +00:00
HTMLEditorObjectResizer.cpp Bug 1357365 - part 1: Rename `HTMLEditor::OnMouseDown()`, `HTMLEditor::OnMouseUp()` and `HTMLEditor::OnMouseMove()` r=m_kato 2021-01-13 01:54:17 +00:00
HTMLEditorState.cpp Bug 1683534 - Make `editor` buildable outside of `unified-build` environment. r=sg 2021-01-04 14:18:50 +00:00
HTMLInlineTableEditor.cpp
HTMLStyleEditor.cpp Bug 1697249 - Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato 2021-03-11 07:19:33 +00:00
HTMLTableEditor.cpp Bug 1671768 - Part 4: Use MOZ_CAN_RUN_SCRIPT for Selection::RemoveAllRanges r=masayuki 2021-02-03 21:52:48 +00:00
InsertNodeTransaction.cpp Bug 1695650 - Avoid to warn always. r=masayuki 2021-03-09 00:24:27 +00:00
InsertNodeTransaction.h
InsertTextTransaction.cpp
InsertTextTransaction.h
InternetCiter.cpp
InternetCiter.h
JoinNodeTransaction.cpp
JoinNodeTransaction.h
ManualNAC.h
PlaceholderTransaction.cpp
PlaceholderTransaction.h
ReplaceTextTransaction.cpp
ReplaceTextTransaction.h Bug 1678062 - Remove unnecessary includes. r=andi 2020-11-23 16:12:02 +00:00
SelectionState.cpp
SelectionState.h
SplitNodeTransaction.cpp
SplitNodeTransaction.h
TextEditSubActionHandler.cpp Bug 1615296 - Part 2: Fix MOZ_CAN_RUN_SCRIPT warnings in editor module r=masayuki 2020-10-15 19:12:44 +00:00
TextEditor.cpp Bug 1698734 - Don't create an EventListenerManager just to check for existing listeners. r=smaug 2021-03-16 12:49:44 +00:00
TextEditor.h Bug 1692673 - Avoid enabling Cut/Copy menu commands in text editor context when there's no selection, unless a listener is present. r=masayuki 2021-03-12 16:34:42 +00:00
TextEditorDataTransfer.cpp Bug 1680167 - Part 6: Use RefPtr for nsFocusManager in editor r=masayuki 2020-12-03 21:35:20 +00:00
TypeInState.cpp Bug 1697249 - Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato 2021-03-11 07:19:33 +00:00
TypeInState.h Bug 1697249 - Stop creating `<span>` element for keeping same style as the link when the link will be unlinked r=m_kato 2021-03-11 07:19:33 +00:00
WSRunObject.cpp Bug 1655988 - Fix assertion in `WhiteSpaceVisibilityKeeper::MakeSureToKeepVisibleStateOfWhiteSpacesAroundDeletingRange()` r=m_kato 2021-03-30 06:09:23 +00:00
WSRunObject.h Bug 1677566 - part 1: `WSRunScanner::TextFragmentData` stop handling non-editable content r=m_kato 2021-03-09 23:57:54 +00:00
moz.build Bug 1673790 - Split `editor/libeditor/HTMLEditSubActionHandler.cpp` r=m_kato 2020-10-28 13:08:34 +00:00