Nathan Froyd cfb8fb313f Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg ... This patch was generated by running: ``` perl -p -i \ -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \ -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \ $FILE ``` against every .cpp and .h in mozilla-central, and then fixing up the inevitable errors that happen as a result of matching C++ expressions with regexes. The errors fell into three categories: 1. Calling the convert functions with `std::string::c_str()`; these were changed to simply pass the string instead, relying on implicit conversion to `mozilla::Span`. 2. Calling the convert functions with raw pointers, which is not permitted with the copy functions; these were changed to invoke `MakeStringSpan` first. 3. Other miscellaneous errors resulting from over-eager regexes and/or the replacement not being type-aware. These changes were reverted. Differential Revision: https://phabricator.services.mozilla.com/D88903		2020-09-02 09:54:37 +00:00
..
build	Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi	2020-07-09 21:42:25 +00:00
rust	…
test	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
variant	Bug 1622949 - Add `HashPropertyBag::clone_from_bag`. r=froydnj	2020-03-17 23:33:45 +00:00
FileSystemModule.cpp	…
FileSystemModule.h	…
IStorageBindingParamsInternal.h	…
SQLCollations.cpp	…
SQLCollations.h	…
SQLiteMutex.h	…
StatementCache.h	Bug 1626456 - Remove stray nsAutoPtr.h includes. r=KrisWright	2020-04-03 21:05:46 +00:00
StorageBaseStatementInternal.cpp	Bug 1654992 - Use std::move instead of SwapElements where possible. r=froydnj	2020-08-04 11:27:07 +00:00
StorageBaseStatementInternal.h	Bug 1626456 - Remove stray nsAutoPtr.h includes. r=KrisWright	2020-04-03 21:05:46 +00:00
TelemetryVFS.cpp	Bug 1650201 - Fix mozStorage prefs read before profile and fallback to a non-exclusive VFS when it can't get an exclusive lock. r=asuth,geckoview-reviewers,agi	2020-07-10 21:45:53 +00:00
VacuumManager.cpp	Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg	2020-09-02 09:54:37 +00:00
VacuumManager.h	…
Variant.cpp	…
Variant.h	Bug 1613985 - Use default for equivalent-to-default constructors/destructors in storage. r=asuth	2020-03-16 10:56:56 +00:00
Variant_inl.h	…
moz.build	Bug 1620198 - Part 4: Remove mozIStorageAggregateFunction. r=asuth	2020-06-08 10:00:31 +00:00
mozIStorageAsyncConnection.idl	Bug 1620198 - Part 1: Remove CreateAggregateFunction. r=asuth	2020-06-08 09:59:57 +00:00
mozIStorageAsyncStatement.idl	…
mozIStorageBaseStatement.idl	…
mozIStorageBindingParams.idl	…
mozIStorageBindingParamsArray.idl	…
mozIStorageCompletionCallback.idl	…
mozIStorageConnection.idl	…
mozIStorageError.idl	…
mozIStorageFunction.idl	…
mozIStoragePendingStatement.idl	…
mozIStorageProgressHandler.idl	…
mozIStorageResultSet.idl	…
mozIStorageRow.idl	…
mozIStorageService.idl	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozIStorageStatement.idl	…
mozIStorageStatementCallback.idl	…
mozIStorageVacuumParticipant.idl	…
mozIStorageValueArray.idl	…
mozStorageArgValueArray.cpp	…
mozStorageArgValueArray.h	…
mozStorageAsyncStatement.cpp	Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj	2020-07-01 08:29:29 +00:00
mozStorageAsyncStatement.h	Bug 1626456 - Remove stray nsAutoPtr.h includes. r=KrisWright	2020-04-03 21:05:46 +00:00
mozStorageAsyncStatementExecution.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageAsyncStatementExecution.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageAsyncStatementJSHelper.cpp	…
mozStorageAsyncStatementJSHelper.h	…
mozStorageAsyncStatementParams.cpp	…
mozStorageAsyncStatementParams.h	…
mozStorageBindingParams.cpp	Bug 1628715 - Part 15: Replace MOZ_NONNULL_RETURN by returning NotNull<elem_type*>. r=xpcom-reviewers,necko-reviewers,dragana,nika	2020-04-24 13:35:27 +00:00
mozStorageBindingParams.h	…
mozStorageBindingParamsArray.cpp	Bug 1628715 - Part 15: Replace MOZ_NONNULL_RETURN by returning NotNull<elem_type*>. r=xpcom-reviewers,necko-reviewers,dragana,nika	2020-04-24 13:35:27 +00:00
mozStorageBindingParamsArray.h	Bug 1626456 - Remove stray nsAutoPtr.h includes. r=KrisWright	2020-04-03 21:05:46 +00:00
mozStorageConnection.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageConnection.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageError.cpp	…
mozStorageError.h	…
mozStorageHelper.h	Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj	2020-07-01 08:29:29 +00:00
mozStoragePrivateHelpers.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStoragePrivateHelpers.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageResultSet.cpp	…
mozStorageResultSet.h	…
mozStorageRow.cpp	…
mozStorageRow.h	…
mozStorageSQLFunctions.cpp	…
mozStorageSQLFunctions.h	…
mozStorageService.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageService.h	Bug 1650201 - Fix mozStorage prefs read before profile and fallback to a non-exclusive VFS when it can't get an exclusive lock. r=asuth,geckoview-reviewers,agi	2020-07-10 21:45:53 +00:00
mozStorageStatement.cpp	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageStatement.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageStatementData.h	Bug 1635489: Add telemetry on the status of sqlite database accesses. r=mak	2020-08-11 20:55:33 +00:00
mozStorageStatementJSHelper.cpp	…
mozStorageStatementJSHelper.h	…
mozStorageStatementParams.cpp	…
mozStorageStatementParams.h	…
mozStorageStatementRow.cpp	…
mozStorageStatementRow.h	…
storage.h	…
style.txt	…
variantToSQLiteT_impl.h	…