gecko-dev/storage
Nicholas Nethercote c2306345d5 Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.

The patch also does some associated clean-up.

- Replaces some uses of nsIMemoryReporterCallback with the preferred
  nsIHandleReportCallback typedef.

- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
  parameter names, for consistency.

- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.

- Uses the MOZ_COLLECT_REPORT macro in all suitable places.

Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.

--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
..
build Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 2016-07-14 10:16:42 -06:00
test Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm. 2016-08-08 12:18:10 +10:00
.eslintrc Bug 1230549 - Make Storage pass basic eslint. r=yoric 2015-12-04 15:52:43 +01:00
FileSystemModule.cpp Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
FileSystemModule.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
IStorageBindingParamsInternal.h Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
SQLCollations.cpp Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
SQLCollations.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
SQLiteMutex.h bug 1244743 - Replace MOZ_NATIVE_X with MOZ_SYSTEM_X. r=gps 2016-02-01 10:49:34 -05:00
StatementCache.h Bug 1187141 - Replace nsBaseHashtable::Enumerate() calls in storage/ with iterators. r=mak. 2016-01-24 18:09:12 -08:00
StorageBaseStatementInternal.cpp Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm. 2016-08-08 12:18:10 +10:00
StorageBaseStatementInternal.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
TelemetryVFS.cpp Bug 1278468 - Fix -Wshadow warnings in storage/ directory. r=mak 2016-06-07 22:08:41 -07:00
VacuumManager.cpp Bug 1278468 - Fix -Wshadow warnings in storage/ directory. r=mak 2016-06-07 22:08:41 -07:00
VacuumManager.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
Variant.h Bug 968520 - Add mozilla::fallible to FallibleTArray::AppendElements calls. r=froydnj 2015-05-28 11:07:43 -07:00
Variant_inl.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
moz.build Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 2016-07-14 10:16:42 -06:00
mozIStorageAggregateFunction.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageAsyncConnection.idl Bug 1283083 - Cloning a connection should re-attach databases to the clone. r=asuth 2016-06-29 17:33:15 +02:00
mozIStorageAsyncStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageBaseStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageBindingParams.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageBindingParamsArray.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageCompletionCallback.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageConnection.idl Bug 1283083 - Cloning a connection should re-attach databases to the clone. r=asuth 2016-06-29 17:33:15 +02:00
mozIStorageError.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageFunction.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStoragePendingStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageProgressHandler.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageResultSet.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageRow.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageService.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatementCallback.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatementParams.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatementRow.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageVacuumParticipant.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageValueArray.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozStorageArgValueArray.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageArgValueArray.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageAsyncStatement.cpp Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj. 2016-08-08 10:54:47 +10:00
mozStorageAsyncStatement.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatementExecution.cpp Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm. 2016-08-08 12:18:10 +10:00
mozStorageAsyncStatementExecution.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatementJSHelper.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatementJSHelper.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageAsyncStatementParams.cpp Bug 1140482 - Add JSPROP_RESOLVING. Give NativeDefineProperty standard behavior in cases where a non-resolving define needs to trigger a resolve hook. r=Waldo. 2015-05-01 14:03:17 -05:00
mozStorageAsyncStatementParams.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageBindingParams.cpp Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug 2016-01-12 18:16:59 +00:00
mozStorageBindingParams.h Bug 1186791 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak. 2015-10-29 16:04:41 -07:00
mozStorageBindingParamsArray.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageBindingParamsArray.h Bug 1237151 (part 3) - Remove ignored qualifiers in all remaining code. r=froydnj. 2016-01-05 17:08:45 -08:00
mozStorageConnection.cpp Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 2016-08-24 14:47:04 +08:00
mozStorageConnection.h Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm. 2016-08-08 12:18:10 +10:00
mozStorageError.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageError.h Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
mozStorageHelper.h Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozStoragePrivateHelpers.cpp Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm. 2016-08-08 12:18:10 +10:00
mozStoragePrivateHelpers.h Bug 1248757 followup - Release blob after assignment in DoGetBlobAsString on CLOSED TREE. 2016-02-17 11:57:59 +08:00
mozStorageResultSet.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageResultSet.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageRow.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageRow.h Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug 2016-01-12 18:16:59 +00:00
mozStorageSQLFunctions.cpp Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-02-02 17:36:30 +02:00
mozStorageSQLFunctions.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageService.cpp Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm. 2016-08-24 15:23:45 +10:00
mozStorageService.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageStatement.cpp Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj. 2016-08-08 10:54:47 +10:00
mozStorageStatement.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageStatementData.h Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley 2016-02-10 08:23:00 +01:00
mozStorageStatementJSHelper.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageStatementJSHelper.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageStatementParams.cpp Bug 1231378 - part 4 - Fix uninitialized members of classes in netwerk/widget/storage/uriloader/memory/tools, r=smaug 2016-01-12 18:16:59 +00:00
mozStorageStatementParams.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageStatementRow.cpp Bug 1184564 part 2 - Use Value instead of jsval in dom/ and storage/. r=bz 2015-07-18 21:45:35 +02:00
mozStorageStatementRow.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
storage.h Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
style.txt
variantToSQLiteT_impl.h Bug 1278468 - Fix -Wshadow warnings in storage/ directory. r=mak 2016-06-07 22:08:41 -07:00