зеркало из https://github.com/mozilla/gecko-dev.git
14ac3915d9
This patch does remove the pageActionExtras experimental API, which is what started triggering those errors after the pageAction manifest property was removed from the manifest in Bug 1690573: - The pageActionExtras API was internally retrieving the pageAction API class (see https://searchfox.org/mozilla-central/rev/eeb8cf278192d68b3977d0adb4d43f1463439269/browser/extensions/report-site-issue/experimentalAPIs/pageActionExtras.js#12-16) which is a bit of an hack and it used to work because there was a pageAction property in the manifest.json file (and that was what used to guarantee that the ext-pageAction.js API module was always loaded before the background page of the extension did have a chance to run) - In Bug 1690573 we removed the pageAction property from the manifest and as a side-effect the ext-pageAction.js module wouldn't be loaded anymore, which did break the assumption in the pageActionExtras API (and the extension background page script as a side effect of that) I assume that if we removed the pageAction from the manifest, then we don't need the pageActionExtras experimental API neither (it seems that its purpose was to localize the pageAction and to set a custom telemetry label for it) and so to fix the regression I opted to remove the remaining traces of the pageActionExtras experimental API. NOTE: there are some more traces left in head.js, which are used for the test cases. All the tests are currently disabled and it seems that they are meant to be re-enabled as part or as a follow up of Bug 1693119 and so I think that for those parts we can wait to get there. Differential Revision: https://phabricator.services.mozilla.com/D107326 |
||
|---|---|---|
| .. | ||
| experimentalAPIs | ||
| icons | ||
| locales | ||
| test/browser | ||
| .eslintrc.js | ||
| background.js | ||
| manifest.json | ||
| moz.build | ||