зеркало из https://github.com/mozilla/gecko-dev.git
481aa7905b
This is the third attempt to investigate the launcher failure of our detour. The previous commits d8315e4ed18d and 1b81ea85c43d added the assembly bytes of a detour target and a special error code `DetourResultCode` to the launcher failure ping. In the latest telemetry data, however, the most common value of `hresult` is still `ERROR_UNIDENTIFIED_ERROR`, meaning the previous commit missed to set an error code in the common fallible codepath we wanted to know. Besides `ERROR_UNIDENTIFIED_ERROR`, we're seeing `DETOUR_PATCHER_DO_RESERVE_ERROR` in the telemetry, but having that code is not enough to pinpoint a falling operation. For further investigation, this patch adds ten more values to `DetourResultCode`. `FUNCHOOKCROSSPROCESS_COPYSTUB_ERROR` is the last codepath we forgot to cover in the previous commit. The values of `MMPOLICY_RESERVE_*` are to investigate `DETOUR_PATCHER_DO_RESERVE_ERROR` in the MMPolicy level. In both cases, we add the last Windows error code to `DetourError::mOrigBytes`. Differential Revision: https://phabricator.services.mozilla.com/D92974 |
||
---|---|---|
.. | ||
android | ||
baseprofiler | ||
build | ||
dllservices | ||
linker | ||
misc | ||
static | ||
tests | ||
moz.build |